mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 21:03:54 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Add background color option for media detail page (#5394)

Browse source 
* feat: add backgroundColor property on media

* feat: add optional menu items for media backgroundColor

* fix: test pass when running in batch

* refactor: remove backgroundColor from media

* refactor: add string for background color menu

* chore: remove useless change

* feat: change media image background color

* feat: pass backgroundColor to ZoomableActivity

* chore: remove extra space
This commit is contained in:
Pierre Monier 2023-11-30 02:07:53 +01:00 • committed by GitHub
parent 9028e0ed32
commit e1e4f9329a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 260 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

20
app/src/main/res/menu/fragment_image_detail.xml
View file

@ -38,5 +38,25 @@
android:id="@+id/menu_view_report"
android:title="@string/menu_view_report"
app:showAsAction="never" />
<!--
Setting visible and enabled to false as default because
we only want to show it in a very specific case
-->
<item
android:id="@+id/menu_view_set_white_background"
android:title="@string/menu_view_set_white_background"
android:visible="false"
android:enabled="false"
app:showAsAction="never" />
<!--
Setting visible and enabled to false as default because
we only want to show it in a very specific case
-->
<item
android:id="@+id/menu_view_set_black_background"
android:title="@string/menu_view_set_black_background"
android:visible="false"
android:enabled="false"
app:showAsAction="never" />
</menu>

2
app/src/main/res/values/strings.xml
View file

@ -770,6 +770,8 @@ Upload your first media by tapping on the add button.</string>
<string name="image_selected">Image selected</string>
<string name="image_marked_as_not_for_upload">Image marked as not for upload</string>
<string name="menu_view_report">Report</string>
<string name="menu_view_set_white_background">Set white background</string>
<string name="menu_view_set_black_background">Set black background</string>
<string name="report_violation">Report violation</string>
<string name="report_user">Report this user</string>
<string name="report_content">Report this content</string>