diff --git a/app/src/main/java/fr/free/nrw/commons/auth/LoginActivity.java b/app/src/main/java/fr/free/nrw/commons/auth/LoginActivity.java index 0bec4bac6..a42fef7cf 100644 --- a/app/src/main/java/fr/free/nrw/commons/auth/LoginActivity.java +++ b/app/src/main/java/fr/free/nrw/commons/auth/LoginActivity.java @@ -43,7 +43,6 @@ public class LoginActivity extends AccountAuthenticatorActivity { app = CommonsApplication.getInstance(); setContentView(R.layout.activity_login); - final LoginActivity that = this; loginButton = (Button) findViewById(R.id.loginButton); Button signupButton = (Button) findViewById(R.id.signupButton); @@ -62,12 +61,14 @@ public class LoginActivity extends AccountAuthenticatorActivity { loginButton.setOnClickListener(new View.OnClickListener() { @Override public void onClick(View v) { - that.performLogin(); + performLogin(); } }); signupButton.setOnClickListener(new View.OnClickListener() { @Override - public void onClick(View v) { that.signUp(v); } + public void onClick(View v) { + signUp(v); + } }); } @@ -115,7 +116,7 @@ public class LoginActivity extends AccountAuthenticatorActivity { protected void onResume() { super.onResume(); if (prefs.getBoolean("firstrun", true)) { - this.startWelcomeIntent(); + startWelcomeIntent(); prefs.edit().putBoolean("firstrun", false).apply(); } if (app.getCurrentAccount() != null) { diff --git a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsActivity.java b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsActivity.java index e1d39db06..48b69b38b 100644 --- a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsActivity.java +++ b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsActivity.java @@ -81,6 +81,7 @@ public class ContributionsActivity @Override protected void onDestroy() { + getSupportFragmentManager().removeOnBackStackChangedListener(this); super.onDestroy(); if(isUploadServiceConnected) { unbindService(uploadServiceConnection); diff --git a/app/src/main/java/fr/free/nrw/commons/upload/MultipleShareActivity.java b/app/src/main/java/fr/free/nrw/commons/upload/MultipleShareActivity.java index 944c86edc..5a4ea62b8 100644 --- a/app/src/main/java/fr/free/nrw/commons/upload/MultipleShareActivity.java +++ b/app/src/main/java/fr/free/nrw/commons/upload/MultipleShareActivity.java @@ -115,7 +115,7 @@ public class MultipleShareActivity Timber.d("Multiple upload begins"); - final ProgressDialog dialog = new ProgressDialog(MultipleShareActivity.this); + final ProgressDialog dialog = new ProgressDialog(this); dialog.setIndeterminate(false); dialog.setProgressStyle(ProgressDialog.STYLE_HORIZONTAL); dialog.setMax(photosList.size()); @@ -145,12 +145,12 @@ public class MultipleShareActivity uploadsList.setImageOnlyMode(true); - categorizationFragment = (CategorizationFragment) this.getSupportFragmentManager().findFragmentByTag("categorization"); + categorizationFragment = (CategorizationFragment) getSupportFragmentManager().findFragmentByTag("categorization"); if(categorizationFragment == null) { categorizationFragment = new CategorizationFragment(); } // FIXME: Stops the keyboard from being shown 'stale' while moving out of this fragment into the next - View target = this.getCurrentFocus(); + View target = getCurrentFocus(); if (target != null) { InputMethodManager imm = (InputMethodManager) target.getContext().getSystemService(Context.INPUT_METHOD_SERVICE); imm.hideSoftInputFromWindow(target.getWindowToken(), 0); @@ -221,18 +221,19 @@ public class MultipleShareActivity @Override protected void onDestroy() { super.onDestroy(); + getSupportFragmentManager().removeOnBackStackChangedListener(this); uploadController.cleanup(); } private void showDetail(int i) { if(mediaDetails == null ||!mediaDetails.isVisible()) { mediaDetails = new MediaDetailPagerFragment(true); - this.getSupportFragmentManager() + getSupportFragmentManager() .beginTransaction() .replace(R.id.uploadsFragmentContainer, mediaDetails) .addToBackStack(null) .commit(); - this.getSupportFragmentManager().executePendingTransactions(); + getSupportFragmentManager().executePendingTransactions(); } mediaDetails.showImage(i); } @@ -267,7 +268,7 @@ public class MultipleShareActivity uploadsList = (MultipleUploadListFragment) getSupportFragmentManager().findFragmentByTag("uploadsList"); if(uploadsList == null) { uploadsList = new MultipleUploadListFragment(); - this.getSupportFragmentManager() + getSupportFragmentManager() .beginTransaction() .add(R.id.uploadsFragmentContainer, uploadsList, "uploadsList") .commit();