From dd1814c7933fbbb3a09334407be8c7a475d07540 Mon Sep 17 00:00:00 2001 From: "Amir E. Aharoni" Date: Sat, 11 Oct 2025 01:53:57 -0400 Subject: [PATCH] Change filename to username in toasts about sending thanks (#6467) This fixes #6466. Also fix the messages themselves a bit: * Removed "successfully" from the success message. This word is usually redundant, because the message already says that it was done. (In MediaWiki, there's a specific convention about it: https://www.mediawiki.org/wiki/Help:System_message#Avoid_jargon_and_slanghttps://www.mediawiki.org/wiki/Help:System_message#Avoid_jargon_and_slang ) * Added a missing preposition to the failure message. Co-authored-by: Nicolas Raoul --- .../java/fr/free/nrw/commons/media/MediaDetailFragment.kt | 4 ++-- app/src/main/res/values/strings.xml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.kt b/app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.kt index dc1e86137..41e65ae4e 100644 --- a/app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.kt +++ b/app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.kt @@ -1027,12 +1027,12 @@ class MediaDetailFragment : CommonsDaggerSupportFragment(), CategoryEditHelper.C val message: String = if (result) { context.getString( R.string.send_thank_success_message, - media!!.displayTitle + media!!.user ) } else { context.getString( R.string.send_thank_failure_message, - media!!.displayTitle + media!!.user ) } diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 45519a370..084e33b88 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -493,8 +493,8 @@ Upload your first media by tapping on the add button. Requesting category check for %1$s Done Sending Thanks: Success - Successfully sent thanks to %1$s - Failed to send thanks %1$s + Sent thanks to %1$s + Failed to send thanks to %1$s Sending Thanks: Failure Sending Thanks for %1$s