Switch map button accoding to map and list

app/src/main/java/fr/free/nrw/commons/Utils.java

@@ -1,7 +1,9 @@
 package fr.free.nrw.commons;
 
+import android.content.Context;
 import android.net.Uri;
 import android.os.Build;
+import android.preference.PreferenceManager;
 
 import com.nostra13.universalimageloader.core.DisplayImageOptions;
 import com.nostra13.universalimageloader.core.assist.ImageScaleType;
@@ -306,4 +308,12 @@ public class Utils {
     public static boolean isNullOrWhiteSpace(String value) {
         return value == null || value.trim().isEmpty();
     }
+
+    public static boolean isDarkTheme(Context context){
+        if (PreferenceManager.getDefaultSharedPreferences(context).getBoolean("theme",true)) {
+            return true;
+        }else {
+            return false;
+        }
+    }
 }

app/src/main/java/fr/free/nrw/commons/nearby/NearbyActivity.java

@@ -3,6 +3,7 @@ package fr.free.nrw.commons.nearby;
 import android.net.Uri;
 import android.os.AsyncTask;
 import android.os.Bundle;
+import android.support.v4.app.Fragment;
 import android.support.v4.app.FragmentTransaction;
 import android.view.Menu;
 import android.view.MenuInflater;
@@ -71,6 +72,11 @@ public class NearbyActivity extends BaseActivity {
                 return true;
             case R.id.action_map:
                 showMapView();
+                if (isMapViewActive) {
+                    item.setIcon(R.drawable.ic_list_white_24dp);
+                } else {
+                    item.setIcon(R.drawable.ic_map_white_24dp);
+                }
                 return true;
             default:
                 return super.onOptionsItemSelected(item);
@@ -83,9 +89,16 @@ public class NearbyActivity extends BaseActivity {
             if (nearbyAsyncTask.getStatus() == AsyncTask.Status.FINISHED) {
                 setMapFragment();
             }
+
+        } else {
+            isMapViewActive = false;
+            if (nearbyAsyncTask.getStatus() == AsyncTask.Status.FINISHED) {
+                setListFragment();
+            }
         }
     }
 
+
     @Override
     protected void onResume() {
         super.onResume();
@@ -160,22 +173,22 @@ public class NearbyActivity extends BaseActivity {
      * Calls fragment for map view.
      */
     public void setMapFragment() {
-        FragmentTransaction ft = getSupportFragmentManager().beginTransaction();
+        FragmentTransaction fragmentTransaction = getSupportFragmentManager().beginTransaction();
-        NearbyMapFragment fragment = new NearbyMapFragment();
+        Fragment fragment = new NearbyMapFragment();
         fragment.setArguments(bundle);
-        ft.add(R.id.container, fragment);
+        fragmentTransaction.replace(R.id.container, fragment);
-        ft.commit();
+        fragmentTransaction.commit();
     }
 
     /**
      * Calls fragment for list view.
      */
     public void setListFragment() {
-        FragmentTransaction ft = getSupportFragmentManager().beginTransaction();
+        FragmentTransaction fragmentTransaction = getSupportFragmentManager().beginTransaction();
-        NearbyListFragment fragment = new NearbyListFragment();
+        Fragment fragment = new NearbyListFragment();
         fragment.setArguments(bundle);
-        ft.add(R.id.container, fragment);
+        fragmentTransaction.replace(R.id.container, fragment);
-        ft.commit();
+        fragmentTransaction.commit();
     }
 
 }

app/src/main/java/fr/free/nrw/commons/theme/BaseActivity.java

@@ -6,16 +6,17 @@ import android.preference.PreferenceManager;
 import android.support.v7.app.AppCompatActivity;
 
 import fr.free.nrw.commons.R;
+import fr.free.nrw.commons.Utils;
 
 public class BaseActivity extends AppCompatActivity {
     boolean currentTheme;
 
     @Override
     protected void onCreate(Bundle savedInstanceState) {
-        if (PreferenceManager.getDefaultSharedPreferences(this).getBoolean("theme",true)) {
+        if(Utils.isDarkTheme(this)){
             currentTheme = true;
             setTheme(R.style.DarkAppTheme);
-        }else {
+        } else {
             currentTheme = false;
             setTheme(R.style.LightAppTheme); // default
         }