Improved the quality of pr

This commit is contained in:
tanvidadu 2018-05-24 02:30:46 +05:30
parent e09706c132
commit dbd2051982
4 changed files with 16 additions and 7 deletions

View file

@ -39,7 +39,9 @@
<action android:name="android.intent.action.MAIN" /> <action android:name="android.intent.action.MAIN" />
</intent-filter> </intent-filter>
</activity> </activity>
<activity android:name=".WelcomeActivity" /> <activity android:name=".WelcomeActivity" />
<activity <activity
android:name=".upload.ShareActivity" android:name=".upload.ShareActivity"
android:icon="@drawable/ic_launcher" android:icon="@drawable/ic_launcher"
@ -53,6 +55,7 @@
<data android:mimeType="audio/ogg" /> <data android:mimeType="audio/ogg" />
</intent-filter> </intent-filter>
</activity> </activity>
<activity <activity
android:name=".upload.MultipleShareActivity" android:name=".upload.MultipleShareActivity"
android:icon="@drawable/ic_launcher" android:icon="@drawable/ic_launcher"
@ -66,27 +69,34 @@
<data android:mimeType="audio/ogg" /> <data android:mimeType="audio/ogg" />
</intent-filter> </intent-filter>
</activity> </activity>
<activity <activity
android:name=".contributions.ContributionsActivity" android:name=".contributions.ContributionsActivity"
android:icon="@drawable/ic_launcher" android:icon="@drawable/ic_launcher"
android:label="@string/app_name" /> android:label="@string/app_name" />
<activity <activity
android:name=".settings.SettingsActivity" android:name=".settings.SettingsActivity"
android:label="@string/title_activity_settings" /> android:label="@string/title_activity_settings" />
<activity <activity
android:name=".AboutActivity" android:name=".AboutActivity"
android:label="@string/title_activity_about" android:label="@string/title_activity_about"
android:parentActivityName=".contributions.ContributionsActivity" /> android:parentActivityName=".contributions.ContributionsActivity" />
<activity <activity
android:name=".auth.SignupActivity" android:name=".auth.SignupActivity"
android:label="@string/title_activity_signup" /> android:label="@string/title_activity_signup" />
<activity <activity
android:name=".nearby.NearbyActivity" android:name=".nearby.NearbyActivity"
android:label="@string/title_activity_nearby" android:label="@string/title_activity_nearby"
android:parentActivityName=".contributions.ContributionsActivity" /> android:parentActivityName=".contributions.ContributionsActivity" />
<activity <activity
android:name=".notification.NotificationActivity" android:name=".notification.NotificationActivity"
android:label="@string/navigation_item_notification" /> android:label="@string/navigation_item_notification" />
<activity <activity
android:name=".category.CategoryImagesActivity" android:name=".category.CategoryImagesActivity"
android:label="@string/title_activity_featured_images" android:label="@string/title_activity_featured_images"
@ -110,6 +120,7 @@
android:name="android.accounts.AccountAuthenticator" android:name="android.accounts.AccountAuthenticator"
android:resource="@xml/authenticator" /> android:resource="@xml/authenticator" />
</service> </service>
<service <service
android:name=".contributions.ContributionsSyncService" android:name=".contributions.ContributionsSyncService"
android:exported="true"> android:exported="true">
@ -121,6 +132,7 @@
android:name="android.content.SyncAdapter" android:name="android.content.SyncAdapter"
android:resource="@xml/contributions_sync_adapter" /> android:resource="@xml/contributions_sync_adapter" />
</service> </service>
<service <service
android:name=".modifications.ModificationsSyncService" android:name=".modifications.ModificationsSyncService"
android:exported="true"> android:exported="true">
@ -142,18 +154,21 @@
android:name="android.support.FILE_PROVIDER_PATHS" android:name="android.support.FILE_PROVIDER_PATHS"
android:resource="@xml/provider_paths" /> android:resource="@xml/provider_paths" />
</provider> </provider>
<provider <provider
android:name=".contributions.ContributionsContentProvider" android:name=".contributions.ContributionsContentProvider"
android:authorities="fr.free.nrw.commons.contributions.contentprovider" android:authorities="fr.free.nrw.commons.contributions.contentprovider"
android:exported="false" android:exported="false"
android:label="@string/provider_contributions" android:label="@string/provider_contributions"
android:syncable="true" /> android:syncable="true" />
<provider <provider
android:name=".modifications.ModificationsContentProvider" android:name=".modifications.ModificationsContentProvider"
android:authorities="fr.free.nrw.commons.modifications.contentprovider" android:authorities="fr.free.nrw.commons.modifications.contentprovider"
android:exported="false" android:exported="false"
android:label="@string/provider_modifications" android:label="@string/provider_modifications"
android:syncable="true" /> android:syncable="true" />
<provider <provider
android:name=".category.CategoryContentProvider" android:name=".category.CategoryContentProvider"
android:authorities="fr.free.nrw.commons.categories.contentprovider" android:authorities="fr.free.nrw.commons.categories.contentprovider"

View file

@ -60,7 +60,6 @@ public class Utils {
/** /**
* URL Encode an URL in UTF-8 format * URL Encode an URL in UTF-8 format
*
* @param url Unformatted URL * @param url Unformatted URL
* @return Encoded URL * @return Encoded URL
*/ */
@ -84,7 +83,6 @@ public class Utils {
/** /**
* Generates licence name with given ID * Generates licence name with given ID
*
* @param license License ID * @param license License ID
* @return Name of license * @return Name of license
*/ */
@ -110,7 +108,6 @@ public class Utils {
/** /**
* Fixing incorrect extension * Fixing incorrect extension
*
* @param title File name * @param title File name
* @param extension Correct extension * @param extension Correct extension
* @return File with correct extension * @return File with correct extension
@ -132,7 +129,6 @@ public class Utils {
/** /**
* Tells whether dark theme is active or not * Tells whether dark theme is active or not
*
* @param context Activity context * @param context Activity context
* @return The state of dark theme * @return The state of dark theme
*/ */

View file

@ -472,7 +472,6 @@ public class ApacheHttpClientMediaWikiApi implements MediaWikiApi {
* The method takes categoryName as input and returns a List of Media objects * The method takes categoryName as input and returns a List of Media objects
* It uses the generator query API to get the images in a category, 10 at a time. * It uses the generator query API to get the images in a category, 10 at a time.
* Uses the query continue values for fetching paginated responses * Uses the query continue values for fetching paginated responses
*
* @param categoryName Category name as defined on commons * @param categoryName Category name as defined on commons
* @return * @return
*/ */
@ -524,7 +523,6 @@ public class ApacheHttpClientMediaWikiApi implements MediaWikiApi {
* For APIs that return paginated responses, MediaWiki APIs uses the QueryContinue to facilitate fetching of subsequent pages * For APIs that return paginated responses, MediaWiki APIs uses the QueryContinue to facilitate fetching of subsequent pages
* https://www.mediawiki.org/wiki/API:Raw_query_continue * https://www.mediawiki.org/wiki/API:Raw_query_continue
* After fetching images a page of image for a particular category, shared prefs are updated with the latest QueryContinue Values * After fetching images a page of image for a particular category, shared prefs are updated with the latest QueryContinue Values
*
* @param keyword * @param keyword
* @param queryContinue * @param queryContinue
*/ */
@ -536,7 +534,6 @@ public class ApacheHttpClientMediaWikiApi implements MediaWikiApi {
/** /**
* Before making a paginated API call, this method is called to get the latest query continue values to be used * Before making a paginated API call, this method is called to get the latest query continue values to be used
*
* @param keyword * @param keyword
* @return * @return
*/ */

View file

@ -70,6 +70,7 @@ public abstract class NavigationBaseActivity extends BaseActivity
View navHeaderView = navigationView.getHeaderView(0); View navHeaderView = navigationView.getHeaderView(0);
TextView username = navHeaderView.findViewById(R.id.username); TextView username = navHeaderView.findViewById(R.id.username);
AccountManager accountManager = AccountManager.get(this); AccountManager accountManager = AccountManager.get(this);
Account[] allAccounts = accountManager.getAccountsByType(AccountUtil.ACCOUNT_TYPE); Account[] allAccounts = accountManager.getAccountsByType(AccountUtil.ACCOUNT_TYPE);
if (allAccounts.length != 0) { if (allAccounts.length != 0) {