mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 12:53:55 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Added progressbar in ContributionsListFragment to be shown while its loading contributions

Browse source
This commit is contained in:
Vishan Seru 2017-10-11 22:16:39 +05:30
parent 7e5d8c4c79
commit d98a0263fd
3 changed files with 18 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/src/main/java/fr/free/nrw/commons/contributions/ContributionsActivity.java
View file

@ -238,6 +238,8 @@ public class ContributionsActivity extends AuthenticatedActivity
@Override @Override
public void onLoadFinished(Loader<Cursor> cursorLoader, Cursor cursor) { public void onLoadFinished(Loader<Cursor> cursorLoader, Cursor cursor) {
contributionsList.changeProgressBarVisibility(false);
if (contributionsList.getAdapter() == null) { if (contributionsList.getAdapter() == null) {
contributionsList.setAdapter(new ContributionsListAdapter(getApplicationContext(), contributionsList.setAdapter(new ContributionsListAdapter(getApplicationContext(),
cursor, 0)); cursor, 0));

11
app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListFragment.java
View file

@ -19,6 +19,7 @@ import android.view.ViewGroup;
import android.widget.AdapterView; import android.widget.AdapterView;
import android.widget.GridView; import android.widget.GridView;
import android.widget.ListAdapter; import android.widget.ListAdapter;
import android.widget.ProgressBar;
import android.widget.TextView; import android.widget.TextView;
import butterknife.BindView; import butterknife.BindView;
@ -41,8 +42,9 @@ public class ContributionsListFragment extends Fragment {
GridView contributionsList; GridView contributionsList;
@BindView(R.id.waitingMessage) @BindView(R.id.waitingMessage)
TextView waitingMessage; TextView waitingMessage;
@BindView(R.id.emptyMessage) @BindView(R.id.loadingContributionsProgressBar)
TextView emptyMessage; ProgressBar progressBar;
private ContributionController controller; private ContributionController controller;
@Override @Override
@ -67,6 +69,7 @@ public class ContributionsListFragment extends Fragment {
waitingMessage.setVisibility(GONE); waitingMessage.setVisibility(GONE);
} }
changeProgressBarVisibility(true);
return v; return v;
} }
@ -78,6 +81,10 @@ public class ContributionsListFragment extends Fragment {
this.contributionsList.setAdapter(adapter); this.contributionsList.setAdapter(adapter);
} }
public void changeProgressBarVisibility(boolean isVisible) {
this.progressBar.setVisibility(isVisible ? View.VISIBLE : View.GONE);
}
@Override @Override
public void onSaveInstanceState(Bundle outState) { public void onSaveInstanceState(Bundle outState) {
if (outState == null) { if (outState == null) {

14
app/src/main/res/layout/fragment_contributions.xml
View file

@ -1,5 +1,6 @@
<?xml version="1.0" encoding="utf-8"?> <?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" <RelativeLayout
xmlns:android="http://schemas.android.com/apk/res/android"
android:orientation="vertical" android:orientation="vertical"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="match_parent" android:layout_height="match_parent"
@ -13,15 +14,14 @@
android:id="@+id/waitingMessage" android:id="@+id/waitingMessage"
android:layout_gravity="center" android:layout_gravity="center"
android:visibility="gone" android:visibility="gone"
android:layout_centerHorizontal="true"
/> />
<TextView <ProgressBar
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:text="@string/no_uploads_yet" android:layout_centerInParent="true"
android:id="@+id/emptyMessage" android:id="@+id/loadingContributionsProgressBar"
android:layout_gravity="center"
android:visibility="gone"
/> />
<GridView <GridView
@ -36,4 +36,4 @@
android:fastScrollEnabled="true" android:fastScrollEnabled="true"
/> />
</LinearLayout> </RelativeLayout>