From d941c2fa8e682c7a26bf12fc1f141d5b6abd2d98 Mon Sep 17 00:00:00 2001 From: Jason Whitmore Date: Mon, 1 Jul 2024 16:13:26 -0700 Subject: [PATCH] LocationPickerActivity.java: rewrite method scope, name, and documentation Before this commit, the method name was unclear and the documentation did not fully explain the method's behavior. Additionally, it was a public method. This commit renames the method (also changing calls to it), adds more documentation, and changes the method scope from public to private. --- .../nrw/commons/LocationPicker/LocationPickerActivity.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/fr/free/nrw/commons/LocationPicker/LocationPickerActivity.java b/app/src/main/java/fr/free/nrw/commons/LocationPicker/LocationPickerActivity.java index 56c4919a2..1b8a5f043 100644 --- a/app/src/main/java/fr/free/nrw/commons/LocationPicker/LocationPickerActivity.java +++ b/app/src/main/java/fr/free/nrw/commons/LocationPicker/LocationPickerActivity.java @@ -331,7 +331,7 @@ public class LocationPickerActivity extends BaseActivity implements moveMapToMediaLocation(); modifyLocationButton.setOnClickListener(v -> onClickModifyLocation()); removeLocationButton.setOnClickListener(v -> onClickRemoveLocation()); - showInMapButton.setOnClickListener(v -> showInMap()); + showInMapButton.setOnClickListener(v -> showInMapApp()); darkThemeSetup(); } @@ -388,8 +388,9 @@ public class LocationPickerActivity extends BaseActivity implements /** * Show the location in map app. Map will center on EXIF location, if available. + * If there is no EXIF data, the map will center on the commons app map center. */ - public void showInMap() { + private void showInMapApp() { //Check to see if EXIF location data is available if(cameraPosition != null){ Utils.handleGeoCoordinates(this,