From d8e8bfb58b504fe0a2ae1b506ec29b35b3030cbd Mon Sep 17 00:00:00 2001
From: sonalyadav <sonal.y6390@gmail.com>
Date: Sat, 28 Jun 2025 18:35:40 +0530
Subject: [PATCH] fix popup from appearing in nearby

---
 .../upload/mediaDetails/UploadMediaPresenter.kt        |  5 ++++-
 .../main/res/values-x-invalidLanguageCode/error.xml    | 10 ----------
 2 files changed, 4 insertions(+), 11 deletions(-)
 delete mode 100644 app/src/main/res/values-x-invalidLanguageCode/error.xml

diff --git a/app/src/main/java/fr/free/nrw/commons/upload/mediaDetails/UploadMediaPresenter.kt b/app/src/main/java/fr/free/nrw/commons/upload/mediaDetails/UploadMediaPresenter.kt
index 77999cf2f..4d565adb2 100644
--- a/app/src/main/java/fr/free/nrw/commons/upload/mediaDetails/UploadMediaPresenter.kt
+++ b/app/src/main/java/fr/free/nrw/commons/upload/mediaDetails/UploadMediaPresenter.kt
@@ -107,7 +107,10 @@ class UploadMediaPresenter @Inject constructor(
                     view.showProgress(false)
                     val gpsCoords = uploadItem.gpsCoords
                     val hasImageCoordinates = gpsCoords != null && gpsCoords.imageCoordsExists
-                    if (hasImageCoordinates && place == null) {
+                    
+                    // Only check for nearby places if image has coordinates AND no place was pre-selected
+                    // This prevents the popup from appearing when uploading from Nearby feature
+                    if (hasImageCoordinates && place == null && uploadItem.place == null) {
                         checkNearbyPlaces(uploadItem)
                     }
                 }, { throwable: Throwable? ->
diff --git a/app/src/main/res/values-x-invalidLanguageCode/error.xml b/app/src/main/res/values-x-invalidLanguageCode/error.xml
deleted file mode 100644
index f4e2fe125..000000000
--- a/app/src/main/res/values-x-invalidLanguageCode/error.xml
+++ /dev/null
@@ -1,10 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<!-- Authors:
-* Vlad5250
--->
-<resources>
-  <string name="crash_dialog_title">کامَنٕز گوو رُکِتھ</string>
-  <string name="crash_dialog_text">Oops. کیہہ تام گوو غلط!</string>
-  <string name="crash_dialog_comment_prompt">ؤنِیوٚ اَسہِ توٚہہِ کیاہ ٲسِیوٚ کران، تہٕ کٕریٚو تہِ اَسہِ سٕتی شیر بذریعہِ برقی خط. یُس مَدَتھ کَرِ اَسہِ اَتھ شہَرنَس منٛز!</string>
-  <string name="crash_dialog_ok_toast">شُکریہ!</string>
-</resources>