From d858813a01fe23ec7fd5fbc7c2b79bce6ff9a305 Mon Sep 17 00:00:00 2001 From: neslihanturan Date: Mon, 2 Sep 2019 15:13:56 +0300 Subject: [PATCH] Request permission for nearby places if fragment is loaded and tab is selected --- .../nrw/commons/nearby/NearbyTestFragmentLayersActivity.java | 1 + .../fr/free/nrw/commons/nearby/NearbyTestLayersFragment.java | 5 +++-- .../nearby/mvp/presenter/NearbyParentFragmentPresenter.java | 2 ++ 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/fr/free/nrw/commons/nearby/NearbyTestFragmentLayersActivity.java b/app/src/main/java/fr/free/nrw/commons/nearby/NearbyTestFragmentLayersActivity.java index bf9aba661..7edd621b8 100644 --- a/app/src/main/java/fr/free/nrw/commons/nearby/NearbyTestFragmentLayersActivity.java +++ b/app/src/main/java/fr/free/nrw/commons/nearby/NearbyTestFragmentLayersActivity.java @@ -110,6 +110,7 @@ public class NearbyTestFragmentLayersActivity extends AuthenticatedActivity { case NEARBY_TAB_POSITION: Timber.d("Nearby tab selected"); tabLayout.getTabAt(NEARBY_TAB_POSITION).select(); + ((NearbyTestLayersFragment)contributionsActivityPagerAdapter.getItem(1)).nearbyParentFragmentPresenter.onTabSelected(); break; default: tabLayout.getTabAt(CONTRIBUTIONS_TAB_POSITION).select(); diff --git a/app/src/main/java/fr/free/nrw/commons/nearby/NearbyTestLayersFragment.java b/app/src/main/java/fr/free/nrw/commons/nearby/NearbyTestLayersFragment.java index 0bb9e7c10..09a21eadf 100644 --- a/app/src/main/java/fr/free/nrw/commons/nearby/NearbyTestLayersFragment.java +++ b/app/src/main/java/fr/free/nrw/commons/nearby/NearbyTestLayersFragment.java @@ -114,8 +114,8 @@ public class NearbyTestLayersFragment extends CommonsDaggerSupportFragment imple nearbyParentFragmentPresenter = new NearbyParentFragmentPresenter (this, mapFragment, locationManager); Timber.d("Child fragment attached"); - // TODO: find out why location manager is null - checkPermissionsAndPerformAction(this::registerLocationUpdates); + nearbyParentFragmentPresenter.nearbyFragmentsAreReady(); + //checkPermissionsAndPerformAction(this::registerLocationUpdates); } @Override @@ -178,6 +178,7 @@ public class NearbyTestLayersFragment extends CommonsDaggerSupportFragment imple @Override public void checkPermissionsAndPerformAction(Runnable runnable) { + Log.d("denemeTest","checkPermissionsAndPerformAction is called"); PermissionUtils.checkPermissionsAndPerformAction(getActivity(), Manifest.permission.ACCESS_FINE_LOCATION, runnable, diff --git a/app/src/main/java/fr/free/nrw/commons/nearby/mvp/presenter/NearbyParentFragmentPresenter.java b/app/src/main/java/fr/free/nrw/commons/nearby/mvp/presenter/NearbyParentFragmentPresenter.java index 62f9cebab..60c6b019d 100644 --- a/app/src/main/java/fr/free/nrw/commons/nearby/mvp/presenter/NearbyParentFragmentPresenter.java +++ b/app/src/main/java/fr/free/nrw/commons/nearby/mvp/presenter/NearbyParentFragmentPresenter.java @@ -67,6 +67,7 @@ public class NearbyParentFragmentPresenter @Override public void onTabSelected() { Timber.d("Nearby tab selected"); + Log.d("denemeTest","Nearby tab selected"); onTabSelected = true; // The condition for initialize operations is both having views ready and tab is selected if (nearbyViewsAreReady) { @@ -81,6 +82,7 @@ public class NearbyParentFragmentPresenter @Override public void nearbyFragmentsAreReady() { Timber.d("Nearby fragments are ready to be used by presenter"); + Log.d("denemeTest","nearbyFragmentsAreReady"); nearbyViewsAreReady = true; // The condition for initialize operations is both having views ready and tab is selected if (onTabSelected) {