mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 21:03:54 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Refactor and add tests to LengthUtils (#2201)

Browse source
This commit is contained in:
Adam Jones 2018-12-21 12:23:53 +00:00 • committed by neslihanturan
parent f04503bb3e
commit d7e73c37e6
2 changed files with 138 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

100
app/src/test/kotlin/fr/free/nrw/commons/utils/LengthUtilsTest.kt
View file

@ -1,46 +1,120 @@
package fr.free.nrw.commons.utils
import fr.free.nrw.commons.location.LatLng
import fr.free.nrw.commons.utils.LengthUtils
import org.junit.Assert.assertEquals
import org.junit.Assert.assertNull
import org.junit.Test
class LengthUtilsTest {
// Test LengthUtils.formatDistanceBetween()
@Test
fun testZeroDistance() {
fun testFormattedDistanceBetweenSamePoints() {
val pointA = LatLng(0.0, 0.0, 0f)
val pointB = LatLng(0.0, 0.0, 0f)
assertDistanceBetween("0m", pointA, pointB)
assertFormattedDistanceBetween("0m", pointA, pointB)
}
@Test
fun testOneDegreeOnEquator() {
fun testFormattedOneDegreeOnEquator() {
val pointA = LatLng(0.0, 0.0, 0f)
val pointB = LatLng(0.0, 1.0, 0f)
assertDistanceBetween("111.2km", pointA, pointB)
assertFormattedDistanceBetween("111.2km", pointA, pointB)
}
@Test
fun testOneDegreeFortyFiveDegrees() {
fun testFormattedOneDegreeFortyFiveDegrees() {
val pointA = LatLng(45.0, 0.0, 0f)
val pointB = LatLng(45.0, 1.0, 0f)
assertDistanceBetween("78.6km", pointA, pointB)
assertFormattedDistanceBetween("78.6km", pointA, pointB)
}
@Test
fun testOneDegreeSouthPole() {
fun testFormattedOneDegreeSouthPole() {
val pointA = LatLng(-90.0, 0.0, 0f)
val pointB = LatLng(-90.0, 1.0, 0f)
assertDistanceBetween("0m", pointA, pointB)
assertFormattedDistanceBetween("0m", pointA, pointB)
}
@Test
fun testPoleToPole() {
fun testFormattedPoleToPole() {
val pointA = LatLng(90.0, 0.0, 0f)
val pointB = LatLng(-90.0, 0.0, 0f)
assertDistanceBetween("20,015.1km", pointA, pointB)
assertFormattedDistanceBetween("20,015.1km", pointA, pointB)
}
private fun assertDistanceBetween(expected: String, pointA: LatLng, pointB: LatLng) =
@Test
fun testFormattedNullToNull() {
assertNull(LengthUtils.formatDistanceBetween(null, null))
}
// Test LengthUtils.formatDistance()
@Test
fun testFormatDistance() {
assertFormattedDistance("100m", 100)
assertFormattedDistance("123m", 123)
assertFormattedDistance("450m", 450)
assertFormattedDistance("999m", 999)
assertFormattedDistance("1km", 1000)
assertFormattedDistance("1km", 1001)
assertFormattedDistance("1.1km", 1050)
assertFormattedDistance("1.2km", 1234)
assertFormattedDistance("123,456.8km", 123456789)
assertFormattedDistance("0m", 0)
}
@Test(expected = IllegalArgumentException::class)
fun testIllegalFormatDistance() {
LengthUtils.formatDistance(-1)
}
// Test LengthUtils.computeDistanceBetween()
@Test
fun testDistanceBetweenSamePoints() {
val pointA = LatLng(0.0, 0.0, 0f)
val pointB = LatLng(0.0, 0.0, 0f)
assertDistanceBetween(0.0, pointA, pointB)
}
@Test
fun testDistanceOneDegreeOnEquator() {
val pointA = LatLng(0.0, 0.0, 0f)
val pointB = LatLng(0.0, 1.0, 0f)
assertDistanceBetween(111195.08, pointA, pointB)
}
@Test
fun testDistanceOneDegreeFortyFiveDegrees() {
val pointA = LatLng(45.0, 0.0, 0f)
val pointB = LatLng(45.0, 1.0, 0f)
assertDistanceBetween(78626.30, pointA, pointB)
}
@Test
fun testDistanceOneDegreeSouthPole() {
val pointA = LatLng(-90.0, 0.0, 0f)
val pointB = LatLng(-90.0, 1.0, 0f)
assertDistanceBetween(0.0, pointA, pointB)
}
@Test
fun testDistancePoleToPole() {
val pointA = LatLng(90.0, 0.0, 0f)
val pointB = LatLng(-90.0, 0.0, 0f)
assertDistanceBetween(20015115.07, pointA, pointB)
}
// Test assertion helper functions
private fun assertFormattedDistanceBetween(expected: String, pointA: LatLng, pointB: LatLng) =
assertEquals(expected, LengthUtils.formatDistanceBetween(pointA, pointB))
}
private fun assertFormattedDistance(expected: String, distance: Int) =
assertEquals(expected, LengthUtils.formatDistance(distance))
private fun assertDistanceBetween(expected: Double, pointA: LatLng, pointB: LatLng) =
// Acceptable error: 1cm
assertEquals(expected, LengthUtils.computeDistanceBetween(pointA, pointB), 0.01)
}