mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-31 23:03:54 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat:Used Snackbar and timber instead of log and Toast

Browse source
This commit is contained in:
angrezichatterbox 2024-12-12 01:45:09 +05:30
parent baaa0d86c8
commit d7683f8ca6
2 changed files with 12 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

14
app/src/main/java/fr/free/nrw/commons/feedback/FeedbackDialog.kt
View file

@ -7,7 +7,7 @@ import android.text.Html
import android.text.Spanned import android.text.Spanned
import android.text.method.LinkMovementMethod import android.text.method.LinkMovementMethod
import android.view.WindowManager import android.view.WindowManager
import android.widget.Toast import com.google.android.material.snackbar.Snackbar
import fr.free.nrw.commons.R import fr.free.nrw.commons.R
import fr.free.nrw.commons.databinding.DialogFeedbackBinding import fr.free.nrw.commons.databinding.DialogFeedbackBinding
import fr.free.nrw.commons.feedback.model.Feedback import fr.free.nrw.commons.feedback.model.Feedback
@ -49,15 +49,21 @@ class FeedbackDialog(
} catch (e: Exception) { } catch (e: Exception) {
when (e) { when (e) {
is UnknownHostException -> { is UnknownHostException -> {
Toast.makeText(context, R.string.error_feedback, Toast.LENGTH_SHORT).show() Snackbar.make(findViewById(android.R.id.content),
R.string.error_feedback,
Snackbar.LENGTH_SHORT).show()
} }
is ConnectException -> { is ConnectException -> {
Toast.makeText(context, R.string.error_feedback, Toast.LENGTH_SHORT).show() Snackbar.make(findViewById(android.R.id.content),
R.string.error_feedback,
Snackbar.LENGTH_SHORT).show()
} }
else -> { else -> {
Toast.makeText(context, R.string.error_feedback, Toast.LENGTH_SHORT).show() Snackbar.make(findViewById(android.R.id.content),
R.string.error_feedback,
Snackbar.LENGTH_SHORT).show()
} }
} }
} }

3
app/src/main/java/fr/free/nrw/commons/navtab/MoreBottomSheetFragment.kt
View file

@ -35,6 +35,7 @@ import fr.free.nrw.commons.settings.SettingsActivity
import io.reactivex.Single import io.reactivex.Single
import io.reactivex.android.schedulers.AndroidSchedulers import io.reactivex.android.schedulers.AndroidSchedulers
import io.reactivex.schedulers.Schedulers import io.reactivex.schedulers.Schedulers
import timber.log.Timber
import javax.inject.Inject import javax.inject.Inject
import javax.inject.Named import javax.inject.Named
@ -190,7 +191,7 @@ class MoreBottomSheetFragment : BottomSheetDialogFragment() {
} }
Toast.makeText(requireContext(), getString(messageResId), Toast.LENGTH_SHORT).show() Toast.makeText(requireContext(), getString(messageResId), Toast.LENGTH_SHORT).show()
}, { error -> }, { error ->
error.printStackTrace() Timber.e(error)
Toast.makeText(requireContext(), R.string.error_feedback, Toast.LENGTH_SHORT).show() Toast.makeText(requireContext(), R.string.error_feedback, Toast.LENGTH_SHORT).show()
}) })
} }