From d72bd446fefcc61e46ae15beeba5acafbbad1733 Mon Sep 17 00:00:00 2001
From: Madhur Gupta <30932899+madhurgupta10@users.noreply.github.com>
Date: Wed, 20 Mar 2019 16:42:20 +0530
Subject: [PATCH] Added information dialog to Statistics #2599 (#2683)

---
 .../achievements/AchievementsActivity.java    | 18 ++++++++++
 .../main/res/layout/activity_achievements.xml | 33 +++++++++++++++++++
 app/src/main/res/values/strings.xml           |  3 ++
 3 files changed, 54 insertions(+)

diff --git a/app/src/main/java/fr/free/nrw/commons/achievements/AchievementsActivity.java b/app/src/main/java/fr/free/nrw/commons/achievements/AchievementsActivity.java
index 4caefd1c9..0d6e384b6 100644
--- a/app/src/main/java/fr/free/nrw/commons/achievements/AchievementsActivity.java
+++ b/app/src/main/java/fr/free/nrw/commons/achievements/AchievementsActivity.java
@@ -440,6 +440,24 @@ public class AchievementsActivity extends NavigationBaseActivity {
                 ,getResources().getString(R.string.images_used_explanation));
     }
 
+    @OnClick(R.id.images_nearby_info)
+    public void showImagesViaNearbyInfo(){
+        launchAlert(getResources().getString(R.string.statistics_wikidata_edits)
+                ,getResources().getString(R.string.images_via_nearby_explanation));
+    }
+
+    @OnClick(R.id.images_featured_info)
+    public void showFeaturedImagesInfo(){
+        launchAlert(getResources().getString(R.string.statistics_featured)
+                ,getResources().getString(R.string.images_featured_explanation));
+    }
+
+    @OnClick(R.id.thanks_received_info)
+    public void showThanksReceivedInfo(){
+        launchAlert(getResources().getString(R.string.statistics_thanks)
+                ,getResources().getString(R.string.thanks_received_explanation));
+    }
+
     /**
      * takes title and message as input to display alerts
      * @param title
diff --git a/app/src/main/res/layout/activity_achievements.xml b/app/src/main/res/layout/activity_achievements.xml
index 594e8b36f..5fc676ef1 100644
--- a/app/src/main/res/layout/activity_achievements.xml
+++ b/app/src/main/res/layout/activity_achievements.xml
@@ -310,6 +310,17 @@
                                 android:layout_marginRight="@dimen/activity_margin_horizontal"
                                 android:text="@string/statistics_wikidata_edits"  />
 
+                            <ImageView
+                                android:layout_width="12dp"
+                                android:layout_height="12dp"
+                                android:id="@+id/images_nearby_info"
+                                android:layout_marginTop="8dp"
+                                android:layout_marginRight="@dimen/activity_margin_horizontal"
+                                android:layout_marginEnd="@dimen/activity_margin_horizontal"
+                                android:layout_gravity="top"
+                                app:srcCompat="@drawable/ic_info_outline_blue_24dp"
+                                android:tint="?attr/icon" />
+
                         </LinearLayout>
 
 
@@ -367,6 +378,17 @@
                                 android:layout_marginRight="@dimen/activity_margin_horizontal"
                                 android:text="@string/statistics_featured"  />
 
+                            <ImageView
+                                android:layout_width="12dp"
+                                android:layout_height="12dp"
+                                android:id="@+id/images_featured_info"
+                                android:layout_marginTop="8dp"
+                                android:layout_marginRight="@dimen/activity_margin_horizontal"
+                                android:layout_marginEnd="@dimen/activity_margin_horizontal"
+                                android:layout_gravity="top"
+                                app:srcCompat="@drawable/ic_info_outline_blue_24dp"
+                                android:tint="?attr/icon" />
+
                         </LinearLayout>
 
                         <TextView
@@ -423,6 +445,17 @@
                                 android:layout_marginRight="@dimen/activity_margin_horizontal"
                                 android:text="@string/statistics_thanks"  />
 
+                            <ImageView
+                                android:layout_width="12dp"
+                                android:layout_height="12dp"
+                                android:id="@+id/thanks_received_info"
+                                android:layout_marginTop="8dp"
+                                android:layout_marginRight="@dimen/activity_margin_horizontal"
+                                android:layout_marginEnd="@dimen/activity_margin_horizontal"
+                                android:layout_gravity="top"
+                                app:srcCompat="@drawable/ic_info_outline_blue_24dp"
+                                android:tint="?attr/icon" />
+
                         </LinearLayout>
 
                         <TextView
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 889a4d546..d754da64e 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -476,4 +476,7 @@ Upload your first media by tapping on the add button.</string>
   <string name="image_chooser_title">Choose Images to upload</string>
 
   <string name="please_wait">Please wait…</string>
+  <string name="images_featured_explanation">Featured pictures are images from highly skilled photographers and illustrators that the Wikimedia Commons community has chosen as some of the highest quality on the site.</string>
+  <string name="images_via_nearby_explanation">Images Uploaded via Nearby places are the images which are uploaded by discovering places on the map.</string>
+  <string name="thanks_received_explanation" >This feature allows editors to send a Thank you notification to users who make useful edits – by using a small thank link on the history page or diff page.</string>
 </resources>