From d674e81ed7bdf35642232d45a2faaab7f79f0de9 Mon Sep 17 00:00:00 2001 From: Ujjwal Agrawal Date: Wed, 28 Mar 2018 02:39:51 +0530 Subject: [PATCH] Removed nearby Test --- .../commons/nearby/NearbyActivityTest.java | 93 ------------- .../nearby/NearbyAdapterFactoryTest.java | 129 ------------------ 2 files changed, 222 deletions(-) delete mode 100644 app/src/test/java/fr/free/nrw/commons/nearby/NearbyActivityTest.java delete mode 100644 app/src/test/java/fr/free/nrw/commons/nearby/NearbyAdapterFactoryTest.java diff --git a/app/src/test/java/fr/free/nrw/commons/nearby/NearbyActivityTest.java b/app/src/test/java/fr/free/nrw/commons/nearby/NearbyActivityTest.java deleted file mode 100644 index 55ab0b203..000000000 --- a/app/src/test/java/fr/free/nrw/commons/nearby/NearbyActivityTest.java +++ /dev/null @@ -1,93 +0,0 @@ -package fr.free.nrw.commons.nearby; - -import android.content.Context; -import android.support.v4.app.Fragment; -import android.support.v7.widget.RecyclerView; -import android.view.MenuItem; - -import org.junit.Before; -import org.junit.Test; -import org.junit.runner.RunWith; -import org.mockito.InjectMocks; -import org.mockito.Mock; -import org.mockito.MockitoAnnotations; -import org.robolectric.Robolectric; -import org.robolectric.RobolectricTestRunner; -import org.robolectric.annotation.Config; - -import edu.emory.mathcs.backport.java.util.Collections; -import fr.free.nrw.commons.BuildConfig; -import fr.free.nrw.commons.R; -import fr.free.nrw.commons.TestCommonsApplication; -import fr.free.nrw.commons.location.LatLng; -import fr.free.nrw.commons.location.LocationServiceManager; -import io.reactivex.android.plugins.RxAndroidPlugins; -import io.reactivex.plugins.RxJavaPlugins; -import io.reactivex.schedulers.Schedulers; - -import static org.junit.Assert.assertNotNull; -import static org.junit.Assert.assertNull; -import static org.mockito.Matchers.any; -import static org.mockito.Mockito.mock; -import static org.mockito.Mockito.when; -import static org.robolectric.Shadows.shadowOf; - -@RunWith(RobolectricTestRunner.class) -@Config(constants = BuildConfig.class, sdk = 21, application = TestCommonsApplication.class) -public class NearbyActivityTest { - - private static final LatLng ST_LOUIS_MO_LAT_LNG - = new LatLng(38.627003, -90.199402, 0); - private static final Place AIRPORT = new Place( - "name", Place.Label.AIRPORT, - "desc", null, - new LatLng(38.6270, -90.1994, 0), - null, null); - - @Mock - private LocationServiceManager locationManager; - - @Mock - private NearbyController nearbyController; - - @InjectMocks - private NearbyActivity nearbyActivity; - - @Before - public void setUp() throws Exception { - // ensure waiting all threads to complete - RxJavaPlugins.setIoSchedulerHandler( - scheduler -> Schedulers.trampoline()); - RxJavaPlugins.setComputationSchedulerHandler( - scheduler -> Schedulers.trampoline()); - RxJavaPlugins.setNewThreadSchedulerHandler( - scheduler -> Schedulers.trampoline()); - RxAndroidPlugins.setInitMainThreadSchedulerHandler( - scheduler -> Schedulers.trampoline()); - - nearbyActivity = Robolectric.setupActivity(NearbyActivity.class); - - // replace methods and fields with mocks - MockitoAnnotations.initMocks(this); - when(locationManager.getLastLocation()).thenReturn(ST_LOUIS_MO_LAT_LNG); - when(locationManager.isProviderEnabled()).thenReturn(true); - when(nearbyController.loadAttractionsFromLocation(any(LatLng.class))) - .thenReturn(mock(NearbyController.NearbyPlacesInfo.class)); - } - - @Test - public void pressRefreshAndShowList() { -// MenuItem refresh = shadowOf(nearbyActivity).getOptionsMenu().findItem(R.id.action_refresh); -// nearbyActivity.onOptionsItemSelected(refresh); -// -// Fragment nearbyListFragment = nearbyActivity.getSupportFragmentManager() -// .findFragmentByTag(NearbyListFragment.class.getSimpleName()); -// assertNotNull(nearbyListFragment); -// -// // one element (AIRPORT) exists in the list -// RecyclerView view = nearbyListFragment.getView().findViewById(R.id.listView); -// assertNotNull(view.findViewHolderForAdapterPosition(0)); -// assertNull(view.findViewHolderForAdapterPosition(1)); - } - -} \ No newline at end of file diff --git a/app/src/test/java/fr/free/nrw/commons/nearby/NearbyAdapterFactoryTest.java b/app/src/test/java/fr/free/nrw/commons/nearby/NearbyAdapterFactoryTest.java deleted file mode 100644 index d47247897..000000000 --- a/app/src/test/java/fr/free/nrw/commons/nearby/NearbyAdapterFactoryTest.java +++ /dev/null @@ -1,129 +0,0 @@ -package fr.free.nrw.commons.nearby; - -import android.support.annotation.NonNull; -import android.widget.FrameLayout; -import android.widget.ImageView; -import android.widget.TextView; - -import com.pedrogomez.renderers.RVRendererAdapter; -import com.pedrogomez.renderers.RendererViewHolder; - -import org.junit.Test; -import org.junit.runner.RunWith; -import org.robolectric.RobolectricTestRunner; -import org.robolectric.RuntimeEnvironment; -import org.robolectric.Shadows; -import org.robolectric.annotation.Config; -import org.robolectric.shadows.ShadowDrawable; - -import java.util.Collections; - -import fr.free.nrw.commons.BuildConfig; -import fr.free.nrw.commons.R; -import fr.free.nrw.commons.TestCommonsApplication; -import fr.free.nrw.commons.location.LatLng; - -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertNotNull; - -@RunWith(RobolectricTestRunner.class) -@Config(constants = BuildConfig.class, sdk = 21, application = TestCommonsApplication.class) -public class NearbyAdapterFactoryTest { - - private static final Place PLACE = new Place("name", Place.Label.AIRPORT, - "desc", null, new LatLng(38.6270, -90.1994, 0), null, null); - - private static final Place UNKNOWN_PLACE = new Place("name", Place.Label.UNKNOWN, - "desc", null, new LatLng(39.7392, -104.9903, 0), null, null); - - private Place clickedPlace; - - @Test - public void factoryHandlesNullListAndNullListener() { - NearbyAdapterFactory testObject = new NearbyAdapterFactory(); - RVRendererAdapter result = testObject.create(null); - assertNotNull(result); - assertEquals(0, result.getItemCount()); - } - - @Test - public void factoryHandlesEmptyListAndNullListener() { - NearbyAdapterFactory testObject = new NearbyAdapterFactory(); - RVRendererAdapter result = testObject.create(Collections.emptyList()); - assertNotNull(result); - assertEquals(0, result.getItemCount()); - } - - @Test - public void factoryHandlesNonEmptyListAndNullListener() { - NearbyAdapterFactory testObject = new NearbyAdapterFactory(); - RVRendererAdapter result = testObject.create(Collections.singletonList(PLACE)); - assertNotNull(result); - assertEquals(1, result.getItemCount()); - assertEquals(PLACE, result.getItem(0)); - } - - @Test - public void rendererCorrectlyBound() { - NearbyAdapterFactory testObject = new NearbyAdapterFactory(); - RVRendererAdapter result = testObject.create(Collections.singletonList(PLACE)); - - RendererViewHolder viewHolder = renderComponent(result); - - // test that the values we gave are actually rendered - assertNotNull(viewHolder.itemView.findViewById(R.id.tvName)); - assertEquals(PLACE.name, - ((TextView) viewHolder.itemView.findViewById(R.id.tvName)).getText().toString()); - - assertNotNull(viewHolder.itemView.findViewById(R.id.tvDesc)); - assertEquals(PLACE.getLongDescription(), - ((TextView) viewHolder.itemView.findViewById(R.id.tvDesc)).getText().toString()); - - assertNotNull(viewHolder.itemView.findViewById(R.id.distance)); - assertEquals("", - ((TextView) viewHolder.itemView.findViewById(R.id.distance)).getText().toString()); - - assertNotNull(viewHolder.itemView.findViewById(R.id.icon)); - ImageView imageView = (ImageView) viewHolder.itemView.findViewById(R.id.icon); - ShadowDrawable shadow = Shadows.shadowOf(imageView.getDrawable()); - assertEquals(R.drawable.round_icon_airport, shadow.getCreatedFromResId()); - } - - @Test - public void rendererCorrectlyBoundForUnknownPlace() { - NearbyAdapterFactory testObject = new NearbyAdapterFactory(); - RVRendererAdapter result = testObject.create(Collections.singletonList(UNKNOWN_PLACE)); - - RendererViewHolder viewHolder = renderComponent(result); - - assertNotNull(viewHolder.itemView.findViewById(R.id.tvDesc)); - assertEquals(RuntimeEnvironment.application.getString(R.string.no_description_found), - ((TextView) viewHolder.itemView.findViewById(R.id.tvDesc)).getText().toString()); - - assertNotNull(viewHolder.itemView.findViewById(R.id.icon)); - ImageView imageView = (ImageView) viewHolder.itemView.findViewById(R.id.icon); - ShadowDrawable shadow = Shadows.shadowOf(imageView.getDrawable()); - assertEquals(R.drawable.round_icon_unknown, shadow.getCreatedFromResId()); - } - - @Test - public void clickView() { - NearbyAdapterFactory testObject = new NearbyAdapterFactory(); - RVRendererAdapter result = testObject.create(Collections.singletonList(PLACE)); - RendererViewHolder viewHolder = renderComponent(result); - - viewHolder.itemView.performClick(); - - assertEquals(PLACE, clickedPlace); - } - - @NonNull - private RendererViewHolder renderComponent(RVRendererAdapter result) { - FrameLayout viewGroup = new FrameLayout(RuntimeEnvironment.application); - int itemViewType = result.getItemViewType(0); - RendererViewHolder viewHolder = result.onCreateViewHolder(viewGroup, itemViewType); - assertNotNull(viewHolder); - result.bindViewHolder(viewHolder, 0); - return viewHolder; - } -} \ No newline at end of file