mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-26 12:23:58 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Convert MediaDetailProvider to kotlin

Browse source
This commit is contained in:
Paul Hawke 2025-07-11 14:42:32 -05:00
parent 4564d5570a
commit d59d8bcbd9
8 changed files with 24 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

15
app/src/main/java/fr/free/nrw/commons/media/MediaDetailProvider.java
View file

@ -1,15 +0,0 @@
package fr.free.nrw.commons.media;
import fr.free.nrw.commons.Media;
public interface MediaDetailProvider {
Media getMediaAtPosition(int i);
int getTotalMediaCount();
Integer getContributionStateAt(int position);
// Reload media detail fragment once media is nominated
void refreshNominatedMedia(int index);
}

14
app/src/main/java/fr/free/nrw/commons/media/MediaDetailProvider.kt Normal file
View file

@ -0,0 +1,14 @@
package fr.free.nrw.commons.media
import fr.free.nrw.commons.Media
interface MediaDetailProvider {
fun getMediaAtPosition(i: Int): Media?
fun getTotalMediaCount(): Int
fun getContributionStateAt(position: Int): Int?
// Reload media detail fragment once media is nominated
fun refreshNominatedMedia(index: Int)
}

4
app/src/test/kotlin/fr/free/nrw/commons/bookmarks/BookmarkListRootFragmentUnitTest.kt
View file

@ -235,7 +235,7 @@ class BookmarkListRootFragmentUnitTest {
@Throws(Exception::class)
fun testGetTotalMediaCountCaseNull() {
whenever(bookmarksPagerAdapter.mediaAdapter).thenReturn(null)
Assert.assertEquals(fragment.totalMediaCount, 0)
Assert.assertEquals(fragment.getTotalMediaCount(), 0)
}
@Test
@ -244,7 +244,7 @@ class BookmarkListRootFragmentUnitTest {
val listAdapter = mock(ListAdapter::class.java)
whenever(bookmarksPagerAdapter.mediaAdapter).thenReturn(listAdapter)
whenever(listAdapter.count).thenReturn(1)
Assert.assertEquals(fragment.totalMediaCount, 1)
Assert.assertEquals(fragment.getTotalMediaCount(), 1)
}
@Test

2
app/src/test/kotlin/fr/free/nrw/commons/category/CategoryDetailsActivityUnitTests.kt
View file

@ -76,7 +76,7 @@ class CategoryDetailsActivityUnitTests {
@Test
@Throws(Exception::class)
fun testGetTotalMediaCount() {
activity.totalMediaCount
activity.getTotalMediaCount()
}
@Test

2
app/src/test/kotlin/fr/free/nrw/commons/contributions/ContributionsFragmentUnitTests.kt
View file

@ -334,7 +334,7 @@ class ContributionsFragmentUnitTests {
@Throws(Exception::class)
fun testGetTotalMediaCount() {
Shadows.shadowOf(Looper.getMainLooper()).idle()
fragment.totalMediaCount
fragment.getTotalMediaCount()
}
@Test

6
app/src/test/kotlin/fr/free/nrw/commons/explore/ExploreListRootFragmentUnitTest.kt
View file

@ -189,8 +189,8 @@ class ExploreListRootFragmentUnitTest {
@Test
@Throws(Exception::class)
fun testGetTotalMediaCount() {
`when`(listFragment.totalMediaCount).thenReturn(1)
Assert.assertEquals(fragment.totalMediaCount, 1)
`when`(listFragment.getTotalMediaCount()).thenReturn(1)
Assert.assertEquals(fragment.getTotalMediaCount(), 1)
}
@Test
@ -199,7 +199,7 @@ class ExploreListRootFragmentUnitTest {
val field: Field = ExploreListRootFragment::class.java.getDeclaredField("listFragment")
field.isAccessible = true
field.set(fragment, null)
Assert.assertEquals(fragment.totalMediaCount, 0)
Assert.assertEquals(fragment.getTotalMediaCount(), 0)
}
@Test

2
app/src/test/kotlin/fr/free/nrw/commons/explore/depictions/WikidataItemDetailsActivityUnitTests.kt
View file

@ -108,7 +108,7 @@ class WikidataItemDetailsActivityUnitTests {
@Test
@Throws(Exception::class)
fun testGetTotalMediaCount() {
activity.totalMediaCount
activity.getTotalMediaCount()
}
@Test

4
app/src/test/kotlin/fr/free/nrw/commons/explore/search/SearchActivityUnitTests.kt
View file

@ -160,8 +160,8 @@ class SearchActivityUnitTests {
fun testGetTotalMediaCount() {
val num = 1
Whitebox.setInternalState(activity, "searchMediaFragment", searchMediaFragment)
`when`(searchMediaFragment.totalMediaCount).thenReturn(num)
assertEquals(activity.totalMediaCount, num)
`when`(searchMediaFragment.getTotalMediaCount()).thenReturn(num)
assertEquals(activity.getTotalMediaCount(), num)
}
@Test