From d1af26c8a8c8da9f6a0eaa5718c45b6c20bf1873 Mon Sep 17 00:00:00 2001 From: Manuel Cota <108767897+MaAnCoSa@users.noreply.github.com> Date: Thu, 23 Mar 2023 23:58:59 -0700 Subject: [PATCH] Fix: user reset for Thanks screen (#5183) Removed previous if statement. If the app is rotated, the Thanks message will disappear, but the username gets a reset for each new image reviewed. --- .../fr/free/nrw/commons/review/ReviewImageFragment.java | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/app/src/main/java/fr/free/nrw/commons/review/ReviewImageFragment.java b/app/src/main/java/fr/free/nrw/commons/review/ReviewImageFragment.java index 7391d6b2d..3222afe40 100644 --- a/app/src/main/java/fr/free/nrw/commons/review/ReviewImageFragment.java +++ b/app/src/main/java/fr/free/nrw/commons/review/ReviewImageFragment.java @@ -127,13 +127,8 @@ public class ReviewImageFragment extends CommonsDaggerSupportFragment { enableButtons(); question = getString(R.string.review_thanks); - // Get existing user name if it is already saved using savedInstanceState else get from reviewController - if (savedInstanceState == null) { - if (getReviewActivity().reviewController.firstRevision != null) { - user = getReviewActivity().reviewController.firstRevision.getUser(); - } - } else { - user = savedInstanceState.getString(SAVED_USER); + if (getReviewActivity().reviewController.firstRevision != null) { + user = getReviewActivity().reviewController.firstRevision.getUser(); } //if the user is null because of whatsoever reason, review will not be sent anyways