From ceab7f4c1be9b93ebf10613f3023a576da273e86 Mon Sep 17 00:00:00 2001 From: neslihanturan Date: Mon, 27 May 2019 13:37:47 +0300 Subject: [PATCH] Remove location listener implementation from view, handle them in presenter instead. And add timber debug notes and required method calls --- .../mvp/fragments/NearbyParentFragment.java | 18 +----------------- .../NearbyParentFragmentPresenter.java | 10 ++++++---- 2 files changed, 7 insertions(+), 21 deletions(-) diff --git a/app/src/main/java/fr/free/nrw/commons/nearby/mvp/fragments/NearbyParentFragment.java b/app/src/main/java/fr/free/nrw/commons/nearby/mvp/fragments/NearbyParentFragment.java index a17c8078c..28d6d99d3 100644 --- a/app/src/main/java/fr/free/nrw/commons/nearby/mvp/fragments/NearbyParentFragment.java +++ b/app/src/main/java/fr/free/nrw/commons/nearby/mvp/fragments/NearbyParentFragment.java @@ -51,8 +51,7 @@ import static fr.free.nrw.commons.location.LocationServiceManager.LocationChange * two nearby element fragments as NearbyMapFragment and NearbyListFragment */ public class NearbyParentFragment extends CommonsDaggerSupportFragment - implements LocationUpdateListener, - WikidataEditListener.WikidataP18EditListener, + implements WikidataEditListener.WikidataP18EditListener, NearbyParentFragmentContract.View { @BindView(R.id.progressBar) @@ -204,21 +203,6 @@ public class NearbyParentFragment extends CommonsDaggerSupportFragment return (NearbyListFragment) getChildFragmentManager().findFragmentByTag(TAG_RETAINED_LIST_FRAGMENT); } - @Override - public void onLocationChangedSignificantly(LatLng latLng) { - Log.d("deneme1","location changed significantly"); - } - - @Override - public void onLocationChangedSlightly(LatLng latLng) { - Log.d("deneme1","location changed significantly"); - } - - @Override - public void onLocationChangedMedium(LatLng latLng) { - Log.d("deneme1","location changed significantly"); - } - @Override public void onWikidataEditSuccessful() { diff --git a/app/src/main/java/fr/free/nrw/commons/nearby/mvp/presenter/NearbyParentFragmentPresenter.java b/app/src/main/java/fr/free/nrw/commons/nearby/mvp/presenter/NearbyParentFragmentPresenter.java index cfde85fa0..e4d403a6c 100644 --- a/app/src/main/java/fr/free/nrw/commons/nearby/mvp/presenter/NearbyParentFragmentPresenter.java +++ b/app/src/main/java/fr/free/nrw/commons/nearby/mvp/presenter/NearbyParentFragmentPresenter.java @@ -17,6 +17,7 @@ import io.reactivex.schedulers.Schedulers; import timber.log.Timber; import static fr.free.nrw.commons.location.LocationServiceManager.LocationChangeType.LOCATION_SIGNIFICANTLY_CHANGED; +import static fr.free.nrw.commons.location.LocationServiceManager.LocationChangeType.LOCATION_SLIGHTLY_CHANGED; import static fr.free.nrw.commons.location.LocationServiceManager.LocationChangeType.MAP_UPDATED; public class NearbyParentFragmentPresenter @@ -181,19 +182,20 @@ public class NearbyParentFragmentPresenter @Override public void onLocationChangedSignificantly(LatLng latLng) { - Log.d("deneme1","onLocationChangedSignificantly"); + Timber.d("Location significantly changed"); + updateMapAndList(LOCATION_SIGNIFICANTLY_CHANGED); } @Override public void onLocationChangedSlightly(LatLng latLng) { - Log.d("deneme1","onLocationChangedSlightly"); - + Timber.d("Location significantly changed"); + updateMapAndList(LOCATION_SLIGHTLY_CHANGED); } @Override public void onLocationChangedMedium(LatLng latLng) { - Log.d("deneme1","onLocationChangedMedium"); + Timber.d("Location changed medium"); } }