mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-26 20:33:53 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Hide nearby card view when Media Details is visible

Browse source
This commit is contained in:
neslihanturan 2018-09-24 13:42:28 +03:00
parent 8861e402e9
commit cd52beed5a
3 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/src/main/java/fr/free/nrw/commons/contributions/ContributionsActivity.java
View file

@ -193,6 +193,8 @@ public class ContributionsActivity extends AuthenticatedActivity implements Frag
contributionsFragment.getChildFragmentManager().popBackStack();
// Tabs were invisible when Media Details Fragment is active, make them visible again on Contrib List Fragment active
showTabs();
// Nearby Notification Card View was invisible when Media Details Fragment is active, make it visible again on Contrib List Fragment active
contributionsFragment.nearbyNoificationCardView.setVisibility(View.VISIBLE);
// Make number of uploads visible when Contributions List is visible
// TODO Neslihan: ContributionListViewUtils.setIndicatorVisibility(contributionsFragment.numberOfUploads, contributionsFragment.numberOfUploadsProgressBar, true, false);
// TODO Neslihan: ContributionListViewUtils.setIndicatorVisibility(contributionsFragment.notificationsCardView, contributionsFragment.notificationsCardViewProgressBar, true, false);

5
app/src/main/java/fr/free/nrw/commons/contributions/ContributionsFragment.java
View file

@ -170,6 +170,9 @@ public class ContributionsFragment
public void setContributionsListFragment() {
// show tabs on contribution list is visible
((ContributionsActivity)getActivity()).showTabs();
// show nearby card view on contributions list is visible
nearbyNoificationCardView.setVisibility(View.GONE);
// Create if null
if (getContributionsListFragment() == null) {
@ -190,6 +193,8 @@ public class ContributionsFragment
public void setMediaDetailPagerFragment() {
// hide tabs on media detail view is visible
((ContributionsActivity)getActivity()).hideTabs();
// hide nearby card view on media detail is visible
nearbyNoificationCardView.setVisibility(View.GONE);
// Create if null
if (getMediaDetailPagerFragment() == null) {

2
app/src/main/res/values/strings.xml
View file

@ -355,7 +355,7 @@
<string name="contributions_fragment">Contributions</string>
<string name="nearby_fragment">Nearby</string>
<string name="notifictions">Notifications</string>
<string name="notifications">Notifications</string>
<string name="display_nearby_notification">Display nearby notification</string>
<string name="display_nearby_notification_summary">Display closest wikidata item needs an image, above contribution list</string>