From cb41668cc58924a58e0dd7700d64ed1651ffda79 Mon Sep 17 00:00:00 2001 From: Akshay Komar Date: Fri, 17 Jan 2025 19:38:37 +0530 Subject: [PATCH] **Refactor: Convert `minimumThresholdForSwipe` to a compile-time constant** --- .../java/fr/free/nrw/commons/utils/SwipableCardView.kt | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/fr/free/nrw/commons/utils/SwipableCardView.kt b/app/src/main/java/fr/free/nrw/commons/utils/SwipableCardView.kt index def94c38a..bde575386 100644 --- a/app/src/main/java/fr/free/nrw/commons/utils/SwipableCardView.kt +++ b/app/src/main/java/fr/free/nrw/commons/utils/SwipableCardView.kt @@ -21,9 +21,14 @@ abstract class SwipableCardView @JvmOverloads constructor( defStyleAttr: Int = 0 ) : CardView(context, attrs, defStyleAttr) { + + companion object{ + const val MINIMUM_THRESHOLD_FOR_SWIPE = 100f + } + private var x1 = 0f private var x2 = 0f - private val minimumThresholdForSwipe = 100f + init { interceptOnTouchListener() @@ -45,7 +50,7 @@ abstract class SwipableCardView @JvmOverloads constructor( isSwipe = deltaX != 0f } } - if (isSwipe && pixelToDp(abs(deltaX)) > minimumThresholdForSwipe) { + if (isSwipe && pixelToDp(abs(deltaX)) > MINIMUM_THRESHOLD_FOR_SWIPE) { onSwipe(v) return@setOnTouchListener true }