From caad8644a330aa09ac7a7eb2cc8e006642fdb453 Mon Sep 17 00:00:00 2001 From: Devarsh Mavani Date: Sun, 13 Mar 2022 06:11:45 +0530 Subject: [PATCH] Unit tests failing (#4889) * tests * fixed tests --- .../leaderboard/LeaderboardFragmentUnitTests.kt | 17 ++++++++++++++++- .../AchievementsFragmentUnitTests.kt | 12 +++++++++++- 2 files changed, 27 insertions(+), 2 deletions(-) diff --git a/app/src/test/kotlin/fr/free/nrw/commons/leaderboard/LeaderboardFragmentUnitTests.kt b/app/src/test/kotlin/fr/free/nrw/commons/leaderboard/LeaderboardFragmentUnitTests.kt index 1adf5b7d0..3e9679db4 100644 --- a/app/src/test/kotlin/fr/free/nrw/commons/leaderboard/LeaderboardFragmentUnitTests.kt +++ b/app/src/test/kotlin/fr/free/nrw/commons/leaderboard/LeaderboardFragmentUnitTests.kt @@ -2,6 +2,7 @@ package fr.free.nrw.commons.leaderboard import android.accounts.Account import android.content.Context +import android.os.Looper.getMainLooper import android.view.LayoutInflater import android.view.View import android.view.ViewGroup @@ -26,11 +27,14 @@ import org.junit.Test import org.junit.runner.RunWith import org.mockito.Mock import org.mockito.Mockito.`when` +import org.mockito.Mockito.doReturn import org.mockito.MockitoAnnotations import org.powermock.reflect.Whitebox import org.robolectric.Robolectric import org.robolectric.RobolectricTestRunner import org.robolectric.RuntimeEnvironment +import org.robolectric.Shadows +import org.robolectric.Shadows.shadowOf import org.robolectric.annotation.Config import org.robolectric.annotation.LooperMode import org.robolectric.shadows.ShadowToast @@ -222,6 +226,7 @@ class LeaderboardFragmentUnitTests { @Test @Throws(Exception::class) fun testMenuVisibilityOverrideVisibleWithContext() { + shadowOf(getMainLooper()).idle() `when`(parentView.context).thenReturn(context) val method: Method = LeaderboardFragment::class.java.getDeclaredMethod( "setMenuVisibility", @@ -229,7 +234,17 @@ class LeaderboardFragmentUnitTests { ) method.isAccessible = true method.invoke(fragment, true) - Assert.assertEquals(ShadowToast.getTextOfLatestToast().toString(), context.getString(R.string.leaderboard_unavailable_beta)) + if(isBetaFlavour) { + Assert.assertEquals( + ShadowToast.getTextOfLatestToast().toString(), + context.getString(R.string.leaderboard_unavailable_beta) + ) + } else { + Assert.assertNull( + ShadowToast.getTextOfLatestToast() + ) + } + } } \ No newline at end of file diff --git a/app/src/test/kotlin/fr/free/nrw/commons/profile/achievements/AchievementsFragmentUnitTests.kt b/app/src/test/kotlin/fr/free/nrw/commons/profile/achievements/AchievementsFragmentUnitTests.kt index 3e6b0f1cf..5ee20619f 100644 --- a/app/src/test/kotlin/fr/free/nrw/commons/profile/achievements/AchievementsFragmentUnitTests.kt +++ b/app/src/test/kotlin/fr/free/nrw/commons/profile/achievements/AchievementsFragmentUnitTests.kt @@ -17,6 +17,7 @@ import fr.free.nrw.commons.TestAppAdapter import fr.free.nrw.commons.TestCommonsApplication import fr.free.nrw.commons.auth.SessionManager import fr.free.nrw.commons.profile.ProfileActivity +import fr.free.nrw.commons.utils.ConfigUtils import org.junit.Assert import org.junit.Before import org.junit.Test @@ -372,7 +373,16 @@ class AchievementsFragmentUnitTests { ) method.isAccessible = true method.invoke(fragment, true) - Assert.assertEquals(ShadowToast.getTextOfLatestToast().toString(), context.getString(R.string.achievements_unavailable_beta)) + if(ConfigUtils.isBetaFlavour) { + Assert.assertEquals( + ShadowToast.getTextOfLatestToast().toString(), + context.getString(R.string.achievements_unavailable_beta) + ) + } else { + Assert.assertNull( + ShadowToast.getTextOfLatestToast() + ) + } } } \ No newline at end of file