Add selection count indicator in top bar and refactor

This commit is contained in:
Rohit Verma 2024-10-13 14:07:02 +05:30
parent 1a86883ec0
commit ca30bf18bf
2 changed files with 56 additions and 32 deletions

View file

@ -2,8 +2,12 @@ package fr.free.nrw.commons.customselector.ui.components
import androidx.compose.foundation.layout.Column import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.fillMaxSize import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.shape.CircleShape
import androidx.compose.material.icons.Icons import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.automirrored.rounded.KeyboardArrowLeft import androidx.compose.material.icons.automirrored.rounded.KeyboardArrowLeft
import androidx.compose.material3.CardDefaults
import androidx.compose.material3.ElevatedCard
import androidx.compose.material3.ExperimentalMaterial3Api import androidx.compose.material3.ExperimentalMaterial3Api
import androidx.compose.material3.Icon import androidx.compose.material3.Icon
import androidx.compose.material3.IconButton import androidx.compose.material3.IconButton
@ -14,6 +18,8 @@ import androidx.compose.material3.TopAppBar
import androidx.compose.runtime.Composable import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier import androidx.compose.ui.Modifier
import androidx.compose.ui.res.painterResource import androidx.compose.ui.res.painterResource
import androidx.compose.ui.semantics.contentDescription
import androidx.compose.ui.semantics.semantics
import androidx.compose.ui.text.style.TextOverflow import androidx.compose.ui.text.style.TextOverflow
import androidx.compose.ui.tooling.preview.PreviewLightDark import androidx.compose.ui.tooling.preview.PreviewLightDark
import androidx.compose.ui.unit.dp import androidx.compose.ui.unit.dp
@ -28,7 +34,9 @@ fun CustomSelectorTopBar(
onNavigateBack: ()-> Unit, onNavigateBack: ()-> Unit,
modifier: Modifier = Modifier, modifier: Modifier = Modifier,
secondaryText: String? = null, secondaryText: String? = null,
selectionCount: Int = 0,
showNavigationIcon: Boolean = true, showNavigationIcon: Boolean = true,
showSelectionCount: Boolean = false,
showAlertIcon: Boolean = false, showAlertIcon: Boolean = false,
onAlertAction: ()-> Unit = { }, onAlertAction: ()-> Unit = { },
) { ) {
@ -38,7 +46,6 @@ fun CustomSelectorTopBar(
Text( Text(
text = primaryText, text = primaryText,
style = MaterialTheme.typography.titleMedium.copy(fontSize = 18.sp), style = MaterialTheme.typography.titleMedium.copy(fontSize = 18.sp),
color = MaterialTheme.colorScheme.primary,
maxLines = 1, maxLines = 1,
overflow = TextOverflow.Ellipsis overflow = TextOverflow.Ellipsis
) )
@ -73,6 +80,23 @@ fun CustomSelectorTopBar(
) )
} }
} }
if(showSelectionCount) {
ElevatedCard(
colors = CardDefaults.elevatedCardColors(
containerColor = MaterialTheme.colorScheme.primary
),
shape = CircleShape,
modifier = Modifier.semantics { contentDescription = "$selectionCount Selected" }
.padding(end = 8.dp)
) {
Text(
text = "$selectionCount",
modifier = Modifier.padding(horizontal = 16.dp, vertical = 8.dp),
style = MaterialTheme.typography.labelMedium
)
}
}
} }
) )
} }
@ -86,7 +110,8 @@ private fun CustomSelectorTopBarPreview() {
primaryText = "My Folder", primaryText = "My Folder",
secondaryText = "10 images", secondaryText = "10 images",
onNavigateBack = { }, onNavigateBack = { },
showAlertIcon = true showAlertIcon = true,
selectionCount = 1
) )
} }
} }

View file

@ -21,11 +21,9 @@ import fr.free.nrw.commons.ui.theme.CommonsTheme
@Composable @Composable
fun PartialStorageAccessDialog( fun PartialStorageAccessDialog(
isVisible: Boolean, onManageAction: () -> Unit,
onManage: ()-> Unit,
modifier: Modifier = Modifier modifier: Modifier = Modifier
) { ) {
if(isVisible) {
Card( Card(
modifier = modifier, modifier = modifier,
colors = CardDefaults.cardColors( colors = CardDefaults.cardColors(
@ -46,7 +44,7 @@ fun PartialStorageAccessDialog(
modifier = Modifier.weight(1f) modifier = Modifier.weight(1f)
) )
Button( Button(
onClick = onManage, onClick = onManageAction,
shape = RoundedCornerShape(8.dp), shape = RoundedCornerShape(8.dp),
contentPadding = PaddingValues(horizontal = 16.dp) contentPadding = PaddingValues(horizontal = 16.dp)
) { ) {
@ -55,14 +53,15 @@ fun PartialStorageAccessDialog(
} }
} }
} }
}
@PreviewLightDark @PreviewLightDark
@Composable @Composable
fun PartialStorageAccessIndicatorPreview() { fun PartialStorageAccessIndicatorPreview() {
CommonsTheme { CommonsTheme {
Surface { Surface {
PartialStorageAccessDialog(isVisible = true, onManage = {}, modifier = Modifier PartialStorageAccessDialog(
onManageAction = {},
modifier = Modifier
.padding(8.dp) .padding(8.dp)
.fillMaxWidth() .fillMaxWidth()
) )