From c959321ab08a8fdff6994d198053090a62b255b6 Mon Sep 17 00:00:00 2001 From: Josephine Lim Date: Wed, 2 May 2018 20:17:32 +1000 Subject: [PATCH 01/11] Update issue_template.md It feels like the template for reporting bugs is a bit redundant - we have summary, steps to reproduce, observed behaviour AND expected behaviour, which all are very similar. I think that by paring it down to the essentials, people will be less likely to skip steps. --- ISSUE_TEMPLATE.md | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/ISSUE_TEMPLATE.md b/ISSUE_TEMPLATE.md index 691562b04..ce33f1a18 100644 --- a/ISSUE_TEMPLATE.md +++ b/ISSUE_TEMPLATE.md @@ -1,9 +1,9 @@ -_Before creating an issue, please search the existing issues to see if a similar one has already been created. You can search issues by specific labels (e.g. `label:nearby `) or just by typing keywords into the search filter._ - **Summary:** Summarize your issue in one sentence (what goes wrong, what did you expect to happen) +_Before creating an issue, please search the existing issues to see if a similar one has already been created. You can search issues by specific labels (e.g. `label:nearby `) or just by typing keywords into the search filter._ + **Steps to reproduce:** How can we reproduce the issue? @@ -12,14 +12,6 @@ How can we reproduce the issue? Add logcat files here (if possible). -**Expected behavior:** - -What did you expect the App to do? - -**Observed behavior:** - -What did you see instead? Describe your issue in detail here. - **Device and Android version:** What make and model device (e.g., Samsung J7) did you encounter this on? What Android @@ -28,7 +20,7 @@ version (e.g., Android 4.0 Ice Cream Sandwich or Android 6.0 Marshmallow) are yo **Commons app version:** -You can find this information by going to the navigation drawer in the app and tapping 'About' +You can find this information by going to the navigation drawer in the app and tapping 'About'. If you are building from our codebase instead of downloading the app, please also mention the branch and build variant (e.g. master and prodDebug). **Screen-shots:** From da28d4f945f0d5dca2f1e68b454f5414804aaee0 Mon Sep 17 00:00:00 2001 From: Josephine Lim Date: Mon, 11 Jun 2018 17:29:29 +1000 Subject: [PATCH 02/11] Versioning and changelog for v2.7.2 (#1610) * Versioning for v2.7.2 * Update changelog.md --- CHANGELOG.md | 3 +++ app/build.gradle | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7c77174cf..1688b3b02 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,8 @@ # Wikimedia Commons for Android +## v2.7.2 +- Modified subtext for "automatically get current location" setting to emphasize that it will reveal user's location + ## v2.7.1 - Fixed UI and permission issues with Nearby - Fixed issue with My Recent Uploads being empty diff --git a/app/build.gradle b/app/build.gradle index 9300cd9aa..dc8c3b845 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -92,8 +92,8 @@ android { defaultConfig { applicationId 'fr.free.nrw.commons' - versionCode 84 - versionName '2.7.1' + versionCode 85 + versionName '2.7.2' setProperty("archivesBaseName", "app-commons-v$versionName-" + getBranchName()) minSdkVersion project.minSdkVersion From 2e9af3c33ad9c6a721df9d6b0f6872479ce73c1e Mon Sep 17 00:00:00 2001 From: nemobis Date: Tue, 12 Jun 2018 22:05:25 +0300 Subject: [PATCH 03/11] Correct name is "Wikidata", not "wiki data" Reported at https://phabricator.wikimedia.org/T196439 --- app/src/main/res/values/strings.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index c0e6fb719..d2acdb245 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -284,7 +284,7 @@ Error fetching nearby places. Image successfully added to %1$s on Wikidata! - Failed to update corresponding wiki data entity! + Failed to update corresponding Wikidata entity! Set wallpaper Wallpaper set successfully! From 1dc0a7c257d9f93162dd90fb4bfe95a09c4e75bb Mon Sep 17 00:00:00 2001 From: Vivek Maskara Date: Thu, 14 Jun 2018 14:42:46 +0530 Subject: [PATCH 04/11] Fix resource not found exception with null checks (#1628) --- .../contributions/ContributionsActivity.java | 20 +++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsActivity.java b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsActivity.java index 312839a24..c39fbb06e 100644 --- a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsActivity.java +++ b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsActivity.java @@ -275,17 +275,25 @@ public class ContributionsActivity .getUploadCount(sessionManager.getCurrentAccount().name) .subscribeOn(Schedulers.io()) .observeOn(AndroidSchedulers.mainThread()) - .subscribe( - uploadCount -> getSupportActionBar().setSubtitle(getResources() - .getQuantityString(R.plurals.contributions_subtitle, - uploadCount, uploadCount)), + .subscribe(this::displayUploadCount, t -> Timber.e(t, "Fetching upload count failed") )); } - public void betaSetUploadCount(int betaUploadCount){ + private void displayUploadCount(Integer uploadCount) { + if (isFinishing() + || getSupportActionBar() == null + || getResources() == null) { + return; + } + getSupportActionBar().setSubtitle(getResources() - .getQuantityString(R.plurals.contributions_subtitle, betaUploadCount, betaUploadCount)); + .getQuantityString(R.plurals.contributions_subtitle, + uploadCount, uploadCount)); + } + + public void betaSetUploadCount(int betaUploadCount) { + displayUploadCount(betaUploadCount); } From 18b0517fc7390e4ac27a492bdf6ec15ceeebd2c8 Mon Sep 17 00:00:00 2001 From: Vivek Maskara Date: Tue, 19 Jun 2018 13:23:26 +0530 Subject: [PATCH 05/11] Fix crash while uploading image with whitespace title (#1636) --- .../fr/free/nrw/commons/upload/SingleUploadFragment.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/fr/free/nrw/commons/upload/SingleUploadFragment.java b/app/src/main/java/fr/free/nrw/commons/upload/SingleUploadFragment.java index a32fb7b42..a993d59da 100644 --- a/app/src/main/java/fr/free/nrw/commons/upload/SingleUploadFragment.java +++ b/app/src/main/java/fr/free/nrw/commons/upload/SingleUploadFragment.java @@ -74,13 +74,13 @@ public class SingleUploadFragment extends CommonsDaggerSupportFragment { //What happens when the 'submit' icon is tapped case R.id.menu_upload_single: - if (titleEdit.getText().toString().isEmpty()) { + if (titleEdit.getText().toString().trim().isEmpty()) { Toast.makeText(getContext(), R.string.add_title_toast, Toast.LENGTH_LONG).show(); return false; } - String title = titleEdit.getText().toString(); - String desc = descEdit.getText().toString(); + String title = titleEdit.getText().toString().trim(); + String desc = descEdit.getText().toString().trim(); //Save the title/desc in short-lived cache so next time this fragment is loaded, we can access these prefs.edit() From e05993f450fb2ee535ebf0da9917e3b1aef0ee1b Mon Sep 17 00:00:00 2001 From: "translatewiki.net" Date: Mon, 25 Jun 2018 08:10:39 +0200 Subject: [PATCH 06/11] Localisation updates from https://translatewiki.net. --- app/src/main/res/values-cy/strings.xml | 59 +++++++++++++++++++++++--- app/src/main/res/values-ja/strings.xml | 10 +++-- app/src/main/res/values-ru/strings.xml | 6 +-- app/src/main/res/values-tr/strings.xml | 8 ++-- app/src/main/res/values-zh/strings.xml | 3 +- 5 files changed, 69 insertions(+), 17 deletions(-) diff --git a/app/src/main/res/values-cy/strings.xml b/app/src/main/res/values-cy/strings.xml index 68ffef8a0..134c2f116 100644 --- a/app/src/main/res/values-cy/strings.xml +++ b/app/src/main/res/values-cy/strings.xml @@ -5,18 +5,25 @@ * Robin Owain --> + Ymddangosiad + Cyffredinol + Adborth + Lleoliad Comin Wicimedia + Gosodiadau Enw defnyddiwr Cyfrinair + Mewngofnodwch i\'ch cyfri Comin Beta Mewngofnodi + Anghofiwyd y Cyfrinair? Cofrestru Wrthi\'n mewngofnodi Disgwyliwch… Llwyddodd y mewngofnodi! Methodd y mewngofnodi! Ni chafwyd hyd i\'r ffeil. Ceisiwch un arall. - Methodd y dilysu! + Methodd y dilysu! Mewngofnodwch eto. Dechreuodd yr uwchlwytho! Uwchlwythwyd %1$s! Tapiwch i weld eich uwchlwythiad @@ -41,8 +48,10 @@ Rhannu Agor yn y Porwr Teitl + Rhowch deitl i\'r ffeil Disgrifiad Yn methu mewngofnodi - methodd y rhwydwaith + Methwyd mewngofnodi - gwirwch eich enw defnyddiwr a\'ch cyfrinair Cafwyd gormod o ymgeision aflwyddiannus. Oedwch ennyd cyn ceisio eto. Ymddiheurwn. Mae\'r defnyddiwr hwn wedi ei flocio ar Gomin Wikimedia Mae\'n rhaid i chi roi eich cod adnabod 2 ffactor. @@ -54,6 +63,7 @@ Archwilio\'r categorïau Cadw Ailgyrchu + Rhestr Ataliwyd GPS ar eich dyfais. Ydych chi am ei droi\'n weithredol? Gweithredu\'r GPS Heb uwchlwytho eto @@ -75,11 +85,12 @@ Categorïau Gosodiadau Cofrestru + Delweddau nodwedd Amdanom Ap Cynnwys Agored a grewyd ac a gefnogir gan wirfoddolwyr cymuned Wicimedia yw ap Comin Wicimedia. Does a wnelo Sefydliad Wicimedia ddim byd ag e (ei greu, ei gynnal na\'i ddatblygu). \n\nCrewch <a href=\"https://github.com/commons-app/apps-android-commons/issues\">ymholiad GitHub</a> os oes gennych fyg, broblem neu awgrym. - <a href=\"https://github.com/commons-app/apps-android-commons/wiki/Privacy-policy\">Polisi Preifatrwydd</a> - <a href=\"https://github.com/commons-app/apps-android-commons/blob/master/CREDITS\">Clod</a> + <u>Polisi preifatrwydd</u> + Clod a bri Amdanom Danfonwch Adborth (drwy Ebost) Dim ebost client wedi\'i ganfod @@ -91,10 +102,10 @@ Caiff y ddelwedd hon ei thrwyddedu yn ôl termau\'r drwydded %1$s. Wrth gynnig y llun yma, rwy\'n datgan mai fy ngwaith i ydyw ac nad yw\'n cynnwys unrhyw beth dan hawlfrain, na hunlun, a\'i fod yn cadw at <a href=\"https://commons.wikimedia.org/wiki/Commons:Policies_and_guidelines\">Bolisiau Comin Wicimedia</a>. Lawrlwytho - Trwydded + Trwydded Ddiofyn (\'default\') Defnydiwch y teitl/disgrifiad blaenorol Defnyddiwch y lleoliad cyfredol - Canfyddwch eich lleoliad, er mwyn i ni gynnig categori (os nad ydych wedi nodi\'r cyfesurynnau). + Adfer eich lleoliad presennol os nad yw\'r ddelwedd yn cynnwys cyfesurynnau. Bydd hyn yn datgelu eich lleoliad chi! Modd fin nos Defnyddiwch thema tywyll Attribution-ShareAlike 4.0 @@ -120,9 +131,19 @@ Cyhelir llawer o luniau ar Gomin Wicimedia sy\'n cael eu defnyddio ar Wicipedia. Mae eich lluniau\'n gymorth i addysgu pobl drwy\'r byd mawr crwn! Uwchlwythwch lluniau a dynnoch eich hun: - - Natur (blodau, anifeiliaid, mynyddoedd)\n- Pethau defnyddiol (beic, tren, gorsaf drenau)\n- Enwogion (beirdd, athletwyr, blogwyr) + Gwrthrychau byd natur (blodau, anifeiliaid, mynyddoedd)\n- Gwrthrychau defnyddiol (beics, trenau, gorsafoedd trenau)\n- Enwogion (beirdd, athletwyr, blogwyr) + Gwrthrychau byd natur (blodau, anifeiliaid, mynyddoedd) + Gwrthrychau defnyddiol (beics, trenau, gorsafoedd trenau) + Enwogion (beirdd, athletwyr, blogwyr) Peidiwch ag uwchlwytho: - hunanluniau ohonoch chi na\'ch ffrindiau\n- lluniau a gawsoch o\'r we\n- sgrinluniau o apiau masnachol + Hunanluniau neu luniau o\'ch ffrindiau + Lluniau a lawrlwythwyd o\'r we gennych + Sgrinluniau o aps + Enghraifft o uwchlwythiad: + Teitl:Tŷ Opera Sydney + Disgrifiad: Golygfa o Dŷ Opera Sydney o ochr arall y bae + Categoriau: Tŷ Opera Sydney o\'r gorllewin Cyfranwch luniau. Cynorthwywch Wicipedia i roi bywyd yn yr erthyglau! Mae\'r delweddau ar Wicipedia\'n dod o\nGomin Wikimedia. Mae eich delweddau\'n cynorthwyo i addysgu pobl ledled y byd. @@ -135,6 +156,32 @@ Dim disgrifiad Trwydded anhysbys Adnewyddu + Iawn + Lleoedd Cyfagos + Ni chafwyd hyd i leoedd cyfagos + Rhybudd + Ydw + Nac ydw Teitl + teitl y cyfrwng Disgrifiad + Awdur + Dyddiad yr uwchlwythiad + Trwydded + Cyfesurynnau + Dim + Eitem Wicidata + Erthygl Wicipedia + Mewngofnodwch i\'ch cyfri + Danfonwch y ffeil log + Gweld yn y porwr + Nid yw\'r lleoliad wedi newid. + Nid yw\'r lleoliad ar gael. + Parhau + Canslo + Ailgeisio + Gwnaed! + Llun y Dydd + Llun y Dydd + Mae %1$s o luniau wedi\'u hychwanegu ar Wicidata! diff --git a/app/src/main/res/values-ja/strings.xml b/app/src/main/res/values-ja/strings.xml index c2e243770..c3badb9fb 100644 --- a/app/src/main/res/values-ja/strings.xml +++ b/app/src/main/res/values-ja/strings.xml @@ -30,7 +30,7 @@ ログインしました! ログインに失敗しました! ファイルが見つかりません。別のファイルでお試しください。 - 認証に失敗しました! + 認証に失敗しました! もう一度ログインしてください アップロードを開始しました! %1$s をアップロードしました! アップロードしたものを表示するにはタップしてください @@ -61,7 +61,7 @@ ログインできません - 利用者名とパスワードを確認してください 失敗した回数が多すぎます。数分待ってからもう一度お試しください。 申し訳ありませんが、この利用者はコモンズでブロックされています。 - 2要素認証コードを提供する必要があります。 + 2段階認証コードを入力する必要があります。 ログイン失敗 アップロード このセットに名前をつけてください @@ -185,7 +185,7 @@ 情報なし ベータ版を使ってみましょう! Google Playのベータ版チャンネルにオプトインして、新機能やバグ修正プログラムに早期にアクセス - 2FA コード + 2段階認証コード 最近のアップロードファイルに表示する最大件数 最大限 表示できるのは500件以下です @@ -280,8 +280,10 @@ アプリをシェアする 画像の選択中に位置情報を特定できませんでした 付近の場所を取得しようとしてエラーが発生しました。 + 今日の一枚 + 今日の一枚 ウィキデータの%1$sに画像を追加しました ! - 対応するウィキデータの引数の更新に失敗しました。 + 対応するウィキデータの更新に失敗しました! 壁紙の設定 壁紙の設定ができました! diff --git a/app/src/main/res/values-ru/strings.xml b/app/src/main/res/values-ru/strings.xml index ed28ccb20..0b499b414 100644 --- a/app/src/main/res/values-ru/strings.xml +++ b/app/src/main/res/values-ru/strings.xml @@ -31,7 +31,7 @@ Войдите в свою учётную запись Commons Beta Войти Забыли пароль? - Зарегистрироваться + Регистрация Вход в систему Пожалуйста, подождите… Вход выполнен успешно! @@ -98,7 +98,7 @@ Добавьте категории, чтобы ваши изображения можно было легко найти на Викискладе.\nНачните вводить название для добавления категорий. Категории Настройки - Зарегистрироваться + Регистрация Избранные изображения О приложении Приложение «Викисклад» - это программа с открытым кодом, которую создали волонтёры и участники грантов Викимедиа. Фонд Викимедиа не участвует в создании, разработке или обслуживании этого приложения. @@ -277,7 +277,7 @@ <u>Перевести</u> Языки Выберите язык локализации, на который сможете перевести элементы интерфейса приложения - Выполняется + Перейти к переводу Отмена Повторить Понятно! diff --git a/app/src/main/res/values-tr/strings.xml b/app/src/main/res/values-tr/strings.xml index 96e7cd96d..d04974f5a 100644 --- a/app/src/main/res/values-tr/strings.xml +++ b/app/src/main/res/values-tr/strings.xml @@ -30,7 +30,7 @@ Oturum açma başarılı! Oturum açma başarısız oldu! Dosya bulunamadı. Lütfen başka bir dosya deneyin. - Kimlik doğrulama başarısız oldu! + Kimlik doğrulama başarısız oldu, lütfen tekrar giriş yapın Yükleme başladı! %1$s yüklendi! Yüklemelerinizi görüntülemek için dokunun @@ -112,7 +112,7 @@ Varsayılan lisans Önceki başlığı/açıklamayı kullan Otomatik olarak mevcut konumu al - Resim koordinat olarak etiketlendirilmemişse kategori önerileri için mevcut konum bulun + Resim coğrafi etiketli değilse ve coğrafi etiketler resimle görüntüleniyorsa geçerli konumu alır. Uyarı: Mevcut konumunuzu gösterir. Gece modu Koyu temayı kullanın Attribution-ShareAlike 4.0 @@ -282,8 +282,10 @@ Uygulamayı Paylaş Koordinatlar görüntü seçimi sırasında belirlenmedi Yakındaki yerler alınırken hata oluştu. + Günün Resmi + Günün Resmi Resim, Vikiveri\'de %1$s içine başarıyla eklendi. - Karşılık gelen viki veri varlığı güncellenemedi! + Karşılık gelen Vikiveri varlığı güncellenemedi! Duvar kağıdı ayarla Duvar kağıdı başarıyla ayarlandı! diff --git a/app/src/main/res/values-zh/strings.xml b/app/src/main/res/values-zh/strings.xml index 5bcf095db..090ddd1dd 100644 --- a/app/src/main/res/values-zh/strings.xml +++ b/app/src/main/res/values-zh/strings.xml @@ -1,6 +1,7 @@ 外观 - 一般 + 常规 反馈 位置 共享资源 From c1c178c576475a5008df7e8cafeb6cde6186a3ac Mon Sep 17 00:00:00 2001 From: Nicolas Raoul Date: Thu, 28 Jun 2018 01:18:16 +0900 Subject: [PATCH 07/11] Fix nearby crash by updating to Mapbox version that includes telem 2.2.10 (#1666) --- app/build.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/build.gradle b/app/build.gradle index 68a31f984..bb0220b30 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -22,7 +22,7 @@ dependencies { implementation 'info.debatty:java-string-similarity:0.24' implementation 'com.borjabravo:readmoretextview:2.1.0' implementation 'com.android.support.constraint:constraint-layout:1.0.2' - implementation('com.mapbox.mapboxsdk:mapbox-android-sdk:5.4.1@aar') { + implementation('com.mapbox.mapboxsdk:mapbox-android-sdk:5.5.0@aar') { transitive = true } implementation 'com.github.deano2390:MaterialShowcaseView:1.2.0' From 00924513571a53a5822562a14d6e93c017303b69 Mon Sep 17 00:00:00 2001 From: "translatewiki.net" Date: Thu, 28 Jun 2018 07:19:17 +0200 Subject: [PATCH 08/11] Localisation updates from https://translatewiki.net. --- app/src/main/res/values-bn/error.xml | 1 + app/src/main/res/values-bn/strings.xml | 1 + app/src/main/res/values-fr/strings.xml | 2 +- app/src/main/res/values-nl/strings.xml | 1 + 4 files changed, 4 insertions(+), 1 deletion(-) diff --git a/app/src/main/res/values-bn/error.xml b/app/src/main/res/values-bn/error.xml index 2c929f8b5..66984d45f 100644 --- a/app/src/main/res/values-bn/error.xml +++ b/app/src/main/res/values-bn/error.xml @@ -3,6 +3,7 @@ * Aftabuzzaman * Bellayet * Sankarshan +* আফতাবুজ্জামান --> কমন্স ক্র্যাশ করেছে diff --git a/app/src/main/res/values-bn/strings.xml b/app/src/main/res/values-bn/strings.xml index d9aa9e657..c412c11c2 100644 --- a/app/src/main/res/values-bn/strings.xml +++ b/app/src/main/res/values-bn/strings.xml @@ -9,6 +9,7 @@ * Rasal Lia * Sankarshan * Tauhid16 +* আফতাবুজ্জামান --> অবয়ব diff --git a/app/src/main/res/values-fr/strings.xml b/app/src/main/res/values-fr/strings.xml index 63eb7eefb..9308e44fb 100644 --- a/app/src/main/res/values-fr/strings.xml +++ b/app/src/main/res/values-fr/strings.xml @@ -120,7 +120,7 @@ Licence par défaut Utiliser le titre ou la description précédent Obtenir automatiquement l’emplacement actuel - Récupère l’emplacement actuel si l’image n’est pas marquée géographiquement, et marque géographiquement l’image avec. Avertissement : Cela dévoilera votre emplacement actuel. + Récupère l’emplacement actuel si l’image n’est pas marquée géographiquement, et marque géographiquement l’image avec. Avertissement : ceci dévoilera votre emplacement actuel. Mode de nuit Utiliser un thème sombre Attribution-ShareAlike 4.0 diff --git a/app/src/main/res/values-nl/strings.xml b/app/src/main/res/values-nl/strings.xml index 8a47cc3cd..2e84ab342 100644 --- a/app/src/main/res/values-nl/strings.xml +++ b/app/src/main/res/values-nl/strings.xml @@ -1,6 +1,7 @@