mirror of
				https://github.com/commons-app/apps-android-commons.git
				synced 2025-11-04 08:43:52 +01:00 
			
		
		
		
	Inject prefs into FileProcessor instead of passing it from ShareActivity
This commit is contained in:
		
							parent
							
								
									82659316ff
								
							
						
					
					
						commit
						c3e911f135
					
				
					 3 changed files with 8 additions and 8 deletions
				
			
		| 
						 | 
				
			
			@ -20,6 +20,7 @@ import java.util.Date;
 | 
			
		|||
import java.util.List;
 | 
			
		||||
 | 
			
		||||
import javax.inject.Inject;
 | 
			
		||||
import javax.inject.Named;
 | 
			
		||||
 | 
			
		||||
import fr.free.nrw.commons.caching.CacheController;
 | 
			
		||||
import fr.free.nrw.commons.di.ApplicationlessInjection;
 | 
			
		||||
| 
						 | 
				
			
			@ -34,7 +35,6 @@ public class FileProcessor implements SimilarImageDialogFragment.onResponse{
 | 
			
		|||
    private Uri mediaUri;
 | 
			
		||||
    private ContentResolver contentResolver;
 | 
			
		||||
    private GPSExtractor imageObj;
 | 
			
		||||
    private SharedPreferences prefs;
 | 
			
		||||
    private Context context;
 | 
			
		||||
    private String decimalCoords;
 | 
			
		||||
    private boolean haveCheckedForOtherImages = false;
 | 
			
		||||
| 
						 | 
				
			
			@ -49,11 +49,13 @@ public class FileProcessor implements SimilarImageDialogFragment.onResponse{
 | 
			
		|||
    GpsCategoryModel gpsCategoryModel;
 | 
			
		||||
    @Inject
 | 
			
		||||
    CategoryApi apiCall;
 | 
			
		||||
    @Inject
 | 
			
		||||
    @Named("default_preferences")
 | 
			
		||||
    SharedPreferences prefs;
 | 
			
		||||
 | 
			
		||||
    FileProcessor(Uri mediaUri, ContentResolver contentResolver, SharedPreferences prefs, Context context) {
 | 
			
		||||
    FileProcessor(Uri mediaUri, ContentResolver contentResolver, Context context) {
 | 
			
		||||
        this.mediaUri = mediaUri;
 | 
			
		||||
        this.contentResolver = contentResolver;
 | 
			
		||||
        this.prefs = prefs;
 | 
			
		||||
        this.context = context;
 | 
			
		||||
        useExtStorage = prefs.getBoolean("useExternalStorage", true);
 | 
			
		||||
        ApplicationlessInjection.getInstance(context.getApplicationContext()).getCommonsApplicationComponent().inject(this);
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -1,12 +1,11 @@
 | 
			
		|||
package fr.free.nrw.commons.upload;
 | 
			
		||||
 | 
			
		||||
import android.Manifest;
 | 
			
		||||
 | 
			
		||||
import android.app.Activity;
 | 
			
		||||
import android.animation.Animator;
 | 
			
		||||
import android.animation.AnimatorListenerAdapter;
 | 
			
		||||
import android.animation.AnimatorSet;
 | 
			
		||||
import android.animation.ObjectAnimator;
 | 
			
		||||
import android.app.Activity;
 | 
			
		||||
import android.content.ContentResolver;
 | 
			
		||||
import android.content.Context;
 | 
			
		||||
import android.content.Intent;
 | 
			
		||||
| 
						 | 
				
			
			@ -305,7 +304,7 @@ public class ShareActivity
 | 
			
		|||
        uploadController.prepareService();
 | 
			
		||||
 | 
			
		||||
        ContentResolver contentResolver = this.getContentResolver();
 | 
			
		||||
        fileObj = new FileProcessor(mediaUri, contentResolver, prefs, this);
 | 
			
		||||
        fileObj = new FileProcessor(mediaUri, contentResolver, this);
 | 
			
		||||
        checkIfFileExists();
 | 
			
		||||
        fileObj.getFileCoordinates(locationPermitted);
 | 
			
		||||
    }
 | 
			
		||||
| 
						 | 
				
			
			@ -342,7 +341,7 @@ public class ShareActivity
 | 
			
		|||
        isFABOpen=true;
 | 
			
		||||
 | 
			
		||||
        if( imageObj != null && imageObj.imageCoordsExists)
 | 
			
		||||
        mapButton.setVisibility(View.VISIBLE);
 | 
			
		||||
            mapButton.setVisibility(View.VISIBLE);
 | 
			
		||||
        zoomInButton.setVisibility(View.VISIBLE);
 | 
			
		||||
 | 
			
		||||
        mainFab.animate().rotationBy(180);
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -11,7 +11,6 @@ import android.support.v4.graphics.BitmapCompat;
 | 
			
		|||
import android.view.View;
 | 
			
		||||
import android.widget.FrameLayout;
 | 
			
		||||
 | 
			
		||||
import java.io.FileNotFoundException;
 | 
			
		||||
import java.io.IOException;
 | 
			
		||||
import java.io.InputStream;
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue