From c1aead8b24451a8cb6c1f446aa6d753d9aca5ecc Mon Sep 17 00:00:00 2001
From: sonalyadav <sonal.y6390@gmail.com>
Date: Fri, 20 Jun 2025 21:30:12 +0530
Subject: [PATCH]  Skip image upload to Wikidata if item already has image

---
 .../fr/free/nrw/commons/upload/worker/UploadWorker.kt  |  6 ++++++
 .../main/res/values-x-invalidLanguageCode/error.xml    | 10 ----------
 2 files changed, 6 insertions(+), 10 deletions(-)
 delete mode 100644 app/src/main/res/values-x-invalidLanguageCode/error.xml

diff --git a/app/src/main/java/fr/free/nrw/commons/upload/worker/UploadWorker.kt b/app/src/main/java/fr/free/nrw/commons/upload/worker/UploadWorker.kt
index 6d28085b2..88bcbf22a 100644
--- a/app/src/main/java/fr/free/nrw/commons/upload/worker/UploadWorker.kt
+++ b/app/src/main/java/fr/free/nrw/commons/upload/worker/UploadWorker.kt
@@ -473,6 +473,8 @@ class UploadWorker(
             if (!contribution.hasInvalidLocation()) {
                 var revisionID: Long? = null
                 try {
+                    // Only set P18 if the place does not already have a picture
+                    if (wikiDataPlace.imageValue.isNullOrBlank()) {
                     revisionID =
                         wikidataEditService.createClaim(
                             wikiDataPlace,
@@ -489,7 +491,11 @@ class UploadWorker(
                                 .subscribeOn(Schedulers.io())
                                 .blockingAwait()
                             Timber.d("Updated WikiItem place ${place.name} with image ${place.pic}")
+                            }
+                            showSuccessNotification(contribution)
                         }
+                    } else {
+                        // Place already has a picture, so skip setting P18 but still show success notification
                         showSuccessNotification(contribution)
                     }
                 } catch (exception: Exception) {
diff --git a/app/src/main/res/values-x-invalidLanguageCode/error.xml b/app/src/main/res/values-x-invalidLanguageCode/error.xml
deleted file mode 100644
index f4e2fe125..000000000
--- a/app/src/main/res/values-x-invalidLanguageCode/error.xml
+++ /dev/null
@@ -1,10 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<!-- Authors:
-* Vlad5250
--->
-<resources>
-  <string name="crash_dialog_title">کامَنٕز گوو رُکِتھ</string>
-  <string name="crash_dialog_text">Oops. کیہہ تام گوو غلط!</string>
-  <string name="crash_dialog_comment_prompt">ؤنِیوٚ اَسہِ توٚہہِ کیاہ ٲسِیوٚ کران، تہٕ کٕریٚو تہِ اَسہِ سٕتی شیر بذریعہِ برقی خط. یُس مَدَتھ کَرِ اَسہِ اَتھ شہَرنَس منٛز!</string>
-  <string name="crash_dialog_ok_toast">شُکریہ!</string>
-</resources>