mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 04:43:54 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Enhancing Multi-Upload Functionality for Consistent Depiction Categorization (#5700)

Browse source 
* Add AlertDialog for categories and modularize receiveSharedItems

* Improve nearby-place search function for a multi-upload

Enhance the depiction consistency of a multi-upload by ensuring that it corresponds to a single place

* Add javadoc

* Update strings.xml

* Renamed setImageTobeUploaded to setImageToBeUploaded

* Make uploadIsOnPlace private & add a setter

* Rename uploadIsOnPlace to uploadIsOfAPlace

* Use singular when there is only one picture

* Add a 'Do not show again' checkbox on the dialog

* Update strings.xml

---------

Co-authored-by: Giannis Karyotakis <110292528+karyotakisg@users.noreply.github.com>
Co-authored-by: Nicolas Raoul <nicolas.raoul@gmail.com>
This commit is contained in:
Evangelos Talos 2024-05-02 14:12:32 +03:00 • committed by GitHub
parent 6aa9303d0f
commit c178c5de41
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
7 changed files with 210 additions and 99 deletions
Download patch file Download diff file Expand all files Collapse all files

16
app/src/main/res/layout/activity_upload_categories_dialog.xml Normal file
View file

@ -0,0 +1,16 @@
<?xml version="1.0" encoding="utf-8"?>
<LinearLayout
xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
xmlns:tools="http://schemas.android.com/tools"
android:id="@+id/upload_root_layout"
android:layout_width="match_parent"
android:layout_height="match_parent">
<CheckBox
android:id="@+id/categories_checkbox"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:text="Don't show this message again" />
</LinearLayout>

5
app/src/main/res/values/strings.xml
View file

@ -610,7 +610,8 @@ Upload your first media by tapping on the add button.</string>
<string name="title_for_parent_classes">PARENT CLASSES</string>
<string name="upload_nearby_place_found_title">Nearby Place Found</string>
<string name="upload_nearby_place_found_description">Is this a photo of %1$s?</string>
<string name="upload_nearby_place_found_description_plural">Are these pictures of %1$s?</string>
<string name="upload_nearby_place_found_description_singular">Is this a picture of %1$s?</string>
<string name="title_app_shortcut_bookmark">Bookmarks</string>
<string name="title_app_shortcut_setting">Settings</string>
<string name="remove_bookmark">Removed from bookmarks</string>
@ -815,4 +816,6 @@ Upload your first media by tapping on the add button.</string>
<item quantity="one">%d image selected</item>
<item quantity="other">%d images selected</item>
</plurals>
<string name="multiple_files_depiction">Please remember that all images in a multi-upload get the same categories and depictions. If the images do not share depictions and categories, please perform several separate uploads.</string>
<string name="multiple_files_depiction_header">Note about multi-uploads</string>
</resources>