From c0a93b6fc23b0927a3179bdf7ea61a851ce03525 Mon Sep 17 00:00:00 2001
From: Sujal-Gupta-SG <Sujal24092004+github@gmail.com>
Date: Sun, 19 Jan 2025 20:05:19 +0530
Subject: [PATCH] fix/handle-shared-files-and-error-handling

---
 .../nrw/commons/upload/worker/UploadWorker.kt | 23 ++++++++++++-------
 1 file changed, 15 insertions(+), 8 deletions(-)

diff --git a/app/src/main/java/fr/free/nrw/commons/upload/worker/UploadWorker.kt b/app/src/main/java/fr/free/nrw/commons/upload/worker/UploadWorker.kt
index b2c21c9d7..88c66e9d5 100644
--- a/app/src/main/java/fr/free/nrw/commons/upload/worker/UploadWorker.kt
+++ b/app/src/main/java/fr/free/nrw/commons/upload/worker/UploadWorker.kt
@@ -469,18 +469,23 @@ class UploadWorker(
         contribution: Contribution,
     ) {
         val wikiDataPlace = contribution.wikidataPlace
-        if (wikiDataPlace != null && wikiDataPlace.imageValue == null) {
+
+        if (wikiDataPlace != null) {
             if (!contribution.hasInvalidLocation()) {
                 var revisionID: Long? = null
                 try {
-                    revisionID =
-                        wikidataEditService.createClaim(
-                            wikiDataPlace,
-                            uploadResult.filename,
-                            contribution.media.captions,
-                        )
-                    if (null != revisionID) {
+                    // Always attempt to update the image claim with the latest photo
+                    revisionID = wikidataEditService.createClaim(
+                        wikiDataPlace,
+                        uploadResult.filename,
+                        contribution.media.captions,
+                    )
+                    Timber.d(revisionID.toString())
+                    if (revisionID != null) {
+                        Timber.d("Updating WikiItem place with image")
                         withContext(Dispatchers.IO) {
+                            Timber.d("Updating WikiItem place with image")
+                            // Fetch and update place details
                             val place = placesRepository.fetchPlace(wikiDataPlace.id)
                             place.name = wikiDataPlace.name
                             place.pic = HOME_URL + uploadResult.createCanonicalFileName()
@@ -511,9 +516,11 @@ class UploadWorker(
                 }
             }
         }
+
         saveCompletedContribution(contribution, uploadResult)
     }
 
+
     private fun saveCompletedContribution(
         contribution: Contribution,
         uploadResult: UploadResult,