#3843 Unit Test DepictedItem - add tests (#3844)

2025-10-27 12:53:55 +01:00 · 2020-06-25 07:59:50 +01:00 · 2020-06-25 07:59:50 +01:00 · bf4b7e2efc
commit bf4b7e2efc
parent 7cfa8078f4
3 changed files with 243 additions and 2 deletions
--- a/app/src/test/kotlin/fr/free/nrw/commons/upload/structure/depictions/DepictedItemTest.kt
+++ b/app/src/test/kotlin/fr/free/nrw/commons/upload/structure/depictions/DepictedItemTest.kt
@ -0,0 +1,178 @@
+package fr.free.nrw.commons.upload.structure.depictions
+
+import com.nhaarman.mockitokotlin2.mock
+import depictedItem
+import entity
+import entityId
+import fr.free.nrw.commons.wikidata.WikidataProperties
+import org.hamcrest.CoreMatchers.`is`
+import org.hamcrest.CoreMatchers.not
+import org.hamcrest.MatcherAssert.assertThat
+import org.hamcrest.Matchers.nullValue
+import org.junit.Test
+import place
+import snak
+import statement
+import valueString
+import wikiBaseEntityValue
+
+class DepictedItemTest {
+
+    @Test
+    fun `name and description get user language label`() {
+        val depictedItem =
+            DepictedItem(entity(mapOf("en" to "label"), mapOf("en" to "description")))
+        assertThat(depictedItem.name, `is`("label"))
+        assertThat(depictedItem.description, `is`("description"))
+    }
+
+    @Test
+    fun `name and descriptions get first language label if user language not present`() {
+        val depictedItem = DepictedItem(entity(mapOf("" to "label"), mapOf("" to "description")))
+        assertThat(depictedItem.name, `is`("label"))
+        assertThat(depictedItem.description, `is`("description"))
+    }
+
+    @Test
+    fun `name and descriptions get empty if nothing present`() {
+        val depictedItem = DepictedItem(entity())
+        assertThat(depictedItem.name, `is`(""))
+        assertThat(depictedItem.description, `is`(""))
+    }
+
+    @Test
+    fun `image is empty with null statements`() {
+        assertThat(DepictedItem(entity(statements = null)).imageUrl, nullValue())
+    }
+
+    @Test
+    fun `image is empty with no image statement`() {
+        assertThat(DepictedItem(entity()).imageUrl, nullValue())
+    }
+
+    @Test
+    fun `image is empty with dataValue not of ValueString type`() {
+        assertThat(
+            DepictedItem(
+                entity(
+                    statements = mapOf(
+                        WikidataProperties.IMAGE.propertyName to listOf(statement(snak(dataValue = mock())))
+                    )
+                )
+            ).imageUrl,
+            nullValue()
+        )
+    }
+
+    @Test
+    fun `image is not empty with dataValue of ValueString type`() {
+        assertThat(
+            DepictedItem(
+                entity(
+                    statements = mapOf(
+                        WikidataProperties.IMAGE.propertyName to listOf(
+                            statement(snak(dataValue = valueString("prefix: example_")))
+                        )
+                    )
+                )
+            ).imageUrl,
+            `is`("https://upload.wikimedia.org/wikipedia/commons/thumb/b/b7/_example_/70px-_example_")
+        )
+    }
+
+    @Test
+    fun `instancesOf maps EntityIds to ids`() {
+        assertThat(
+            DepictedItem(
+                entity(
+                    statements = mapOf(
+                        WikidataProperties.INSTANCE_OF.propertyName to listOf(
+                            statement(snak(dataValue = valueString("prefix: example_"))),
+                            statement(snak(dataValue = entityId(wikiBaseEntityValue(id = "1")))),
+                            statement(snak(dataValue = entityId(wikiBaseEntityValue(id = "2"))))
+                        )
+                    )
+                )
+            ).instanceOfs,
+            `is`(listOf("1", "2")))
+    }
+
+    @Test
+    fun `instancesOf is empty with no values`() {
+        assertThat(DepictedItem(entity()).instanceOfs, `is`(emptyList()))
+    }
+
+    @Test
+    fun `commonsCategory maps ValueString to strings`() {
+        assertThat(
+            DepictedItem(
+                entity(
+                    statements = mapOf(
+                        WikidataProperties.COMMONS_CATEGORY.propertyName to listOf(
+                            statement(snak(dataValue = valueString("1"))),
+                            statement(snak(dataValue = valueString("2")))
+                        )
+                    )
+                )
+            ).commonsCategories,
+            `is`(listOf("1", "2")))
+    }
+
+    @Test
+    fun `commonsCategory is empty with no values`() {
+        assertThat(DepictedItem(entity()).commonsCategories, `is`(emptyList()))
+    }
+
+    @Test
+    fun `isSelected is false at creation`() {
+        assertThat(DepictedItem(entity()).isSelected, `is`(false))
+    }
+
+    @Test
+    fun `id is entityId`() {
+        assertThat(DepictedItem(entity(id = "1")).id, `is`("1"))
+    }
+
+    @Test
+    fun `place constructor uses place name and longDescription`() {
+        val depictedItem = DepictedItem(entity(), place(name = "1", longDescription = "2"))
+        assertThat(depictedItem.name, `is`("1"))
+        assertThat(depictedItem.description, `is`("2"))
+    }
+
+
+    @Test
+    fun `same object is Equal`() {
+        val depictedItem = depictedItem()
+        assertThat(depictedItem == depictedItem, `is`(true))
+    }
+
+    @Test
+    fun `different type is not Equal`() {
+        assertThat(depictedItem().equals(Unit), `is`(false))
+    }
+
+    @Test
+    fun `if names are equal is Equal`() {
+        assertThat(
+            depictedItem(name="a", id = "0") == depictedItem(name="a", id = "1"),
+            `is`(true))
+    }
+
+    @Test
+    fun `if names are not equal is not Equal`() {
+        assertThat(
+            depictedItem(name="a") == depictedItem(name="b"),
+            `is`(false))
+    }
+
+    @Test
+    fun `hashCode returns same values for objects with same name`() {
+        assertThat(depictedItem(name="a").hashCode(), `is`(depictedItem(name="a").hashCode()))
+    }
+    
+    @Test
+    fun `hashCode returns different values for objects with different name`() {
+        assertThat(depictedItem(name="a").hashCode(), not(depictedItem(name="b").hashCode()))
+    }
+}