From 26dc9b4f277f493681864ef3d6ae4bfb638b5876 Mon Sep 17 00:00:00 2001 From: misaochan Date: Tue, 30 May 2017 17:26:16 +1000 Subject: [PATCH 1/4] Remove English remnant in values-kn --- app/src/main/res/values-kn/strings.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/src/main/res/values-kn/strings.xml b/app/src/main/res/values-kn/strings.xml index 643ca04e2..c0494afd8 100644 --- a/app/src/main/res/values-kn/strings.xml +++ b/app/src/main/res/values-kn/strings.xml @@ -21,8 +21,8 @@ %1$s ಅಪ್ಲೋಡ್ ಮಾಡುವಿಕೆ ವಿಫಲವಾಗಿದೆ ನೋಡಲು ಮೆಲ್ಲಗೆ ತಟ್ಟಿ - %d file uploading\n%d ಕಡತ ಅಪ್ಲೋಡ್ ಅಗುತ್ತಿದೆ - %d files uploading\n%d ಕಡತಗಳು ಅಪ್ಲೋಡ್ ಅಗುತ್ತಿದೆ + %d ಕಡತ ಅಪ್ಲೋಡ್ ಅಗುತ್ತಿದೆ + %d ಕಡತಗಳು ಅಪ್ಲೋಡ್ ಅಗುತ್ತಿದೆ ನನ್ನ ಇತ್ತಿಚಿನ ಅಪ್ಲೋಡ್ಗಳು ಸರತಿಸಾಲಿನಲ್ಲಿದೆ From e63532f32b685a953da515c6372a22a42c07eae2 Mon Sep 17 00:00:00 2001 From: misaochan Date: Tue, 30 May 2017 17:36:22 +1000 Subject: [PATCH 2/4] Add string in lowercase (to match other description strings) --- app/src/main/res/values/strings.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index f4e1e80a4..e322c1883 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -194,6 +194,7 @@ Tap this message (or hit back) to skip this step. Logout Introduction + no description found Commons Article WikiData Article From 42c86576b3a8a8e0b7f669fa4f78b1a2340cc6a3 Mon Sep 17 00:00:00 2001 From: misaochan Date: Tue, 30 May 2017 17:43:49 +1000 Subject: [PATCH 3/4] Use string resource instead of hardcoded string --- .../main/java/fr/free/nrw/commons/nearby/NearbyViewHolder.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/java/fr/free/nrw/commons/nearby/NearbyViewHolder.java b/app/src/main/java/fr/free/nrw/commons/nearby/NearbyViewHolder.java index c853dba78..11ebca46d 100644 --- a/app/src/main/java/fr/free/nrw/commons/nearby/NearbyViewHolder.java +++ b/app/src/main/java/fr/free/nrw/commons/nearby/NearbyViewHolder.java @@ -27,7 +27,7 @@ public class NearbyViewHolder implements ViewHolder { tvName.setText(place.name); String description = place.description; if ( description == null || description.isEmpty() || description.equals("?")) { - description = "No Description Found"; + description = context.getString(R.string.no_description_found); } tvDesc.setText(description); distance.setText(place.distance); From 8ca374e2082647fe3e31efdf3dcf8c48cdc70efe Mon Sep 17 00:00:00 2001 From: misaochan Date: Tue, 30 May 2017 17:44:36 +1000 Subject: [PATCH 4/4] Rename "Introduction" to Tutorial --- app/src/main/res/values/strings.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index e322c1883..1a3e780f2 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -192,7 +192,7 @@ Tap this message (or hit back) to skip this step. Settings Feedback Logout - Introduction + Tutorial no description found Commons Article