mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-31 14:53:59 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Removed usage reports in Settings layout file as well as code behind it

Browse source 
Fixes issue #11
This commit is contained in:
misaochan 2015-10-04 23:43:08 +13:00
parent 5765c99704
commit bd0dfdc961
3 changed files with 2 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

7
commons/res/xml/preferences.xml
View file

@ -1,12 +1,7 @@
<?xml version="1.0" encoding="utf-8"?> <?xml version="1.0" encoding="utf-8"?>
<PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android"> <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android">
<CheckBoxPreference
android:key="eventLogging"
android:title="@string/preference_tracking"
android:summary="@string/preference_tracking_summary"
android:defaultValue="false"
/>
<ListPreference <ListPreference
android:key="defaultLicense" android:key="defaultLicense"
android:title="@string/preference_license" android:title="@string/preference_license"

2
commons/src/main/java/free/nrw/commons/CommonsApplication.java
View file

@ -58,7 +58,7 @@ public class CommonsApplication extends Application {
public static final Object[] EVENT_LOGIN_ATTEMPT = {"MobileAppLoginAttempts", 5257721L}; public static final Object[] EVENT_LOGIN_ATTEMPT = {"MobileAppLoginAttempts", 5257721L};
public static final Object[] EVENT_SHARE_ATTEMPT = {"MobileAppShareAttempts", 5346170L}; public static final Object[] EVENT_SHARE_ATTEMPT = {"MobileAppShareAttempts", 5346170L};
public static final Object[] EVENT_CATEGORIZATION_ATTEMPT = {"MobileAppCategorizationAttempts", 5359208L}; public static final Object[] EVENT_CATEGORIZATION_ATTEMPT = {"MobileAppCategorizationAttempts", 5359208L};
public static final Object[] EVENT_EVENTLOGGING_CHANGE = {"MobileAppTrackingChange", 5369400L};
public static final String DEFAULT_EDIT_SUMMARY = "Uploaded using Android Commons app"; public static final String DEFAULT_EDIT_SUMMARY = "Uploaded using Android Commons app";

7
commons/src/main/java/free/nrw/commons/SettingsActivity.java
View file

@ -52,13 +52,6 @@ public class SettingsActivity extends SherlockPreferenceActivity implements Shar
} }
public void onSharedPreferenceChanged(SharedPreferences sharedPreferences, String key) { public void onSharedPreferenceChanged(SharedPreferences sharedPreferences, String key) {
if(key.equals(Prefs.TRACKING_ENABLED)) {
// We force log this, so it is logged even if EL is turned off
EventLog.schema(CommonsApplication.EVENT_EVENTLOGGING_CHANGE)
.param("username", app.getCurrentAccount().name)
.param("state", sharedPreferences.getBoolean(key, true))
.log(true);
}
} }
} }