fix-tests

Signed-off-by: parneet-guraya <gurayaparneet@gmail.com>
This commit is contained in:
parneet-guraya 2025-02-18 22:25:27 +05:30
parent 9b027b8b7c
commit bb0f2bcbd0
No known key found for this signature in database
GPG key ID: 63B807C4B2A9064B
2 changed files with 33 additions and 19 deletions

View file

@ -9,6 +9,7 @@ import fr.free.nrw.commons.mwapi.OkHttpJsonApiClient
import fr.free.nrw.commons.profile.achievements.FeedbackResponse import fr.free.nrw.commons.profile.achievements.FeedbackResponse
import fr.free.nrw.commons.profile.leaderboard.LeaderboardResponse import fr.free.nrw.commons.profile.leaderboard.LeaderboardResponse
import fr.free.nrw.commons.profile.leaderboard.UpdateAvatarResponse import fr.free.nrw.commons.profile.leaderboard.UpdateAvatarResponse
import fr.free.nrw.commons.utils.ConfigUtils
import fr.free.nrw.commons.utils.ViewUtilWrapper import fr.free.nrw.commons.utils.ViewUtilWrapper
import io.reactivex.Observable import io.reactivex.Observable
import io.reactivex.Single import io.reactivex.Single
@ -55,28 +56,38 @@ class ReasonBuilderTest {
@Test @Test
fun forceLoginWhenAccountIsNull() { fun forceLoginWhenAccountIsNull() {
PowerMockito.`when`(context?.getString(R.string.user_not_logged_in)) if (!ConfigUtils.isBetaFlavour) {
.thenReturn("Log-in expired. Please log in again.") PowerMockito.`when`(context?.getString(R.string.user_not_logged_in))
.thenReturn("Log-in expired. Please log in again.")
reasonBuilder!!.getReason(mock(Media::class.java), "test") reasonBuilder!!.getReason(mock(Media::class.java), "test")
verify(sessionManager, times(1))!!.forceLogin(any(Context::class.java)) verify(sessionManager, times(1))!!.forceLogin(any(Context::class.java))
}
} }
@Test @Test
fun getReason() { fun getReason() {
`when`(sessionManager?.userName).thenReturn("Testuser") if (!ConfigUtils.isBetaFlavour) {
`when`(sessionManager?.doesAccountExist()).thenReturn(true) `when`(sessionManager?.userName).thenReturn("Testuser")
`when`(okHttpJsonApiClient!!.getAchievements(anyString())) `when`(sessionManager?.doesAccountExist()).thenReturn(true)
.thenReturn(Single.just(mock(FeedbackResponse::class.java))) `when`(okHttpJsonApiClient!!.getAchievements(anyString()))
`when`(okHttpJsonApiClient!!.getLeaderboard(anyString(), anyString(), anyString(), anyString(), anyString())) .thenReturn(Single.just(mock(FeedbackResponse::class.java)))
.thenReturn(Observable.just(mock(LeaderboardResponse::class.java))) `when`(
`when`(okHttpJsonApiClient!!.setAvatar(anyString(), anyString())) okHttpJsonApiClient!!.getLeaderboard(
.thenReturn(Single.just(mock(UpdateAvatarResponse::class.java))) anyString(),
anyString(),
anyString(),
anyString(),
anyString()
)
)
.thenReturn(Observable.just(mock(LeaderboardResponse::class.java)))
`when`(okHttpJsonApiClient!!.setAvatar(anyString(), anyString()))
.thenReturn(Single.just(mock(UpdateAvatarResponse::class.java)))
val media = media(filename = "test_file", dateUploaded = Date()) val media = media(filename = "test_file", dateUploaded = Date())
reasonBuilder!!.getReason(media, "test")
reasonBuilder!!.getReason(media, "test") verify(sessionManager, times(0))!!.forceLogin(any(Context::class.java))
verify(sessionManager, times(0))!!.forceLogin(any(Context::class.java)) verify(okHttpJsonApiClient, times(1))!!.getAchievements(anyString())
verify(okHttpJsonApiClient, times(1))!!.getAchievements(anyString()) }
} }
} }

View file

@ -162,6 +162,9 @@ class MediaDetailFragmentUnitTests {
private lateinit var _binding: FragmentMediaDetailBinding private lateinit var _binding: FragmentMediaDetailBinding
@Mock
private lateinit var callback: MediaDetailFragment.Callback
@Before @Before
fun setUp() { fun setUp() {
MockitoAnnotations.openMocks(this) MockitoAnnotations.openMocks(this)
@ -789,7 +792,7 @@ class MediaDetailFragmentUnitTests {
@Test @Test
@Throws(Exception::class) @Throws(Exception::class)
fun testForMedia() { fun testForMedia() {
MediaDetailFragment.forMedia(0, true, true, true) MediaDetailFragment.forMedia(0, true, true, true, callback)
} }
@Test @Test