mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 12:53:55 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix extension replacement, add related tests

Browse source 
Makes sure findUniqueFilename receives filenames with an extension.
More robust extension replacement rules.
This commit is contained in:
Yusuke Matsubara 2016-08-16 07:39:38 +09:00
parent 1bdcf3fda0
commit b91c9776f6
5 changed files with 51 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

29
app/src/test/java/fr/free/nrw/commons/UtilsTest.java Normal file
View file

@ -0,0 +1,29 @@
package fr.free.nrw.commons;
import org.junit.Test;
import fr.free.nrw.commons.upload.UploadController;
import static org.junit.Assert.*;
public class UtilsTest {
@Test public void fixExtensionJpegToJpg() {
assertEquals("SampleFile.jpg", Utils.fixExtension("SampleFile.jpeg", "jpeg"));
}
@Test public void fixExtensionJpgToJpg() {
assertEquals("SampleFile.jpg", Utils.fixExtension("SampleFile.jpg", "jpg"));
}
@Test public void fixExtensionPngToPng() {
assertEquals("SampleFile.png", Utils.fixExtension("SampleFile.png", "png"));
}
@Test public void fixExtensionEmptyToJpg() {
assertEquals("SampleFile.jpg", Utils.fixExtension("SampleFile", "jpg"));
}
@Test public void fixExtensionJpgNotExtension() {
assertEquals("SampleFileJpg.jpg", Utils.fixExtension("SampleFileJpg", "jpg"));
}
}