From b8cdc5a5378ab7e4d2514abd8870dd36718917dc Mon Sep 17 00:00:00 2001 From: Pratham Pahariya <54663429+Pratham2305@users.noreply.github.com> Date: Fri, 19 Feb 2021 07:18:39 +0530 Subject: [PATCH] Fixes #4229 - App Crashes while trying to nominate an item for deletion, When User is not logged in (#4237) * Fixes the crash while nominating an item for deletion. * removed unnecessary code Co-authored-by: Pratham2305 --- .../fr/free/nrw/commons/media/MediaDetailFragment.java | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java b/app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java index 4c4c5cf67..c5d10f32e 100644 --- a/app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java +++ b/app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java @@ -61,6 +61,7 @@ import fr.free.nrw.commons.delete.DeleteHelper; import fr.free.nrw.commons.delete.ReasonBuilder; import fr.free.nrw.commons.explore.depictions.WikidataItemDetailsActivity; import fr.free.nrw.commons.di.CommonsDaggerSupportFragment; +import fr.free.nrw.commons.kvstore.JsonKvStore; import fr.free.nrw.commons.nearby.Label; import fr.free.nrw.commons.ui.widget.HtmlTextView; import fr.free.nrw.commons.utils.ViewUtilWrapper; @@ -74,6 +75,7 @@ import java.util.Locale; import java.util.concurrent.TimeUnit; import java.util.Map; import javax.inject.Inject; +import javax.inject.Named; import org.apache.commons.lang3.StringUtils; import org.wikipedia.util.DateUtil; import timber.log.Timber; @@ -117,6 +119,9 @@ public class MediaDetailFragment extends CommonsDaggerSupportFragment implements ViewUtilWrapper viewUtil; @Inject CategoryClient categoryClient; + @Inject + @Named("default_preferences") + JsonKvStore applicationKvStore; private int initialListTop = 0; @@ -258,6 +263,10 @@ public class MediaDetailFragment extends CommonsDaggerSupportFragment implements authorLayout.setVisibility(GONE); } + if(applicationKvStore.getBoolean("login_skipped")){ + delete.setVisibility(GONE); + } + return view; }