mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 04:43:54 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

rename toolbar name Favorites to Bookmarks (#4717)

Browse source 
* rename toolbar name Favorites to Bookmarks

* fix issue

* fix string.xml file
This commit is contained in:
Prince kushwaha 2021-12-10 18:05:44 +05:30 • committed by GitHub
parent 674b033d32
commit b7be49333d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 4 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/src/main/java/fr/free/nrw/commons/contributions/MainActivity.java
View file

@ -271,7 +271,7 @@ public class MainActivity extends BaseActivity
setTitle(getString(R.string.navigation_item_explore)); setTitle(getString(R.string.navigation_item_explore));
loadFragment(ExploreFragment.newInstance(),false); loadFragment(ExploreFragment.newInstance(),false);
}else if(fragmentName.equals(ActiveFragment.BOOKMARK.name())) { }else if(fragmentName.equals(ActiveFragment.BOOKMARK.name())) {
setTitle(getString(R.string.favorites)); setTitle(getString(R.string.bookmarks));
loadFragment(BookmarkFragment.newInstance(),false); loadFragment(BookmarkFragment.newInstance(),false);
} }
} }

3
app/src/main/java/fr/free/nrw/commons/navtab/NavTab.java
View file

@ -8,7 +8,6 @@ import androidx.fragment.app.Fragment;
import fr.free.nrw.commons.bookmarks.BookmarkFragment; import fr.free.nrw.commons.bookmarks.BookmarkFragment;
import fr.free.nrw.commons.contributions.ContributionsFragment; import fr.free.nrw.commons.contributions.ContributionsFragment;
import fr.free.nrw.commons.explore.ExploreFragment; import fr.free.nrw.commons.explore.ExploreFragment;
import fr.free.nrw.commons.explore.categories.search.SearchCategoryFragment;
import fr.free.nrw.commons.nearby.fragments.NearbyParentFragment; import fr.free.nrw.commons.nearby.fragments.NearbyParentFragment;
import org.wikipedia.model.EnumCode; import org.wikipedia.model.EnumCode;
import org.wikipedia.model.EnumCodeMap; import org.wikipedia.model.EnumCodeMap;
@ -38,7 +37,7 @@ public enum NavTab implements EnumCode {
return ExploreFragment.newInstance(); return ExploreFragment.newInstance();
} }
}, },
FAVORITES(R.string.favorites, R.drawable.ic_round_star_border_24px) { BOOKMARKS(R.string.bookmarks, R.drawable.ic_round_star_border_24px) {
@NonNull @NonNull
@Override @Override
public Fragment newInstance() { public Fragment newInstance() {

2
app/src/main/java/fr/free/nrw/commons/navtab/NavTabLoggedOut.java
View file

@ -20,7 +20,7 @@ public enum NavTabLoggedOut implements EnumCode {
return ExploreFragment.newInstance(); return ExploreFragment.newInstance();
} }
}, },
FAVORITES(R.string.favorites, R.drawable.ic_round_star_border_24px) { BOOKMARKS(R.string.bookmarks, R.drawable.ic_round_star_border_24px) {
@NonNull @NonNull
@Override @Override
public Fragment newInstance() { public Fragment newInstance() {

2
app/src/main/res/values/strings.xml
View file

@ -594,7 +594,7 @@ Upload your first media by tapping on the add button.</string>
<string name="resume">resume</string> <string name="resume">resume</string>
<string name="paused">Paused</string> <string name="paused">Paused</string>
<string name="more">More</string> <string name="more">More</string>
<string name="favorites">Favorites</string> <string name="bookmarks">Bookmarks</string>
<string name="achievements_tab_title">Achievements</string> <string name="achievements_tab_title">Achievements</string>
<string name="leaderboard_tab_title">Leaderboard</string> <string name="leaderboard_tab_title">Leaderboard</string>
<string name="rank_prefix">Rank:</string> <string name="rank_prefix">Rank:</string>