mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-26 12:23:58 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Remove an unused element from layout/fragment_media_detail.xml

Browse source 
I noticed this issue years ago because it used a hard to understand
string that needed better documentation (see #688). I forgot it,
but recently, I started to explore the app much more deeply and
came back to it.

It looks like this string is only used in this layout element,
but the element itself is not used anywhere. It usage apears to
have been removed in #634.
This commit is contained in:
Amir E. Aharoni 2025-10-15 12:56:29 -04:00
parent 2e52adbef8
commit b74495017e
3 changed files with 0 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

10
app/src/main/res/layout/fragment_media_detail.xml
View file

@ -24,16 +24,6 @@
layout="@layout/show_captions_descriptions" /> layout="@layout/show_captions_descriptions" />
</LinearLayout> </LinearLayout>
<ImageView
android:id="@+id/mediaDetailImageFailed"
android:layout_height="wrap_content"
android:layout_width="wrap_content"
android:layout_gravity="center"
android:src="@android:drawable/ic_menu_close_clear_cancel"
android:visibility="gone"
android:contentDescription="@string/mediaimage_failed"
/>
<com.facebook.drawee.view.SimpleDraweeView <com.facebook.drawee.view.SimpleDraweeView
android:id="@+id/mediaDetailImageView" android:id="@+id/mediaDetailImageView"
android:layout_width="wrap_content" android:layout_width="wrap_content"

1
app/src/main/res/values-qq/strings.xml
View file

@ -227,7 +227,6 @@
<string name="_2fa_code">Login form label.</string> <string name="_2fa_code">Login form label.</string>
<string name="email_auth_code">Login screen command.</string> <string name="email_auth_code">Login screen command.</string>
<string name="logout_verification">Confirmation string.</string> <string name="logout_verification">Confirmation string.</string>
<string name="mediaimage_failed">Alternative text.</string>
<string name="no_subcategory_found">Notice when searching for subcategories.</string> <string name="no_subcategory_found">Notice when searching for subcategories.</string>
<string name="no_parentcategory_found">Notice when searching for subcategories.</string> <string name="no_parentcategory_found">Notice when searching for subcategories.</string>
<string name="welcome_image_mount_zao">This is a mountain between Yamagata and Miyagi Prefectures in Japan, see [[d:Q167951]] for details.</string> <string name="welcome_image_mount_zao">This is a mountain between Yamagata and Miyagi Prefectures in Japan, see [[d:Q167951]] for details.</string>

1
app/src/main/res/values/strings.xml
View file

@ -226,7 +226,6 @@
<string name="_2fa_code">2FA Code</string> <string name="_2fa_code">2FA Code</string>
<string name="email_auth_code">Email verification code</string> <string name="email_auth_code">Email verification code</string>
<string name="logout_verification">Do you really want to logout?</string> <string name="logout_verification">Do you really want to logout?</string>
<string name="mediaimage_failed">Media Image Failed</string>
<string name="no_subcategory_found">No subcategories found</string> <string name="no_subcategory_found">No subcategories found</string>
<string name="no_parentcategory_found">No parent categories found</string> <string name="no_parentcategory_found">No parent categories found</string>
<string name="welcome_image_mount_zao">Mount Zao</string> <string name="welcome_image_mount_zao">Mount Zao</string>