mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 04:43:54 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Add 'view in browser' action to detail page

Browse source
This commit is contained in:
YuviPanda 2013-02-23 16:26:33 +05:30
parent 48b6e5cc53
commit b6400139ae
3 changed files with 15 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
commons/res/menu/fragment_image_detail.xml
View file

@ -6,5 +6,10 @@
android:icon="@android:drawable/ic_menu_share" android:icon="@android:drawable/ic_menu_share"
android:title="@string/menu_share" android:title="@string/menu_share"
/> />
<item android:id="@+id/menu_browser_current_image"
android:showAsAction="always"
android:icon="@android:drawable/ic_menu_view"
android:title="@string/menu_open_in_browser"
/>
</menu> </menu>

1
commons/res/values/strings.xml
View file

@ -35,6 +35,7 @@
<string name="provider_contributions">My uploads</string> <string name="provider_contributions">My uploads</string>
<string name="menu_share">Share</string> <string name="menu_share">Share</string>
<string name="menu_open_in_browser">View in Browser</string>
<plurals name="contributions_subtitle"> <plurals name="contributions_subtitle">
<item quantity="zero">No uploads yet</item> <item quantity="zero">No uploads yet</item>

11
commons/src/main/java/org/wikimedia/commons/media/MediaDetailPagerFragment.java
View file

@ -2,6 +2,7 @@ package org.wikimedia.commons.media;
import android.app.Activity; import android.app.Activity;
import android.content.Intent; import android.content.Intent;
import android.net.Uri;
import android.os.Bundle; import android.os.Bundle;
import android.support.v4.app.Fragment; import android.support.v4.app.Fragment;
import android.support.v4.app.FragmentManager; import android.support.v4.app.FragmentManager;
@ -62,16 +63,22 @@ public class MediaDetailPagerFragment extends SherlockFragment {
@Override @Override
public boolean onOptionsItemSelected(MenuItem item) { public boolean onOptionsItemSelected(MenuItem item) {
MediaDetailProvider provider = (MediaDetailProvider)getSherlockActivity();
Media m = provider.getItem(pager.getCurrentItem());
switch(item.getItemId()) { switch(item.getItemId()) {
case R.id.menu_share_current_image: case R.id.menu_share_current_image:
Intent shareIntent = new Intent(); Intent shareIntent = new Intent();
shareIntent.setAction(Intent.ACTION_SEND); shareIntent.setAction(Intent.ACTION_SEND);
shareIntent.setType("text/plain"); shareIntent.setType("text/plain");
MediaDetailProvider provider = (MediaDetailProvider)getSherlockActivity();
Media m = provider.getItem(pager.getCurrentItem());
shareIntent.putExtra(Intent.EXTRA_TEXT, m.getDisplayTitle() + " " + m.getDescriptionUrl()); shareIntent.putExtra(Intent.EXTRA_TEXT, m.getDisplayTitle() + " " + m.getDescriptionUrl());
startActivity(shareIntent); startActivity(shareIntent);
return true; return true;
case R.id.menu_browser_current_image:
Intent viewIntent = new Intent();
viewIntent.setAction(Intent.ACTION_VIEW);
viewIntent.setData(Uri.parse(m.getDescriptionUrl()));
startActivity(viewIntent);
return true;
default: default:
return super.onOptionsItemSelected(item); return super.onOptionsItemSelected(item);
} }