mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-28 21:33:53 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Return early if contributionsClient == null

Browse source
This commit is contained in:
misaochan 2018-01-31 23:18:28 +10:00
parent c80d106636
commit b42340b03a
1 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
app/src/main/java/fr/free/nrw/commons/modifications/ModificationsSyncAdapter.java
View file

@ -92,10 +92,13 @@ public class ModificationsSyncAdapter extends AbstractThreadedSyncAdapter {
while (!allModifications.isAfterLast()) { while (!allModifications.isAfterLast()) {
ModifierSequence sequence = modifierSequenceDao.fromCursor(allModifications); ModifierSequence sequence = modifierSequenceDao.fromCursor(allModifications);
Contribution contrib; Contribution contrib;
Cursor contributionCursor; Cursor contributionCursor;
if (contributionsClient == null) {
return;
}
try { try {
//TODO: How do we prevent this NPE?
contributionCursor = contributionsClient.query(sequence.getMediaUri(), null, null, null, null); contributionCursor = contributionsClient.query(sequence.getMediaUri(), null, null, null, null);
} catch (RemoteException e) { } catch (RemoteException e) {
throw new RuntimeException(e); throw new RuntimeException(e);