mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-26 20:33:53 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Remove unnecessary Integer.toString() calls (#2959)

Browse source 
In cases where an integer is directly concatenated onto a string, toString() is not needed because it is called implicitly; this patch removes the calls to improve code readability.
This commit is contained in:
Dan Garry 2019-05-19 14:24:53 +02:00 • committed by Josephine Lim
parent 877c669297
commit b176515153
2 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/src/main/java/fr/free/nrw/commons/achievements/AchievementsActivity.java
View file

@ -356,7 +356,7 @@ public class AchievementsActivity extends NavigationBaseActivity {
(achievements.getUniqueUsedImages() + "/" + levelInfo.getMaxUniqueImages());
imagesFeatured.setText(String.valueOf(achievements.getFeaturedImages()));
String levelUpInfoString = getString(R.string.level);
levelUpInfoString += " " + Integer.toString(levelInfo.getLevelNumber());
levelUpInfoString += " " + levelInfo.getLevelNumber();
levelNumber.setText(levelUpInfoString);
imageView.setImageDrawable(VectorDrawableCompat.create(getResources(), R.drawable.badge,
new ContextThemeWrapper(this, levelInfo.getLevelStyle()).getTheme()));

8
app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.java
View file

@ -516,10 +516,10 @@ public class UploadActivity extends BaseActivity implements UploadView, SimilarI
int descCount = directKvStore.getInt(name + "descCount");
for (int i = 0; i < descCount; i++) {
Description description= new Description();
String desc = directKvStore.getString(name + "description_<"+Integer.toString(i)+">");
String desc = directKvStore.getString(name + "description_<" + i + ">");
description.setDescriptionText(desc);
finalDesc.add(description);
int position = directKvStore.getInt(name + "spinnerPosition_<"+Integer.toString(i)+">");
int position = directKvStore.getInt(name + "spinnerPosition_<" + i + ">");
description.setSelectedLanguageIndex(position);
}
prevTitleDecs.setOnTouchListener((v, event) -> {
@ -744,8 +744,8 @@ public class UploadActivity extends BaseActivity implements UploadView, SimilarI
int n = descriptionsAdapter.getItemCount() - 1;
directKvStore.putInt(name + "descCount", n);
for (int i = 0; i < n; i++) {
directKvStore.putString(name + "description_<"+Integer.toString(i)+">", descriptionsAdapter.getDescriptions().get(i).getDescriptionText());
directKvStore.putInt(name + "spinnerPosition_<" + Integer.toString(i) + ">", descriptionsAdapter.getDescriptions().get(i).getSelectedLanguageIndex());
directKvStore.putString(name + "description_<" + i + ">", descriptionsAdapter.getDescriptions().get(i).getDescriptionText());
directKvStore.putInt(name + "spinnerPosition_<" + i + ">", descriptionsAdapter.getDescriptions().get(i).getSelectedLanguageIndex());
}
}
}