From b048e099c09e584323b684051d5993603ec6e3c2 Mon Sep 17 00:00:00 2001 From: Arman Navodia <77919824+ArmanNavodia@users.noreply.github.com> Date: Fri, 10 Mar 2023 08:07:18 +0530 Subject: [PATCH] fixed: When the coordinates have been copied from another picture, explain it in description #4700 (#5166) Very useful contribution, thanks Arman! --- .../upload/mediaDetails/UploadMediaDetailFragment.java | 7 +++++++ app/src/main/res/values/strings.xml | 1 + 2 files changed, 8 insertions(+) diff --git a/app/src/main/java/fr/free/nrw/commons/upload/mediaDetails/UploadMediaDetailFragment.java b/app/src/main/java/fr/free/nrw/commons/upload/mediaDetails/UploadMediaDetailFragment.java index 534ca61ee..4496bd0ad 100644 --- a/app/src/main/java/fr/free/nrw/commons/upload/mediaDetails/UploadMediaDetailFragment.java +++ b/app/src/main/java/fr/free/nrw/commons/upload/mediaDetails/UploadMediaDetailFragment.java @@ -246,6 +246,13 @@ public class UploadMediaDetailFragment extends UploadBaseFragment implements public void onPositiveResponse() { Timber.d("positive response from similar image fragment"); presenter.useSimilarPictureCoordinates(similarImageCoordinates, callback.getIndexInViewFlipper(UploadMediaDetailFragment.this)); + + // set the description text when user selects to use coordinate from the other image + // which was taken within 20s + // fixing: https://github.com/commons-app/apps-android-commons/issues/4700 + uploadMediaDetailAdapter.getItems().get(0).setDescriptionText( + getString(R.string.similar_coordinate_description_auto_set)); + updateMediaDetails(uploadMediaDetailAdapter.getItems()); } @Override diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index c1e9b5eb8..5e0809c2f 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -750,4 +750,5 @@ Upload your first media by tapping on the add button. Use two fingers to zoom in and out. Swipe fast and long to perform these actions: \n- Left/Right: Go to previous/next \n- Up: Select\n- Down: Mark as not for upload. To set up your leaderboard avatar, tap \"Set as avatar\" in the three-dots menu of any image. + The coordinates are not the exact coordinates, but the person who uploaded this picture thinks they are close enough.