mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-26 12:23:58 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fixes #3705 (Crash when viewing pic I just uploaded) (#3782)

Browse source 
* Fixes #3705
* Let the MediaDetailPager fragment know when the contributions have been updated

* Handle NPE, null check on adapter in MediaDetailPagerFragment
This commit is contained in:
Ashish Kumar 2020-06-02 22:49:38 +05:30 • committed by GitHub
parent d950f72193
commit ac3e5158be
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 14 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
app/src/main/java/fr/free/nrw/commons/contributions/ContributionsFragment.java
View file

@ -224,6 +224,14 @@ public class ContributionsFragment
Timber.d("Fetching thumbnail for %s", contribution.filename);
contributionsPresenter.fetchMediaDetails(contribution);
}
@Override
public void onContributionsUpdated() {
//If the contributions are updated, let the pager fragment know
if (null != mediaDetailPagerFragment) {
mediaDetailPagerFragment.notifyDataSetChanged();
}
}
});
if(null==mediaDetailPagerFragment){

2
app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListAdapter.java
View file

@ -77,5 +77,7 @@ public class ContributionsListAdapter extends RecyclerView.Adapter<ContributionV
Contribution getContributionForPosition(int position);
void fetchMediaUriFor(Contribution contribution);
void onContributionsUpdated();
}
}

1
app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListFragment.java
View file

@ -188,6 +188,7 @@ public class ContributionsListFragment extends CommonsDaggerSupportFragment {
this.contributions.clear();
this.contributions.addAll(contributionList);
adapter.setContributions(contributions);
callback.onContributionsUpdated();
}
public interface SourceRefresher {

4
app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.java
View file

@ -320,7 +320,9 @@ public class MediaDetailPagerFragment extends CommonsDaggerSupportFragment imple
* The method notify the viewpager that number of items have changed.
*/
public void notifyDataSetChanged(){
adapter.notifyDataSetChanged();
if (null != adapter) {
adapter.notifyDataSetChanged();
}
}
@Override