From aa479dc9b404832072039e7d781f937ad67990f9 Mon Sep 17 00:00:00 2001 From: Yusuke Matsubara Date: Sat, 19 May 2018 17:30:07 +0200 Subject: [PATCH] [WIP] add on-click actions to ReviewActivity --- .../free/nrw/commons/mwapi/ApacheHttpClientMediaWikiApi.java | 1 - .../main/java/fr/free/nrw/commons/review/ReviewActivity.java | 4 ++-- .../java/fr/free/nrw/commons/review/ReviewImageFragment.java | 2 ++ app/src/main/res/values/strings.xml | 3 ++- 4 files changed, 6 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/fr/free/nrw/commons/mwapi/ApacheHttpClientMediaWikiApi.java b/app/src/main/java/fr/free/nrw/commons/mwapi/ApacheHttpClientMediaWikiApi.java index 3f85fe687..37a4314d2 100644 --- a/app/src/main/java/fr/free/nrw/commons/mwapi/ApacheHttpClientMediaWikiApi.java +++ b/app/src/main/java/fr/free/nrw/commons/mwapi/ApacheHttpClientMediaWikiApi.java @@ -1133,7 +1133,6 @@ public class ApacheHttpClientMediaWikiApi implements MediaWikiApi { // strip File: prefix imageTitle = imageTitle.replace("File:", ""); media = new Media(imageTitle); - //media = fetchMediaByFilename(fileName); } } } diff --git a/app/src/main/java/fr/free/nrw/commons/review/ReviewActivity.java b/app/src/main/java/fr/free/nrw/commons/review/ReviewActivity.java index 420a31eab..b87cc132e 100644 --- a/app/src/main/java/fr/free/nrw/commons/review/ReviewActivity.java +++ b/app/src/main/java/fr/free/nrw/commons/review/ReviewActivity.java @@ -1,5 +1,6 @@ package fr.free.nrw.commons.review; +import android.app.AlertDialog; import android.content.Context; import android.content.Intent; import android.os.Bundle; @@ -14,6 +15,7 @@ import android.util.Log; import android.view.Menu; import android.view.MenuItem; import android.view.View; +import android.widget.EditText; import com.viewpagerindicator.CirclePageIndicator; @@ -28,7 +30,6 @@ import fr.free.nrw.commons.Media; import fr.free.nrw.commons.R; import fr.free.nrw.commons.Utils; import fr.free.nrw.commons.auth.AuthenticatedActivity; -import fr.free.nrw.commons.mwapi.MediaResult; import fr.free.nrw.commons.mwapi.MediaWikiApi; import io.reactivex.Observable; import io.reactivex.android.schedulers.AndroidSchedulers; @@ -67,7 +68,6 @@ public class ReviewActivity extends AuthenticatedActivity { @Override protected void onAuthFailure() { - } @Override diff --git a/app/src/main/java/fr/free/nrw/commons/review/ReviewImageFragment.java b/app/src/main/java/fr/free/nrw/commons/review/ReviewImageFragment.java index 86df7bf2f..c2d98681f 100644 --- a/app/src/main/java/fr/free/nrw/commons/review/ReviewImageFragment.java +++ b/app/src/main/java/fr/free/nrw/commons/review/ReviewImageFragment.java @@ -1,9 +1,11 @@ package fr.free.nrw.commons.review; +import android.app.AlertDialog; import android.os.Bundle; import android.view.LayoutInflater; import android.view.View; import android.view.ViewGroup; +import android.widget.EditText; import android.widget.TextView; import com.facebook.drawee.view.SimpleDraweeView; diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index a20aa1930..435906ff3 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -462,12 +462,13 @@ Upload your first media by touching the camera or gallery icon above. Requesting category check: Failed Successfully requested category check for %1$s Could not request category check for %1$s - Requesting category check for %1%s + Requesting category check for %1$s Adding delete message to file Done Notifying User on Talk page Adding file to Delete requests log Creating Delete requests subpage + Not sure Is this a copyright violation? Is this mis-categorized?