From e1a7d807167cdbf634fcca3aaa626fe953ee95b2 Mon Sep 17 00:00:00 2001
From: veyndan <veyndan89@gmail.com>
Date: Fri, 3 Mar 2017 18:01:31 +0000
Subject: [PATCH 1/3] Use compound drawable for logo

---
 app/src/main/res/layout/activity_login.xml | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/app/src/main/res/layout/activity_login.xml b/app/src/main/res/layout/activity_login.xml
index 91a9f6fe6..31a524edb 100644
--- a/app/src/main/res/layout/activity_login.xml
+++ b/app/src/main/res/layout/activity_login.xml
@@ -12,21 +12,16 @@
         android:orientation="vertical"
         >
 
-        <ImageView
-            android:id="@+id/commonsLogo"
-            android:layout_width="wrap_content"
-            android:layout_height="wrap_content"
-            android:layout_marginTop="16dp"
-            android:src="@drawable/commons_logo_large"
-            />
-
         <TextView
             android:id="@+id/loginSubtitle"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
-            android:layout_marginTop="8dp"
+            android:layout_marginTop="16dp"
             android:text="@string/app_name"
             android:textAppearance="?android:attr/textAppearanceMedium"
+            android:drawableTop="@drawable/commons_logo_large"
+            android:gravity="center_horizontal"
+            android:drawablePadding="8dp"
             />
 
         <LinearLayout

From 86ab65c15f0c64503521d97e3d63b71853a5f42d Mon Sep 17 00:00:00 2001
From: veyndan <veyndan89@gmail.com>
Date: Fri, 3 Mar 2017 18:03:00 +0000
Subject: [PATCH 2/3] Remove redundant LinearLayout

---
 app/src/main/res/layout/activity_login.xml | 105 ++++++++++-----------
 1 file changed, 48 insertions(+), 57 deletions(-)

diff --git a/app/src/main/res/layout/activity_login.xml b/app/src/main/res/layout/activity_login.xml
index 31a524edb..33e928621 100644
--- a/app/src/main/res/layout/activity_login.xml
+++ b/app/src/main/res/layout/activity_login.xml
@@ -8,6 +8,7 @@
         android:layout_width="match_parent"
         android:layout_height="match_parent"
         android:layout_gravity="center"
+        android:layout_margin="16dp"
         android:gravity="center"
         android:orientation="vertical"
         >
@@ -16,82 +17,72 @@
             android:id="@+id/loginSubtitle"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
-            android:layout_marginTop="16dp"
-            android:text="@string/app_name"
-            android:textAppearance="?android:attr/textAppearanceMedium"
+            android:drawablePadding="8dp"
             android:drawableTop="@drawable/commons_logo_large"
             android:gravity="center_horizontal"
-            android:drawablePadding="8dp"
+            android:text="@string/app_name"
+            android:textAppearance="?android:attr/textAppearanceMedium"
             />
 
-        <LinearLayout
+        <FrameLayout
+            android:id="@+id/loginErrors"
             android:layout_width="match_parent"
-            android:layout_height="match_parent"
-            android:layout_margin="16dip"
-            android:gravity="center"
-            android:orientation="vertical"
+            android:layout_height="48dp"
+            />
+
+        <android.support.design.widget.TextInputLayout
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
             >
 
-            <FrameLayout
-                android:id="@+id/loginErrors"
-                android:layout_width="match_parent"
-                android:layout_height="48dp"
-                />
-
-            <android.support.design.widget.TextInputLayout
+            <android.support.design.widget.TextInputEditText
+                android:id="@+id/loginUsername"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
+                android:hint="@string/username"
+                android:imeOptions="flagNoExtractUi"
+                android:inputType="textNoSuggestions"
                 >
 
-                <android.support.design.widget.TextInputEditText
-                    android:id="@+id/loginUsername"
-                    android:layout_width="match_parent"
-                    android:layout_height="wrap_content"
-                    android:hint="@string/username"
-                    android:imeOptions="flagNoExtractUi"
-                    android:inputType="textNoSuggestions"
-                    >
+                <requestFocus/>
 
-                    <requestFocus/>
+            </android.support.design.widget.TextInputEditText>
 
-                </android.support.design.widget.TextInputEditText>
+        </android.support.design.widget.TextInputLayout>
 
-            </android.support.design.widget.TextInputLayout>
+        <android.support.design.widget.TextInputLayout
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
+            app:passwordToggleEnabled="false"
+            >
 
-            <android.support.design.widget.TextInputLayout
+            <android.support.design.widget.TextInputEditText
+                android:id="@+id/loginPassword"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
-                app:passwordToggleEnabled="false"
-                >
-
-                <android.support.design.widget.TextInputEditText
-                    android:id="@+id/loginPassword"
-                    android:layout_width="match_parent"
-                    android:layout_height="wrap_content"
-                    android:hint="@string/password"
-                    android:imeOptions="flagNoExtractUi"
-                    android:inputType="textPassword"
-                    />
-
-            </android.support.design.widget.TextInputLayout>
-
-            <Button
-                android:id="@+id/loginButton"
-                android:layout_width="match_parent"
-                android:layout_height="wrap_content"
-                android:enabled="false"
-                android:text="@string/login"
+                android:hint="@string/password"
+                android:imeOptions="flagNoExtractUi"
+                android:inputType="textPassword"
                 />
 
-            <Button
-                android:id="@+id/signupButton"
-                android:layout_width="match_parent"
-                android:layout_height="wrap_content"
-                android:text="@string/signup"
-                android:layout_gravity="center_horizontal"
-                android:onClick="signUp"
-                />
+        </android.support.design.widget.TextInputLayout>
+
+        <Button
+            android:id="@+id/loginButton"
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
+            android:enabled="false"
+            android:text="@string/login"
+            />
+
+        <Button
+            android:id="@+id/signupButton"
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
+            android:layout_gravity="center_horizontal"
+            android:onClick="signUp"
+            android:text="@string/signup"
+            />
 
-        </LinearLayout>
     </LinearLayout>
 </ScrollView>

From d7d025e1696815e88e2987b8fe60e8135e788c60 Mon Sep 17 00:00:00 2001
From: veyndan <veyndan89@gmail.com>
Date: Fri, 3 Mar 2017 18:07:49 +0000
Subject: [PATCH 3/3] Remove redundant FrameLayout

---
 app/src/main/res/layout/activity_login.xml | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/app/src/main/res/layout/activity_login.xml b/app/src/main/res/layout/activity_login.xml
index 33e928621..5f3837f85 100644
--- a/app/src/main/res/layout/activity_login.xml
+++ b/app/src/main/res/layout/activity_login.xml
@@ -17,6 +17,7 @@
             android:id="@+id/loginSubtitle"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
+            android:layout_marginBottom="48dp"
             android:drawablePadding="8dp"
             android:drawableTop="@drawable/commons_logo_large"
             android:gravity="center_horizontal"
@@ -24,12 +25,6 @@
             android:textAppearance="?android:attr/textAppearanceMedium"
             />
 
-        <FrameLayout
-            android:id="@+id/loginErrors"
-            android:layout_width="match_parent"
-            android:layout_height="48dp"
-            />
-
         <android.support.design.widget.TextInputLayout
             android:layout_width="match_parent"
             android:layout_height="wrap_content"