From a47715a86f5b4a4d723d1ebfe26f5566d81f0d46 Mon Sep 17 00:00:00 2001
From: "Amir E. Aharoni" <amir.aharoni@mail.huji.ac.il>
Date: Thu, 16 Oct 2025 14:19:04 -0400
Subject: [PATCH] Fix lint warning about Timber

Change trivial string formatting and function calls
for Timber logging.

This resolves all the lint warnings in the
Android/Lint/Correctness/Messages group.
---
 .../java/fr/free/nrw/commons/contributions/MainActivity.kt     | 2 +-
 .../main/java/fr/free/nrw/commons/profile/ProfileActivity.kt   | 3 ++-
 app/src/main/java/fr/free/nrw/commons/utils/LocationUtils.kt   | 2 +-
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/app/src/main/java/fr/free/nrw/commons/contributions/MainActivity.kt b/app/src/main/java/fr/free/nrw/commons/contributions/MainActivity.kt
index ac7068cc7..d481017b2 100644
--- a/app/src/main/java/fr/free/nrw/commons/contributions/MainActivity.kt
+++ b/app/src/main/java/fr/free/nrw/commons/contributions/MainActivity.kt
@@ -324,7 +324,7 @@ after opening the app.
         )
             .subscribeOn(Schedulers.io())
             .blockingGet()
-        Timber.d("Resuming " + stuckUploads.size + " uploads...")
+        Timber.d("Resuming %d uploads...", stuckUploads.size)
         if (!stuckUploads.isEmpty()) {
             for (contribution in stuckUploads) {
                 contribution.state = Contribution.STATE_QUEUED
diff --git a/app/src/main/java/fr/free/nrw/commons/profile/ProfileActivity.kt b/app/src/main/java/fr/free/nrw/commons/profile/ProfileActivity.kt
index c368d6cd4..8567d37ae 100644
--- a/app/src/main/java/fr/free/nrw/commons/profile/ProfileActivity.kt
+++ b/app/src/main/java/fr/free/nrw/commons/profile/ProfileActivity.kt
@@ -27,6 +27,7 @@ import java.io.File
 import java.io.FileOutputStream
 import java.util.Locale
 import javax.inject.Inject
+import timber.log.Timber
 
 /**
  * This activity will set two tabs, achievements and
@@ -122,7 +123,7 @@ class ProfileActivity : BaseActivity() {
                 val rootView = window.decorView.findViewById<View>(android.R.id.content)
                 val screenShot = getScreenShot(rootView)
                 if (screenShot == null) {
-                    Log.e("ERROR", "ScreenShot is null")
+                    Timber.e("ScreenShot is null")
                     return false
                 }
                 showAlert(screenShot)
diff --git a/app/src/main/java/fr/free/nrw/commons/utils/LocationUtils.kt b/app/src/main/java/fr/free/nrw/commons/utils/LocationUtils.kt
index 1fbd87581..cef137f43 100644
--- a/app/src/main/java/fr/free/nrw/commons/utils/LocationUtils.kt
+++ b/app/src/main/java/fr/free/nrw/commons/utils/LocationUtils.kt
@@ -37,7 +37,7 @@ object LocationUtils {
             latLng = LatLng(latLngArray[1].trim().toDouble(),
                 latLngArray[0].trim().toDouble(), 1f)
         } catch (e: Exception) {
-            Timber.e("Error while parsing user entered lat long: %s", e)
+            Timber.e(e, "Error while parsing user entered lat long")
         }
 
         return latLng