From a3ca75db2510da08b855374a474573ba1fe3111a Mon Sep 17 00:00:00 2001
From: Neel Doshi <neeldoshi147@gmail.com>
Date: Mon, 2 Dec 2024 01:09:34 +0530
Subject: [PATCH] Removed Redundant XML Code & Converted badges to green color
 and added values inside it

---
 .../main/res/layout/fragment_achievements.xml | 328 +++++-------------
 1 file changed, 81 insertions(+), 247 deletions(-)

diff --git a/app/src/main/res/layout/fragment_achievements.xml b/app/src/main/res/layout/fragment_achievements.xml
index ab8afe6a1..00c18b323 100644
--- a/app/src/main/res/layout/fragment_achievements.xml
+++ b/app/src/main/res/layout/fragment_achievements.xml
@@ -104,30 +104,37 @@
       app:tint="@color/black" />
 
     <!--  Image's Uploaded Progress Bar  -->
-    <ProgressBar
-      android:id="@+id/images_uploaded_progressbar"
-      style="?android:attr/progressBarStyleHorizontal"
-      android:layout_width="0dp"
+    <RelativeLayout
+      android:id="@+id/rl_images_Uploaded"
+      android:layout_width="match_parent"
       android:layout_height="wrap_content"
       android:layout_marginStart="@dimen/activity_margin_horizontal"
-      android:layout_marginTop="@dimen/activity_margin_horizontal"
       android:layout_marginEnd="@dimen/activity_margin_horizontal"
-      android:progressDrawable="@android:drawable/progress_horizontal"
-      app:layout_constraintEnd_toStartOf="@+id/imageUploadedTVCount"
-      app:layout_constraintStart_toStartOf="parent"
-      app:layout_constraintTop_toBottomOf="@+id/images_upload_text_param"
-      tools:progress="50" />
-
-    <TextView
-      android:id="@+id/imageUploadedTVCount"
-      style="?android:textAppearanceMedium"
-      android:layout_width="wrap_content"
-      android:layout_height="wrap_content"
-      android:layout_marginEnd="@dimen/activity_margin_horizontal"
-      app:layout_constraintBottom_toBottomOf="@+id/images_uploaded_progressbar"
       app:layout_constraintEnd_toEndOf="parent"
-      app:layout_constraintTop_toTopOf="@+id/images_uploaded_progressbar"
-      tools:text="10/15" />
+      app:layout_constraintStart_toStartOf="parent"
+      app:layout_constraintTop_toBottomOf="@+id/images_upload_text_param">
+
+      <ProgressBar
+        android:id="@+id/images_uploaded_progressbar"
+        style="?android:attr/progressBarStyleHorizontal"
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:layout_centerInParent="true"
+        android:progressDrawable="@android:drawable/progress_horizontal"
+        android:progressBackgroundTintMode="multiply"
+        android:progressTint="#5ce65c"
+        tools:progress="50" />
+
+      <TextView
+        android:id="@+id/imageUploadedTVCount"
+        style="?android:textAppearanceMedium"
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        android:layout_centerInParent="true"
+        android:layout_marginEnd="@dimen/activity_margin_horizontal"
+        tools:text="10/15" />
+
+    </RelativeLayout>
 
     <com.google.android.material.divider.MaterialDivider
       android:id="@+id/materialDivider"
@@ -138,7 +145,7 @@
       android:layout_marginEnd="@dimen/activity_margin_horizontal"
       app:layout_constraintEnd_toEndOf="parent"
       app:layout_constraintStart_toStartOf="parent"
-      app:layout_constraintTop_toBottomOf="@+id/images_uploaded_progressbar" />
+      app:layout_constraintTop_toBottomOf="@+id/rl_images_Uploaded" />
 
 
     <!-- Image's Not Reverted -->
@@ -178,30 +185,36 @@
       app:tint="@color/black" />
 
     <!--  Image's Not Reverted Progress Bar  -->
-    <ProgressBar
-      android:id="@+id/image_reverts_progressbar"
-      style="?android:attr/progressBarStyleHorizontal"
-      android:layout_width="0dp"
+    <RelativeLayout
+      android:id="@+id/rl_images_reverted"
+      android:layout_width="match_parent"
       android:layout_height="wrap_content"
       android:layout_marginStart="@dimen/activity_margin_horizontal"
-      android:layout_marginTop="@dimen/activity_margin_horizontal"
       android:layout_marginEnd="@dimen/activity_margin_horizontal"
-      android:progressDrawable="@android:drawable/progress_horizontal"
-      app:layout_constraintEnd_toStartOf="@+id/imageUploadedTVCount"
-      app:layout_constraintStart_toStartOf="parent"
-      app:layout_constraintTop_toBottomOf="@+id/images_reverted_text"
-      tools:progress="50" />
-
-    <TextView
-      android:id="@+id/imageRevertTVCount"
-      style="?android:textAppearanceMedium"
-      android:layout_width="wrap_content"
-      android:layout_height="wrap_content"
-      android:layout_marginEnd="@dimen/activity_margin_horizontal"
-      app:layout_constraintBottom_toBottomOf="@+id/image_reverts_progressbar"
       app:layout_constraintEnd_toEndOf="parent"
-      app:layout_constraintTop_toTopOf="@+id/image_reverts_progressbar"
-      tools:text="10/15" />
+      app:layout_constraintStart_toStartOf="parent"
+      app:layout_constraintTop_toBottomOf="@+id/images_reverted_text">
+
+      <ProgressBar
+        android:id="@+id/image_reverts_progressbar"
+        style="?android:attr/progressBarStyleHorizontal"
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:layout_centerInParent="true"
+        android:progressDrawable="@android:drawable/progress_horizontal"
+        android:progressBackgroundTintMode="multiply"
+        android:progressTint="#5ce65c"
+        tools:progress="50" />
+
+      <TextView
+        android:id="@+id/imageRevertTVCount"
+        style="?android:textAppearanceMedium"
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        android:layout_centerInParent="true"
+        tools:text="10/15" />
+    </RelativeLayout>
+
 
     <com.google.android.material.divider.MaterialDivider
       android:id="@+id/materialDivider1"
@@ -212,7 +225,7 @@
       android:layout_marginEnd="@dimen/activity_margin_horizontal"
       app:layout_constraintEnd_toEndOf="parent"
       app:layout_constraintStart_toStartOf="parent"
-      app:layout_constraintTop_toBottomOf="@+id/image_reverts_progressbar" />
+      app:layout_constraintTop_toBottomOf="@+id/rl_images_reverted" />
 
     <!-- Image Used -->
     <TextView
@@ -239,31 +252,35 @@
       app:tint="@color/black" />
 
     <!--  Image's Used Progress Bar  -->
-
-    <ProgressBar
-      android:id="@+id/images_used_by_wiki_progress_bar"
-      style="?android:attr/progressBarStyleHorizontal"
-      android:layout_width="0dp"
+    <RelativeLayout
+      android:id="@+id/rl_images_used"
+      android:layout_width="match_parent"
       android:layout_height="wrap_content"
       android:layout_marginStart="@dimen/activity_margin_horizontal"
-      android:layout_marginTop="@dimen/activity_margin_horizontal"
       android:layout_marginEnd="@dimen/activity_margin_horizontal"
-      android:progressDrawable="@android:drawable/progress_horizontal"
-      app:layout_constraintEnd_toStartOf="@+id/imagesUsedCount"
-      app:layout_constraintStart_toStartOf="parent"
-      app:layout_constraintTop_toBottomOf="@+id/images_used_tv"
-      tools:progress="50" />
-
-    <TextView
-      android:id="@+id/imagesUsedCount"
-      style="?android:textAppearanceMedium"
-      android:layout_width="wrap_content"
-      android:layout_height="wrap_content"
-      android:layout_marginEnd="@dimen/activity_margin_horizontal"
-      app:layout_constraintBottom_toBottomOf="@+id/images_used_by_wiki_progress_bar"
       app:layout_constraintEnd_toEndOf="parent"
-      app:layout_constraintTop_toTopOf="@+id/images_used_by_wiki_progress_bar"
-      tools:text="10/15" />
+      app:layout_constraintStart_toStartOf="parent"
+      app:layout_constraintTop_toBottomOf="@+id/images_used_tv">
+
+      <ProgressBar
+        android:id="@+id/images_used_by_wiki_progress_bar"
+        style="?android:attr/progressBarStyleHorizontal"
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:layout_centerInParent="true"
+        android:progressDrawable="@android:drawable/progress_horizontal"
+        android:progressBackgroundTintMode="multiply"
+        android:progressTint="#5ce65c"
+        tools:progress="50" />
+
+      <TextView
+        android:id="@+id/imagesUsedCount"
+        style="?android:textAppearanceMedium"
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        android:layout_centerInParent="true"
+        tools:text="10/15" />
+    </RelativeLayout>
 
     <com.google.android.material.divider.MaterialDivider
       android:id="@+id/materialDivider2"
@@ -274,7 +291,7 @@
       android:layout_marginEnd="@dimen/activity_margin_horizontal"
       app:layout_constraintEnd_toEndOf="parent"
       app:layout_constraintStart_toStartOf="parent"
-      app:layout_constraintTop_toBottomOf="@+id/images_used_by_wiki_progress_bar" />
+      app:layout_constraintTop_toBottomOf="@+id/rl_images_used" />
 
     <!-- Statistics -->
     <TextView
@@ -290,95 +307,6 @@
       app:layout_constraintStart_toStartOf="parent"
       app:layout_constraintTop_toBottomOf="@+id/materialDivider2" />
 
-
-    <!--    <TextView-->
-<!--      android:id="@+id/images_nearby_data"-->
-<!--      style="?android:textAppearanceMedium"-->
-<!--      android:layout_width="0dp"-->
-<!--      android:layout_height="wrap_content"-->
-<!--      android:layout_marginStart="16dp"-->
-<!--      android:layout_marginEnd="16dp"-->
-<!--      android:text="@string/statistics_wikidata_edits"-->
-<!--      app:layout_constraintBottom_toBottomOf="@+id/wikidata_edits_icon"-->
-<!--      app:layout_constraintEnd_toStartOf="@+id/images_nearby_info_icon"-->
-<!--      app:layout_constraintStart_toEndOf="@+id/wikidata_edits_icon"-->
-<!--      app:layout_constraintTop_toTopOf="@+id/wikidata_edits_icon" />-->
-
-<!--    <ImageView-->
-<!--      android:id="@+id/images_nearby_info_icon"-->
-<!--      android:layout_width="wrap_content"-->
-<!--      android:layout_height="wrap_content"-->
-<!--      android:layout_marginEnd="16dp"-->
-<!--      app:layout_constraintBottom_toBottomOf="@+id/images_nearby_data"-->
-<!--      app:layout_constraintEnd_toStartOf="@+id/wikidata_edits"-->
-<!--      app:layout_constraintTop_toTopOf="@+id/images_nearby_data"-->
-<!--      app:srcCompat="@drawable/ic_info_outline_24dp"-->
-<!--      app:tint="@color/black" />-->
-
-<!--    <TextView-->
-<!--      android:id="@+id/wikidata_edits"-->
-<!--      style="?android:textAppearanceMedium"-->
-<!--      android:layout_width="wrap_content"-->
-<!--      android:layout_height="wrap_content"-->
-<!--      android:layout_marginEnd="@dimen/activity_margin_horizontal"-->
-<!--      app:layout_constraintBottom_toBottomOf="@+id/images_nearby_info_icon"-->
-<!--      app:layout_constraintEnd_toEndOf="parent"-->
-<!--      app:layout_constraintTop_toTopOf="@+id/images_nearby_info_icon"-->
-<!--      tools:text="2" />-->
-
-<!--    <com.google.android.material.divider.MaterialDivider-->
-<!--      android:id="@+id/materialDivider3"-->
-<!--      android:layout_width="match_parent"-->
-<!--      android:layout_height="wrap_content"-->
-<!--      android:layout_marginStart="@dimen/activity_margin_horizontal"-->
-<!--      android:layout_marginTop="@dimen/activity_margin_horizontal"-->
-<!--      android:layout_marginEnd="@dimen/activity_margin_horizontal"-->
-<!--      app:layout_constraintEnd_toEndOf="parent"-->
-<!--      app:layout_constraintStart_toStartOf="parent"-->
-<!--      app:layout_constraintTop_toBottomOf="@+id/wikidata_edits_icon" />-->
-
-
-
-
-<!--    <TextView-->
-<!--      android:id="@+id/images_featured_data"-->
-<!--      style="?android:textAppearanceMedium"-->
-<!--      android:layout_width="0dp"-->
-<!--      android:layout_height="wrap_content"-->
-<!--      android:layout_marginStart="@dimen/activity_margin_horizontal"-->
-<!--      android:layout_marginEnd="@dimen/activity_margin_horizontal"-->
-<!--      android:text="@string/statistics_featured"-->
-<!--      app:layout_constraintBottom_toBottomOf="@+id/featured_image_icon"-->
-<!--      app:layout_constraintEnd_toStartOf="@+id/images_nearby_info_icon"-->
-<!--      app:layout_constraintStart_toEndOf="@+id/featured_image_icon"-->
-<!--      app:layout_constraintTop_toTopOf="@+id/featured_image_icon" />-->
-
-
-
-
-<!--    <TextView-->
-<!--      android:id="@+id/image_featured"-->
-<!--      style="?android:textAppearanceMedium"-->
-<!--      android:layout_width="wrap_content"-->
-<!--      android:layout_height="wrap_content"-->
-<!--      android:layout_marginEnd="@dimen/activity_margin_horizontal"-->
-<!--      app:layout_constraintBottom_toBottomOf="@+id/images_featured_info_icon"-->
-<!--      app:layout_constraintEnd_toEndOf="parent"-->
-<!--      app:layout_constraintTop_toTopOf="@+id/images_featured_info_icon"-->
-<!--      tools:text="2" />-->
-
-<!--    <com.google.android.material.divider.MaterialDivider-->
-<!--      android:id="@+id/materialDivider4"-->
-<!--      android:layout_width="match_parent"-->
-<!--      android:layout_height="wrap_content"-->
-<!--      android:layout_marginStart="@dimen/activity_margin_horizontal"-->
-<!--      android:layout_marginTop="@dimen/activity_margin_horizontal"-->
-<!--      android:layout_marginEnd="@dimen/activity_margin_horizontal"-->
-<!--      app:layout_constraintEnd_toEndOf="parent"-->
-<!--      app:layout_constraintStart_toStartOf="parent"-->
-<!--      app:layout_constraintTop_toBottomOf="@+id/featured_image_icon" />-->
-
-
     <LinearLayout
       android:id="@+id/badgesItems"
       android:layout_width="match_parent"
@@ -420,98 +348,10 @@
         android:id="@+id/thanks_image_icon"
         android:layout_width="@dimen/dimen_40"
         android:layout_height="@dimen/dimen_40"
-
         android:layout_marginEnd="@dimen/large_gap"
         app:srcCompat="@drawable/ic_thanks" />
-
-
     </LinearLayout>
 
-<!--    <TextView-->
-<!--      android:id="@+id/quality_images_data"-->
-<!--      style="?android:textAppearanceMedium"-->
-<!--      android:layout_width="0dp"-->
-<!--      android:layout_height="wrap_content"-->
-<!--      android:layout_marginStart="@dimen/activity_margin_horizontal"-->
-<!--      android:layout_marginEnd="@dimen/activity_margin_horizontal"-->
-<!--      android:text="@string/statistics_quality"-->
-<!--      app:layout_constraintBottom_toBottomOf="@+id/quality_image_icon"-->
-<!--      app:layout_constraintEnd_toStartOf="@+id/images_nearby_info_icon"-->
-<!--      app:layout_constraintStart_toEndOf="@+id/quality_image_icon"-->
-<!--      app:layout_constraintTop_toTopOf="@+id/quality_image_icon" />-->
-
-<!--    <ImageView-->
-<!--      android:id="@+id/quality_images_info_icon"-->
-<!--      android:layout_width="wrap_content"-->
-<!--      android:layout_height="wrap_content"-->
-<!--      android:layout_marginEnd="16dp"-->
-<!--      app:layout_constraintBottom_toBottomOf="@+id/quality_images_data"-->
-<!--      app:layout_constraintEnd_toStartOf="@+id/quality_images"-->
-<!--      app:layout_constraintTop_toTopOf="@+id/quality_images_data"-->
-<!--      app:srcCompat="@drawable/ic_info_outline_24dp"-->
-<!--      app:tint="@color/black" />-->
-
-<!--    <TextView-->
-<!--      android:id="@+id/quality_images"-->
-<!--      style="?android:textAppearanceMedium"-->
-<!--      android:layout_width="wrap_content"-->
-<!--      android:layout_height="wrap_content"-->
-<!--      android:layout_marginEnd="@dimen/activity_margin_horizontal"-->
-<!--      app:layout_constraintBottom_toBottomOf="@+id/quality_images_info_icon"-->
-<!--      app:layout_constraintEnd_toEndOf="parent"-->
-<!--      app:layout_constraintTop_toTopOf="@+id/quality_images_info_icon"-->
-<!--      tools:text="2" />-->
-
-<!--    <com.google.android.material.divider.MaterialDivider-->
-<!--      android:id="@+id/materialDivider5"-->
-<!--      android:layout_width="match_parent"-->
-<!--      android:layout_height="wrap_content"-->
-<!--      android:layout_marginStart="@dimen/activity_margin_horizontal"-->
-<!--      android:layout_marginTop="@dimen/activity_margin_horizontal"-->
-<!--      android:layout_marginEnd="@dimen/activity_margin_horizontal"-->
-<!--      app:layout_constraintEnd_toEndOf="parent"-->
-<!--      app:layout_constraintStart_toStartOf="parent"-->
-<!--      app:layout_constraintTop_toBottomOf="@+id/quality_image_icon" />-->
-
-
-
-
-<!--    <TextView-->
-<!--      android:id="@+id/thanks_received_data"-->
-<!--      style="?android:textAppearanceMedium"-->
-<!--      android:layout_width="0dp"-->
-<!--      android:layout_height="wrap_content"-->
-<!--      android:layout_marginStart="@dimen/activity_margin_horizontal"-->
-<!--      android:layout_marginEnd="@dimen/activity_margin_horizontal"-->
-<!--      android:text="@string/statistics_thanks"-->
-<!--      app:layout_constraintBottom_toBottomOf="@+id/thanks_image_icon"-->
-<!--      app:layout_constraintEnd_toStartOf="@+id/images_nearby_info_icon"-->
-<!--      app:layout_constraintStart_toEndOf="@+id/thanks_image_icon"-->
-<!--      app:layout_constraintTop_toTopOf="@+id/thanks_image_icon" />-->
-
-<!--    <ImageView-->
-<!--      android:id="@+id/thanks_received_info_icon"-->
-<!--      android:layout_width="wrap_content"-->
-<!--      android:layout_height="wrap_content"-->
-<!--      android:layout_marginEnd="@dimen/activity_margin_horizontal"-->
-<!--      app:layout_constraintBottom_toBottomOf="@+id/thanks_received_data"-->
-<!--      app:layout_constraintEnd_toStartOf="@+id/quality_images"-->
-<!--      app:layout_constraintTop_toTopOf="@+id/thanks_received_data"-->
-<!--      app:srcCompat="@drawable/ic_info_outline_24dp"-->
-<!--      app:tint="@color/black" />-->
-
-<!--    <TextView-->
-<!--      android:id="@+id/thanks_received"-->
-<!--      style="?android:textAppearanceMedium"-->
-<!--      android:layout_width="wrap_content"-->
-<!--      android:layout_height="wrap_content"-->
-<!--      android:layout_marginEnd="@dimen/activity_margin_horizontal"-->
-<!--      app:layout_constraintBottom_toBottomOf="@+id/thanks_received_info_icon"-->
-<!--      app:layout_constraintEnd_toEndOf="parent"-->
-<!--      app:layout_constraintTop_toTopOf="@+id/thanks_received_info_icon"-->
-<!--      tools:text="2" />-->
-
-
     <ProgressBar
       android:id="@+id/progressBar"
       android:layout_width="wrap_content"
@@ -524,11 +364,5 @@
       app:layout_constraintHorizontal_bias="0.5"
       android:visibility="gone"/>
 
-
-
   </androidx.constraintlayout.widget.ConstraintLayout>
-
-
-
-
 </ScrollView>
\ No newline at end of file