From dfa3417d416c32a0e294e7d149e6c27c99dd4332 Mon Sep 17 00:00:00 2001 From: shashankkumar Date: Tue, 23 Jan 2024 18:43:52 +0530 Subject: [PATCH 1/2] Enhancement Nearby banner shows Item without image --- .../nrw/commons/contributions/ContributionsFragment.java | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsFragment.java b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsFragment.java index f88b01b76..df7ed8f97 100644 --- a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsFragment.java +++ b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsFragment.java @@ -17,6 +17,7 @@ import android.hardware.SensorEvent; import android.hardware.SensorEventListener; import android.hardware.SensorManager; import android.os.Bundle; +import android.util.Log; import android.view.LayoutInflater; import android.view.Menu; import android.view.MenuInflater; @@ -538,7 +539,13 @@ public class ContributionsFragment private void updateNearbyNotification(@Nullable NearbyController.NearbyPlacesInfo nearbyPlacesInfo) { if (nearbyPlacesInfo != null && nearbyPlacesInfo.placeList != null && nearbyPlacesInfo.placeList.size() > 0) { - Place closestNearbyPlace = nearbyPlacesInfo.placeList.get(0); + Place closestNearbyPlace =null; + for (Place place : nearbyPlacesInfo.placeList) { + if (place.pic.equals("")) { + closestNearbyPlace = place; + break; + } + } String distance = formatDistanceBetween(curLatLng, closestNearbyPlace.location); closestNearbyPlace.setDistance(distance); direction = (float) computeBearing(curLatLng, closestNearbyPlace.location); From 2249b24f64e54c30eeaafc82d21ccbaefd929033 Mon Sep 17 00:00:00 2001 From: Nicolas Raoul Date: Sat, 27 Jan 2024 21:41:49 +0900 Subject: [PATCH 2/2] spacing --- .../free/nrw/commons/contributions/ContributionsFragment.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsFragment.java b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsFragment.java index df7ed8f97..474b2110c 100644 --- a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsFragment.java +++ b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsFragment.java @@ -539,7 +539,7 @@ public class ContributionsFragment private void updateNearbyNotification(@Nullable NearbyController.NearbyPlacesInfo nearbyPlacesInfo) { if (nearbyPlacesInfo != null && nearbyPlacesInfo.placeList != null && nearbyPlacesInfo.placeList.size() > 0) { - Place closestNearbyPlace =null; + Place closestNearbyPlace = null; for (Place place : nearbyPlacesInfo.placeList) { if (place.pic.equals("")) { closestNearbyPlace = place;