From 9985e87b8a35263e25243b1207da592b3c58aad5 Mon Sep 17 00:00:00 2001
From: Shradheya Thakre <tshradheya@gmail.com>
Date: Sun, 21 Jan 2018 15:48:54 +0800
Subject: [PATCH] Used @OnClick Annotation

---
 app/src/main/java/fr/free/nrw/commons/AboutActivity.java | 4 ++++
 app/src/main/res/layout/activity_about.xml               | 6 +++---
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/app/src/main/java/fr/free/nrw/commons/AboutActivity.java b/app/src/main/java/fr/free/nrw/commons/AboutActivity.java
index 52c337adc..260878b00 100644
--- a/app/src/main/java/fr/free/nrw/commons/AboutActivity.java
+++ b/app/src/main/java/fr/free/nrw/commons/AboutActivity.java
@@ -8,6 +8,7 @@ import android.widget.TextView;
 
 import butterknife.BindView;
 import butterknife.ButterKnife;
+import butterknife.OnClick;
 import fr.free.nrw.commons.theme.NavigationBaseActivity;
 import fr.free.nrw.commons.ui.widget.HtmlTextView;
 
@@ -37,6 +38,7 @@ public class AboutActivity extends NavigationBaseActivity {
         initDrawer();
     }
 
+    @OnClick(R.id.facebook_launch_icon)
     public void launchFacebook(View view) {
 
         Intent intent;
@@ -50,12 +52,14 @@ public class AboutActivity extends NavigationBaseActivity {
 
     }
 
+    @OnClick(R.id.github_launch_icon)
     public void launchGithub(View view) {
 
         Intent browserIntent = new Intent(Intent.ACTION_VIEW, Uri.parse("https://github.com/commons-app/apps-android-commons\\"));
         startActivity(browserIntent);
     }
 
+    @OnClick(R.id.website_launch_icon)
     public void launchWebsite(View view) {
 
         Intent browserIntent = new Intent(Intent.ACTION_VIEW, Uri.parse("https://commons-app.github.io/\\"));
diff --git a/app/src/main/res/layout/activity_about.xml b/app/src/main/res/layout/activity_about.xml
index d8e312ede..eca4d32d2 100644
--- a/app/src/main/res/layout/activity_about.xml
+++ b/app/src/main/res/layout/activity_about.xml
@@ -76,30 +76,30 @@
                 >
 
                 <ImageView
+                    android:id="@+id/website_launch_icon"
                     android:layout_width="@dimen/overflow_icon_dimen"
                     android:layout_height="@dimen/overflow_icon_dimen"
                     android:src="@drawable/ic_action_globe"
                     android:contentDescription= "@string/commons_website"
                     android:layout_margin="@dimen/activity_margin_horizontal"
-                    android:onClick="getOpenWebsiteIntent"
                     />
 
                 <ImageView
+                    android:id="@+id/facebook_launch_icon"
                     android:layout_width="@dimen/overflow_icon_dimen"
                     android:layout_height="@dimen/overflow_icon_dimen"
                     android:src="@drawable/ic_action_facebook"
                     android:contentDescription= "@string/commons_facebook"
                     android:layout_margin="@dimen/activity_margin_horizontal"
-                    android:onClick="getOpenFacebookIntent"
                     />
 
                 <ImageView
+                    android:id="@+id/github_launch_icon"
                     android:layout_width="@dimen/overflow_icon_dimen"
                     android:layout_height="@dimen/overflow_icon_dimen"
                     android:src="@drawable/ic_action_github"
                     android:contentDescription= "@string/commons_github"
                     android:layout_margin="@dimen/activity_margin_horizontal"
-                    android:onClick="getOpenGithubIntent"
                     />
 
             </LinearLayout>