mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-26 20:33:53 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Clean up placeholders in media detail fragment fields(Fixed #2471) (#2500)

Browse source 
Remove placeholders and let these descriptions only shown in Android
Studio layout preview. Use plain text in tools:text attributes so
relative string values can also be removed and ease the translation work.
This commit is contained in:
Zhao Gang 2019-02-22 13:43:31 +08:00 • committed by Vivek Maskara
parent 02be443269
commit 9882d24651
2 changed files with 8 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

18
app/src/main/res/layout/fragment_media_detail.xml
View file

@ -75,9 +75,9 @@
android:layout_gravity="start" android:layout_gravity="start"
android:background="?attr/subBackground" android:background="?attr/subBackground"
android:padding="@dimen/small_gap" android:padding="@dimen/small_gap"
android:text="@string/media_detail_media_title"
android:textColor="@android:color/white" android:textColor="@android:color/white"
android:textSize="@dimen/description_text_size" /> android:textSize="@dimen/description_text_size"
tools:text="Title of the media" />
</LinearLayout> </LinearLayout>
<fr.free.nrw.commons.media.MediaDetailSpacer <fr.free.nrw.commons.media.MediaDetailSpacer
@ -108,9 +108,9 @@
android:layout_gravity="start" android:layout_gravity="start"
android:background="?attr/subBackground" android:background="?attr/subBackground"
android:padding="@dimen/small_gap" android:padding="@dimen/small_gap"
android:text="@string/media_detail_author_explanation"
android:textColor="@android:color/white" android:textColor="@android:color/white"
android:textSize="@dimen/description_text_size" /> android:textSize="@dimen/description_text_size"
tools:text="Media author user name goes here." />
</LinearLayout> </LinearLayout>
<fr.free.nrw.commons.media.MediaDetailSpacer <fr.free.nrw.commons.media.MediaDetailSpacer
@ -140,9 +140,9 @@
android:layout_gravity="start" android:layout_gravity="start"
android:background="?attr/subBackground" android:background="?attr/subBackground"
android:padding="@dimen/small_gap" android:padding="@dimen/small_gap"
android:text="@string/media_detail_description_explanation"
android:textColor="@android:color/white" android:textColor="@android:color/white"
android:textSize="@dimen/description_text_size" /> android:textSize="@dimen/description_text_size"
tools:text="Description of the media goes here. This can potentially be fairly long, and will need to wrap across multiple lines. We hope it looks nice though." />
</LinearLayout> </LinearLayout>
<fr.free.nrw.commons.media.MediaDetailSpacer <fr.free.nrw.commons.media.MediaDetailSpacer
@ -174,7 +174,6 @@
android:foreground="?attr/selectableItemBackground" android:foreground="?attr/selectableItemBackground"
android:gravity="center_vertical" android:gravity="center_vertical"
android:padding="@dimen/small_gap" android:padding="@dimen/small_gap"
android:text="@string/media_detail_license"
android:textColor="@android:color/white" android:textColor="@android:color/white"
android:textSize="@dimen/description_text_size" android:textSize="@dimen/description_text_size"
app:drawablePadding="@dimen/tiny_gap" app:drawablePadding="@dimen/tiny_gap"
@ -211,7 +210,6 @@
android:foreground="?attr/selectableItemBackground" android:foreground="?attr/selectableItemBackground"
android:gravity="center_vertical" android:gravity="center_vertical"
android:padding="@dimen/small_gap" android:padding="@dimen/small_gap"
android:text="@string/media_detail_coordinates"
android:textColor="@android:color/white" android:textColor="@android:color/white"
android:textSize="@dimen/description_text_size" android:textSize="@dimen/description_text_size"
app:drawablePadding="@dimen/tiny_gap" app:drawablePadding="@dimen/tiny_gap"
@ -275,9 +273,9 @@
android:layout_gravity="start" android:layout_gravity="start"
android:background="?attr/subBackground" android:background="?attr/subBackground"
android:padding="@dimen/small_gap" android:padding="@dimen/small_gap"
android:text="@string/media_detail_uploaded_date"
android:textColor="@android:color/white" android:textColor="@android:color/white"
android:textSize="@dimen/description_text_size" /> android:textSize="@dimen/description_text_size"
tools:text="Uploaded date" />
</LinearLayout> </LinearLayout>
<fr.free.nrw.commons.media.MediaDetailSpacer <fr.free.nrw.commons.media.MediaDetailSpacer

3
app/src/main/res/values/strings.xml
View file

@ -175,11 +175,8 @@
<string name="yes">Yes</string> <string name="yes">Yes</string>
<string name="no">No</string> <string name="no">No</string>
<string name="media_detail_title">Title</string> <string name="media_detail_title">Title</string>
<string name="media_detail_media_title">Title of the media</string>
<string name="media_detail_description">Description</string> <string name="media_detail_description">Description</string>
<string name="media_detail_description_explanation">Description of the media goes here. This can potentially be fairly long, and will need to wrap across multiple lines. We hope it looks nice though.</string>
<string name="media_detail_author">Author</string> <string name="media_detail_author">Author</string>
<string name="media_detail_author_explanation">Featured image author user name goes here.</string>
<string name="media_detail_uploaded_date">Uploaded date</string> <string name="media_detail_uploaded_date">Uploaded date</string>
<string name="media_detail_license">License</string> <string name="media_detail_license">License</string>
<string name="media_detail_coordinates">Coordinates</string> <string name="media_detail_coordinates">Coordinates</string>