diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml index aeaeeb367..a3656c193 100644 --- a/app/src/main/AndroidManifest.xml +++ b/app/src/main/AndroidManifest.xml @@ -149,8 +149,6 @@ android:exported="false"> - - diff --git a/app/src/main/java/fr/free/nrw/commons/CommonsApplication.java b/app/src/main/java/fr/free/nrw/commons/CommonsApplication.java index fa2133c00..a7d346e9d 100644 --- a/app/src/main/java/fr/free/nrw/commons/CommonsApplication.java +++ b/app/src/main/java/fr/free/nrw/commons/CommonsApplication.java @@ -59,7 +59,6 @@ public class CommonsApplication extends Application { public static final Object[] EVENT_LOGIN_ATTEMPT = {"MobileAppLoginAttempts", 5257721L}; public static final Object[] EVENT_SHARE_ATTEMPT = {"MobileAppShareAttempts", 5346170L}; public static final Object[] EVENT_CATEGORIZATION_ATTEMPT = {"MobileAppCategorizationAttempts", 5359208L}; - public static final String DEFAULT_EDIT_SUMMARY = "Uploaded using Android Commons app"; @@ -94,7 +93,6 @@ public class CommonsApplication extends Application { System.setProperty("in.yuvi.http.fluent.PROGRESS_TRIGGER_THRESHOLD", "3.0"); api = createMWApi(); - ImageLoaderConfiguration imageLoaderConfiguration = new ImageLoaderConfiguration.Builder(getApplicationContext()) .discCache(new TotalSizeLimitedDiscCache(StorageUtils.getCacheDirectory(this), 128 * 1024 * 1024)) .build(); @@ -111,7 +109,6 @@ public class CommonsApplication extends Application { // Initialize EventLogging EventLog.setApp(this); - // based off https://developer.android.com/training/displaying-bitmaps/cache-bitmap.html // Cache for 1/8th of available VM memory long maxMem = Runtime.getRuntime().maxMemory(); diff --git a/app/src/main/java/fr/free/nrw/commons/EventLog.java b/app/src/main/java/fr/free/nrw/commons/EventLog.java index a860f4878..b0922fe22 100644 --- a/app/src/main/java/fr/free/nrw/commons/EventLog.java +++ b/app/src/main/java/fr/free/nrw/commons/EventLog.java @@ -24,7 +24,6 @@ public class EventLog { for(LogBuilder logBuilder: logBuilders) { HttpURLConnection conn; try { - URL url = logBuilder.toUrl(); HttpResponse response = Http.get(url.toString()).use(CommonsApplication.createHttpClient()).asResponse(); @@ -37,7 +36,6 @@ public class EventLog { // Probably just ignore for now. Can be much more robust with a service, etc later on. Log.d("Commons", "IO Error, EventLog hit skipped"); } - } return allSuccess; diff --git a/app/src/main/java/fr/free/nrw/commons/HandlerService.java b/app/src/main/java/fr/free/nrw/commons/HandlerService.java index e29d64fdd..790b2d7c9 100644 --- a/app/src/main/java/fr/free/nrw/commons/HandlerService.java +++ b/app/src/main/java/fr/free/nrw/commons/HandlerService.java @@ -32,7 +32,6 @@ public abstract class HandlerService extends Service { public HandlerService getService() { return HandlerService.this; } - } private final IBinder localBinder = new HandlerServiceLocalBinder(); diff --git a/app/src/main/java/fr/free/nrw/commons/LicenseList.java b/app/src/main/java/fr/free/nrw/commons/LicenseList.java index f3c6e7c6a..ba91aa955 100644 --- a/app/src/main/java/fr/free/nrw/commons/LicenseList.java +++ b/app/src/main/java/fr/free/nrw/commons/LicenseList.java @@ -28,7 +28,6 @@ public class LicenseList { fr.free.nrw.commons.License license = new fr.free.nrw.commons.License(id, template, url, name); licenses.put(id, license); } - } public Set keySet() { diff --git a/app/src/main/java/fr/free/nrw/commons/Media.java b/app/src/main/java/fr/free/nrw/commons/Media.java index e7c3b058a..3289a22d2 100644 --- a/app/src/main/java/fr/free/nrw/commons/Media.java +++ b/app/src/main/java/fr/free/nrw/commons/Media.java @@ -143,10 +143,7 @@ public class Media implements Parcelable { protected int width; protected int height; protected String license; - - protected String creator; - protected ArrayList categories; // as loaded at runtime? protected Map descriptions; // multilingual descriptions as loaded diff --git a/app/src/main/java/fr/free/nrw/commons/MediaWikiImageView.java b/app/src/main/java/fr/free/nrw/commons/MediaWikiImageView.java index f733edcf3..5039e63c5 100644 --- a/app/src/main/java/fr/free/nrw/commons/MediaWikiImageView.java +++ b/app/src/main/java/fr/free/nrw/commons/MediaWikiImageView.java @@ -30,7 +30,6 @@ import com.android.volley.toolbox.ImageLoader.ImageListener; import fr.free.nrw.commons.contributions.Contribution; import fr.free.nrw.commons.contributions.ContributionsContentProvider; - public class MediaWikiImageView extends ImageView { private Media mMedia; @@ -89,7 +88,6 @@ public class MediaWikiImageView extends ImageView { return; } - // Do not count for density when loading thumbnails. // FIXME: Use another 'algorithm' that doesn't punish low res devices if(isThumbnail) { @@ -160,7 +158,6 @@ public class MediaWikiImageView extends ImageView { } }); } - } @Override diff --git a/app/src/main/java/fr/free/nrw/commons/Prefs.java b/app/src/main/java/fr/free/nrw/commons/Prefs.java index dc591d980..b8d494b95 100644 --- a/app/src/main/java/fr/free/nrw/commons/Prefs.java +++ b/app/src/main/java/fr/free/nrw/commons/Prefs.java @@ -6,7 +6,6 @@ public class Prefs { public static String TRACKING_ENABLED = "eventLogging"; public static final String DEFAULT_LICENSE = "defaultLicense"; - public static class Licenses { public static final String CC_BY_SA = "CC BY-SA"; public static final String CC_BY = "CC BY"; diff --git a/app/src/main/java/fr/free/nrw/commons/Utils.java b/app/src/main/java/fr/free/nrw/commons/Utils.java index 044037cc4..27787bc35 100644 --- a/app/src/main/java/fr/free/nrw/commons/Utils.java +++ b/app/src/main/java/fr/free/nrw/commons/Utils.java @@ -55,7 +55,6 @@ public class Utils { return String.format("%s/%s/%s/%s", CommonsApplication.IMAGE_URL_BASE, sha.substring(0, 1), sha.substring(0, 2), urlEncode(name)); } - public static String getStringFromDOM(Node dom) { javax.xml.transform.Transformer transformer = null; try { @@ -102,7 +101,6 @@ public class Utils { } } - private static DisplayImageOptions.Builder defaultImageOptionsBuilder; public static DisplayImageOptions.Builder getGenericDisplayOptions() { if(defaultImageOptionsBuilder == null) { diff --git a/app/src/main/java/fr/free/nrw/commons/auth/AuthenticatedActivity.java b/app/src/main/java/fr/free/nrw/commons/auth/AuthenticatedActivity.java index 48e14ae68..7ac793c47 100644 --- a/app/src/main/java/fr/free/nrw/commons/auth/AuthenticatedActivity.java +++ b/app/src/main/java/fr/free/nrw/commons/auth/AuthenticatedActivity.java @@ -12,8 +12,7 @@ import fr.free.nrw.commons.CommonsApplication; import fr.free.nrw.commons.Utils; public abstract class AuthenticatedActivity extends AppCompatActivity { - - + String accountType; CommonsApplication app; @@ -22,7 +21,6 @@ public abstract class AuthenticatedActivity extends AppCompatActivity { public AuthenticatedActivity(String accountType) { this.accountType = accountType; } - private class GetAuthCookieTask extends AsyncTask { private Account account; @@ -59,7 +57,6 @@ public abstract class AuthenticatedActivity extends AppCompatActivity { } } } - private class AddAccountTask extends AsyncTask { private AccountManager accountManager; @@ -106,6 +103,7 @@ public abstract class AuthenticatedActivity extends AppCompatActivity { } } + protected void requestAuthToken() { if(authCookie != null) { onAuthCookieAcquired(authCookie); diff --git a/app/src/main/java/fr/free/nrw/commons/category/CategorizationFragment.java b/app/src/main/java/fr/free/nrw/commons/category/CategorizationFragment.java index bc1c6803c..6a27411ff 100644 --- a/app/src/main/java/fr/free/nrw/commons/category/CategorizationFragment.java +++ b/app/src/main/java/fr/free/nrw/commons/category/CategorizationFragment.java @@ -627,8 +627,6 @@ public class CategorizationFragment extends Fragment { return super.onOptionsItemSelected(menuItem); } - - @Override public void onAttach(Activity activity) { super.onAttach(activity); diff --git a/app/src/main/java/fr/free/nrw/commons/category/Category.java b/app/src/main/java/fr/free/nrw/commons/category/Category.java index c58b8da2c..645b10afc 100644 --- a/app/src/main/java/fr/free/nrw/commons/category/Category.java +++ b/app/src/main/java/fr/free/nrw/commons/category/Category.java @@ -104,7 +104,6 @@ public class Category { COLUMN_TIMES_USED }; - private static final String CREATE_TABLE_STATEMENT = "CREATE TABLE " + TABLE_NAME + " (" + COLUMN_ID + " INTEGER PRIMARY KEY," + COLUMN_NAME + " STRING," @@ -112,7 +111,6 @@ public class Category { + COLUMN_TIMES_USED + " INTEGER" + ");"; - public static void onCreate(SQLiteDatabase db) { db.execSQL(CREATE_TABLE_STATEMENT); } diff --git a/app/src/main/java/fr/free/nrw/commons/category/CategoryContentProvider.java b/app/src/main/java/fr/free/nrw/commons/category/CategoryContentProvider.java index a3569e898..1d9fa161a 100644 --- a/app/src/main/java/fr/free/nrw/commons/category/CategoryContentProvider.java +++ b/app/src/main/java/fr/free/nrw/commons/category/CategoryContentProvider.java @@ -29,7 +29,6 @@ public class CategoryContentProvider extends ContentProvider { uriMatcher.addURI(AUTHORITY, BASE_PATH + "/#", CATEGORIES_ID); } - public static Uri uriForId(int id) { return Uri.parse(BASE_URI.toString() + "/" + id); } diff --git a/app/src/main/java/fr/free/nrw/commons/contributions/Contribution.java b/app/src/main/java/fr/free/nrw/commons/contributions/Contribution.java index 742d09de8..814eec366 100644 --- a/app/src/main/java/fr/free/nrw/commons/contributions/Contribution.java +++ b/app/src/main/java/fr/free/nrw/commons/contributions/Contribution.java @@ -90,7 +90,6 @@ public class Contribution extends Media { state = in.readInt(); transferred = in.readLong(); isMultiple = in.readInt() == 1; - } public long getTransferred() { @@ -101,7 +100,6 @@ public class Contribution extends Media { this.transferred = transferred; } - public String getEditSummary() { return editSummary != null ? editSummary : CommonsApplication.DEFAULT_EDIT_SUMMARY; } @@ -267,7 +265,6 @@ public class Contribution extends Media { this.localUri = localUri; } - public static class Table { public static final String TABLE_NAME = "contributions"; diff --git a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsActivity.java b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsActivity.java index a4abe07c6..d514f00b7 100644 --- a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsActivity.java +++ b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsActivity.java @@ -57,7 +57,6 @@ public class ContributionsActivity */ private String CONTRIBUTION_SORT = Contribution.Table.COLUMN_STATE + " DESC, " + Contribution.Table.COLUMN_UPLOADED + " DESC , (" + Contribution.Table.COLUMN_TIMESTAMP + " * " + Contribution.Table.COLUMN_STATE + ")"; - public ContributionsActivity() { super(WikiAccountAuthenticator.COMMONS_ACCOUNT_TYPE); } @@ -191,7 +190,6 @@ public class ContributionsActivity finish(); // If authentication failed, we just exit } - public void onItemClick(AdapterView adapterView, View view, int position, long item) { showDetail(position); } @@ -218,13 +216,10 @@ public class ContributionsActivity contributionsList.clearSyncMessage(); notifyAndMigrateDataSetObservers(); - } public void onLoaderReset(Loader cursorLoader) { - ((CursorAdapter) contributionsList.getAdapter()).swapCursor(null); - } //FIXME: Potential cause of wrong image display bug diff --git a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsContentProvider.java b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsContentProvider.java index a6dcd5757..43d3166d8 100644 --- a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsContentProvider.java +++ b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsContentProvider.java @@ -26,7 +26,6 @@ public class ContributionsContentProvider extends ContentProvider{ uriMatcher.addURI(AUTHORITY, BASE_PATH + "/#", CONTRIBUTIONS_ID); } - public static Uri uriForId(int id) { return Uri.parse(BASE_URI.toString() + "/" + id); } diff --git a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListAdapter.java b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListAdapter.java index 8ea7d9696..ad6de5c13 100644 --- a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListAdapter.java +++ b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListAdapter.java @@ -19,7 +19,6 @@ import fr.free.nrw.commons.R; class ContributionsListAdapter extends CursorAdapter { - private DisplayImageOptions contributionDisplayOptions = Utils.getGenericDisplayOptions().build(); private Activity activity; @@ -111,6 +110,5 @@ class ContributionsListAdapter extends CursorAdapter { views.progressView.setVisibility(View.GONE); break; } - } } diff --git a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListFragment.java b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListFragment.java index f76f081b9..086e55a9a 100644 --- a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListFragment.java +++ b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListFragment.java @@ -108,7 +108,6 @@ public class ContributionsListFragment extends Fragment { } } - @Override public boolean onOptionsItemSelected(MenuItem item) { switch(item.getItemId()) { @@ -210,7 +209,6 @@ public class ContributionsListFragment extends Fragment { } menu.findItem(R.id.menu_refresh).setVisible(false); - } @Override diff --git a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsSyncAdapter.java b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsSyncAdapter.java index 08df0c690..c0063c5bf 100644 --- a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsSyncAdapter.java +++ b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsSyncAdapter.java @@ -15,7 +15,6 @@ import org.mediawiki.api.*; import fr.free.nrw.commons.CommonsApplication; import fr.free.nrw.commons.Utils; - public class ContributionsSyncAdapter extends AbstractThreadedSyncAdapter { private static int COMMIT_THRESHOLD = 10; public ContributionsSyncAdapter(Context context, boolean autoInitialize) { @@ -122,7 +121,5 @@ public class ContributionsSyncAdapter extends AbstractThreadedSyncAdapter { } prefs.edit().putString("lastSyncTimestamp", Utils.toMWDate(curTime)).apply(); Log.d("Commons", "Oh hai, everyone! Look, a kitty!"); - - } } diff --git a/app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java b/app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java index c425e32ed..2711f9a7d 100644 --- a/app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java +++ b/app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java @@ -82,7 +82,6 @@ public class MediaDetailFragment extends Fragment { private AsyncTask detailFetchTask; private LicenseList licenseList; - @Override public void onSaveInstanceState(Bundle outState) { super.onSaveInstanceState(outState); @@ -175,7 +174,6 @@ public class MediaDetailFragment extends Fragment { scrollView.scrollTo(0, initialListTop); } - } }; view.getViewTreeObserver().addOnGlobalLayoutListener(layoutListener); diff --git a/app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.java b/app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.java index 62ecf6c37..d19db5e86 100644 --- a/app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.java +++ b/app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.java @@ -269,7 +269,6 @@ public class MediaDetailPagerFragment extends Fragment implements ViewPager.OnPa // Default set of menu items works fine. Treat same as regular media object break; } - } return; } diff --git a/app/src/main/java/fr/free/nrw/commons/modifications/CategoryModifier.java b/app/src/main/java/fr/free/nrw/commons/modifications/CategoryModifier.java index 1a4b5ffce..4e9c5b486 100644 --- a/app/src/main/java/fr/free/nrw/commons/modifications/CategoryModifier.java +++ b/app/src/main/java/fr/free/nrw/commons/modifications/CategoryModifier.java @@ -6,7 +6,6 @@ import org.json.JSONObject; public class CategoryModifier extends PageModifier { - public static String PARAM_CATEGORIES = "categories"; public static String MODIFIER_NAME = "CategoriesModifier"; diff --git a/app/src/main/java/fr/free/nrw/commons/modifications/ModificationsContentProvider.java b/app/src/main/java/fr/free/nrw/commons/modifications/ModificationsContentProvider.java index 281a0c34e..d2e26d631 100644 --- a/app/src/main/java/fr/free/nrw/commons/modifications/ModificationsContentProvider.java +++ b/app/src/main/java/fr/free/nrw/commons/modifications/ModificationsContentProvider.java @@ -26,7 +26,6 @@ public class ModificationsContentProvider extends ContentProvider{ uriMatcher.addURI(AUTHORITY, BASE_PATH + "/#", MODIFICATIONS_ID); } - public static Uri uriForId(int id) { return Uri.parse(BASE_URI.toString() + "/" + id); } diff --git a/app/src/main/java/fr/free/nrw/commons/modifications/ModificationsSyncAdapter.java b/app/src/main/java/fr/free/nrw/commons/modifications/ModificationsSyncAdapter.java index f38a51ef0..135ec4e54 100644 --- a/app/src/main/java/fr/free/nrw/commons/modifications/ModificationsSyncAdapter.java +++ b/app/src/main/java/fr/free/nrw/commons/modifications/ModificationsSyncAdapter.java @@ -18,7 +18,6 @@ import fr.free.nrw.commons.CommonsApplication; import fr.free.nrw.commons.Utils; import fr.free.nrw.commons.contributions.ContributionsContentProvider; - public class ModificationsSyncAdapter extends AbstractThreadedSyncAdapter { public ModificationsSyncAdapter(Context context, boolean autoInitialize) { @@ -66,7 +65,6 @@ public class ModificationsSyncAdapter extends AbstractThreadedSyncAdapter { return; } - allModifications.moveToFirst(); Log.d("Commons", "Found " + allModifications.getCount() + " modifications to execute"); @@ -129,13 +127,11 @@ public class ModificationsSyncAdapter extends AbstractThreadedSyncAdapter { } } allModifications.moveToNext(); - } } finally { if(contributionsClient != null) { contributionsClient.release(); } - } } } diff --git a/app/src/main/java/fr/free/nrw/commons/modifications/ModifierSequence.java b/app/src/main/java/fr/free/nrw/commons/modifications/ModifierSequence.java index 789e448be..97335acb3 100644 --- a/app/src/main/java/fr/free/nrw/commons/modifications/ModifierSequence.java +++ b/app/src/main/java/fr/free/nrw/commons/modifications/ModifierSequence.java @@ -127,14 +127,12 @@ public class ModifierSequence { COLUMN_DATA }; - private static final String CREATE_TABLE_STATEMENT = "CREATE TABLE " + TABLE_NAME + " (" + "_id INTEGER PRIMARY KEY," + "mediauri STRING," + "data STRING" + ");"; - public static void onCreate(SQLiteDatabase db) { db.execSQL(CREATE_TABLE_STATEMENT); } diff --git a/app/src/main/java/fr/free/nrw/commons/modifications/TemplateRemoveModifier.java b/app/src/main/java/fr/free/nrw/commons/modifications/TemplateRemoveModifier.java index 21b4872b7..6149084c1 100644 --- a/app/src/main/java/fr/free/nrw/commons/modifications/TemplateRemoveModifier.java +++ b/app/src/main/java/fr/free/nrw/commons/modifications/TemplateRemoveModifier.java @@ -15,7 +15,6 @@ public class TemplateRemoveModifier extends PageModifier { public static final Pattern PATTERN_TEMPLATE_OPEN = Pattern.compile("\\{\\{"); public static final Pattern PATTERN_TEMPLATE_CLOSE = Pattern.compile("\\}\\}"); - public TemplateRemoveModifier(String templateName) { super(MODIFIER_NAME); try { @@ -86,7 +85,6 @@ public class TemplateRemoveModifier extends PageModifier { } return pageContents; - } @Override diff --git a/app/src/main/java/fr/free/nrw/commons/nearby/NearbyListFragment.java b/app/src/main/java/fr/free/nrw/commons/nearby/NearbyListFragment.java index 4bd4f742e..4f5bc495c 100644 --- a/app/src/main/java/fr/free/nrw/commons/nearby/NearbyListFragment.java +++ b/app/src/main/java/fr/free/nrw/commons/nearby/NearbyListFragment.java @@ -354,7 +354,6 @@ public class NearbyListFragment extends ListFragment implements TaskListener { return distanceRadians(Math.toRadians(from.latitude), Math.toRadians(from.longitude), Math.toRadians(to.latitude), Math.toRadians(to.longitude)); } - private static double distanceRadians(double lat1, double lng1, double lat2, double lng2) { return arcHav(havDistance(lat1, lat2, lng1 - lng2)); } diff --git a/app/src/main/java/fr/free/nrw/commons/nearby/NearbyPlaces.java b/app/src/main/java/fr/free/nrw/commons/nearby/NearbyPlaces.java index 198992f4e..4472ec9f3 100644 --- a/app/src/main/java/fr/free/nrw/commons/nearby/NearbyPlaces.java +++ b/app/src/main/java/fr/free/nrw/commons/nearby/NearbyPlaces.java @@ -26,7 +26,6 @@ public class NearbyPlaces { StrictMode.ThreadPolicy policy = new StrictMode.ThreadPolicy.Builder().permitAll().build(); StrictMode.setThreadPolicy(policy); - URL file = new URL("https://tools.wmflabs.org/wiki-needs-pictures/data/data.csv"); BufferedReader in = new BufferedReader(new InputStreamReader(file.openStream())); diff --git a/app/src/main/java/fr/free/nrw/commons/upload/MultipleShareActivity.java b/app/src/main/java/fr/free/nrw/commons/upload/MultipleShareActivity.java index 5fa881a60..5c7d8a631 100644 --- a/app/src/main/java/fr/free/nrw/commons/upload/MultipleShareActivity.java +++ b/app/src/main/java/fr/free/nrw/commons/upload/MultipleShareActivity.java @@ -78,7 +78,6 @@ public class MultipleShareActivity public void onItemClick(AdapterView adapterView, View view, int index, long item) { showDetail(index); - } public void OnMultipleUploadInitiated() { @@ -201,10 +200,8 @@ public class MultipleShareActivity getSupportFragmentManager().addOnBackStackChangedListener(this); requestAuthToken(); - } - @Override protected void onDestroy() { super.onDestroy(); @@ -262,10 +259,8 @@ public class MultipleShareActivity setTitle(getResources().getQuantityString(R.plurals.multiple_uploads_title, photosList.size(), photosList.size())); uploadController.prepareService(); } - } - @Override protected void onAuthFailure() { Toast failureToast = Toast.makeText(this, R.string.authentication_failed, Toast.LENGTH_LONG); diff --git a/app/src/main/java/fr/free/nrw/commons/upload/MultipleUploadListFragment.java b/app/src/main/java/fr/free/nrw/commons/upload/MultipleUploadListFragment.java index 23a6f498a..6f5d7fd5c 100644 --- a/app/src/main/java/fr/free/nrw/commons/upload/MultipleUploadListFragment.java +++ b/app/src/main/java/fr/free/nrw/commons/upload/MultipleUploadListFragment.java @@ -92,7 +92,6 @@ public class MultipleUploadListFragment extends Fragment { } return view; - } } @@ -117,8 +116,8 @@ public class MultipleUploadListFragment extends Fragment { int picWidth = Math.min((int) Math.sqrt(screenWidth * screenHeight / count), screenWidth); picWidth = Math.min((int)(192 * screenMetrics.density), Math.max((int) (120 * screenMetrics.density), picWidth / 48 * 48)); int picHeight = Math.min(picWidth, (int)(192 * screenMetrics.density)); // Max Height is same as Contributions list - return new Point(picWidth, picHeight); + return new Point(picWidth, picHeight); } public void notifyDatasetChanged() { @@ -144,7 +143,6 @@ public class MultipleUploadListFragment extends Fragment { photosGrid = (GridView)view.findViewById(R.id.multipleShareBackground); baseTitle = (EditText)view.findViewById(R.id.multipleBaseTitle); - photosAdapter = new PhotoDisplayAdapter(); photosGrid.setAdapter(photosAdapter); photosGrid.setOnItemClickListener((AdapterView.OnItemClickListener)getActivity()); @@ -169,7 +167,6 @@ public class MultipleUploadListFragment extends Fragment { } } detailProvider.notifyDatasetChanged(); - } public void afterTextChanged(Editable editable) { @@ -207,6 +204,5 @@ public class MultipleUploadListFragment extends Fragment { setHasOptionsMenu(true); } - - + } diff --git a/app/src/main/java/fr/free/nrw/commons/upload/ShareActivity.java b/app/src/main/java/fr/free/nrw/commons/upload/ShareActivity.java index 79672ad4f..0bbecc37e 100644 --- a/app/src/main/java/fr/free/nrw/commons/upload/ShareActivity.java +++ b/app/src/main/java/fr/free/nrw/commons/upload/ShareActivity.java @@ -241,8 +241,8 @@ public class ShareActivity if(savedInstanceState != null) { contribution = savedInstanceState.getParcelable("contribution"); } - requestAuthToken(); + requestAuthToken(); Log.d(TAG, "Uri: " + mediaUriString); Log.d(TAG, "Ext storage dir: " + Environment.getExternalStorageDirectory()); diff --git a/app/src/main/java/fr/free/nrw/commons/upload/SingleUploadFragment.java b/app/src/main/java/fr/free/nrw/commons/upload/SingleUploadFragment.java index 6efa05b14..525926dcd 100644 --- a/app/src/main/java/fr/free/nrw/commons/upload/SingleUploadFragment.java +++ b/app/src/main/java/fr/free/nrw/commons/upload/SingleUploadFragment.java @@ -133,7 +133,6 @@ public class SingleUploadFragment extends Fragment { return rootView; } - @Override public void onAttach(Activity activity) { super.onAttach(activity); diff --git a/app/src/main/java/fr/free/nrw/commons/upload/UploadController.java b/app/src/main/java/fr/free/nrw/commons/upload/UploadController.java index 049249421..070c68271 100644 --- a/app/src/main/java/fr/free/nrw/commons/upload/UploadController.java +++ b/app/src/main/java/fr/free/nrw/commons/upload/UploadController.java @@ -79,7 +79,6 @@ public class UploadController { public void startUpload(final Contribution contribution, final ContributionUploadProgress onComplete) { - SharedPreferences prefs = PreferenceManager.getDefaultSharedPreferences(activity); if(TextUtils.isEmpty(contribution.getCreator())) { @@ -93,7 +92,6 @@ public class UploadController { String license = prefs.getString(Prefs.DEFAULT_LICENSE, Prefs.Licenses.CC_BY_SA); contribution.setLicense(license); - //FIXME: Add permission request here. Only executeAsyncTask if permission has been granted Utils.executeAsyncTask(new AsyncTask() { diff --git a/app/src/main/java/fr/free/nrw/commons/upload/UploadService.java b/app/src/main/java/fr/free/nrw/commons/upload/UploadService.java index f679eae0b..9526613f3 100644 --- a/app/src/main/java/fr/free/nrw/commons/upload/UploadService.java +++ b/app/src/main/java/fr/free/nrw/commons/upload/UploadService.java @@ -146,7 +146,6 @@ public class UploadService extends HandlerService { default: throw new IllegalArgumentException("Unknown value for what"); } - } private boolean freshStart = true; @@ -235,7 +234,6 @@ public class UploadService extends HandlerService { curProgressNotification = null; - String resultStatus = result.getString("/api/upload/@result"); if(!resultStatus.equals("Success")) { String errorCode = result.getString("/api/error/@code"); @@ -281,7 +279,6 @@ public class UploadService extends HandlerService { stopForeground(true); } } - } private void showFailedNotification(Contribution contribution) {