mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-28 13:23:58 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Thank you for the suggestion! Since these methods all take a single View parameter, replacing them with method references is a great way to simplify the code and improve readability. I'll updated the code accordingly. Added a TODO in the code as a reminder to refactor this in the future.

Browse source
This commit is contained in:
Akshay Komar 2025-01-27 00:08:40 +05:30
parent db6283112b
commit 9390d8390b
1 changed files with 12 additions and 47 deletions
Download patch file Download diff file Expand all files Collapse all files

59
app/src/main/java/fr/free/nrw/commons/AboutActivity.kt
View file

@ -33,7 +33,7 @@ class AboutActivity : BaseActivity() {
*
* @param savedInstanceState Data bundle
*/
@SuppressLint("StringFormatInvalid")
@SuppressLint("StringFormatInvalid") //TODO:
public override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
@ -53,7 +53,8 @@ class AboutActivity : BaseActivity() {
*/
binding!!.aboutLicense.setHtmlText(aboutText)
@SuppressLint("StringFormatMatches") val improveText =
@SuppressLint("StringFormatMatches") // TODO:
val improveText =
String.format(getString(R.string.about_improve), Urls.NEW_ISSUE_URL)
binding!!.aboutImprove.setHtmlText(improveText)
binding!!.aboutVersion.text = applicationContext.getVersionNameWithSha()
@ -86,51 +87,15 @@ class AboutActivity : BaseActivity() {
/*
To set listeners, we can create a separate method and use lambda syntax.
*/
binding!!.facebookLaunchIcon.setOnClickListener { view: View? ->
this.launchFacebook(
view
)
}
binding!!.githubLaunchIcon.setOnClickListener { view: View? ->
this.launchGithub(
view
)
}
binding!!.websiteLaunchIcon.setOnClickListener { view: View? ->
this.launchWebsite(
view
)
}
binding!!.aboutRateUs.setOnClickListener { view: View? ->
this.launchRatings(
view
)
}
binding!!.aboutCredits.setOnClickListener { view: View? ->
this.launchCredits(
view
)
}
binding!!.aboutPrivacyPolicy.setOnClickListener { view: View? ->
this.launchPrivacyPolicy(
view
)
}
binding!!.aboutUserGuide.setOnClickListener { view: View? ->
this.launchUserGuide(
view
)
}
binding!!.aboutFaq.setOnClickListener { view: View? ->
this.launchFrequentlyAskedQuesions(
view
)
}
binding!!.aboutTranslate.setOnClickListener { view: View? ->
this.launchTranslate(
view
)
}
binding!!.facebookLaunchIcon.setOnClickListener(::launchFacebook)
binding!!.githubLaunchIcon.setOnClickListener(::launchGithub)
binding!!.websiteLaunchIcon.setOnClickListener(::launchWebsite)
binding!!.aboutRateUs.setOnClickListener(::launchRatings)
binding!!.aboutCredits.setOnClickListener(::launchCredits)
binding!!.aboutPrivacyPolicy.setOnClickListener(::launchPrivacyPolicy)
binding!!.aboutUserGuide.setOnClickListener(::launchUserGuide)
binding!!.aboutFaq.setOnClickListener(::launchFrequentlyAskedQuesions)
binding!!.aboutTranslate.setOnClickListener(::launchTranslate)
}
override fun onSupportNavigateUp(): Boolean {