mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 04:43:54 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Convert media package to kotlin (#6369)
Some checks are pending
Android CI / Run tests and generate APK (push) Waiting to run
Details

Browse source 
* Convert Caption to kotlin

* Convert CaptionListViewAdapter to kotlin

* Convert CaptionListViewAdapter to kotlin

* Removed unused class

* Converted MwParseResult / MwParseResponse to kotlin

* Convert CustomOkHttpNetworkFetcher to kotlin

* Break up MediaDetailPagerFragment to make it easier to convert to kotlin

* Convert MediaDetailProvider to kotlin

* Convert the MediaDetailAdapter to kotlin

* Convert MediaDetailPagerFragment to kotlin
This commit is contained in:
Paul Hawke 2025-07-11 21:11:20 -05:00 • committed by GitHub
parent 79f52db929
commit 8fc7e1039b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
33 changed files with 1030 additions and 1184 deletions
Download patch file Download diff file Expand all files Collapse all files

4
app/src/test/kotlin/fr/free/nrw/commons/bookmarks/BookmarkListRootFragmentUnitTest.kt
View file

@ -235,7 +235,7 @@ class BookmarkListRootFragmentUnitTest {
@Throws(Exception::class)
fun testGetTotalMediaCountCaseNull() {
whenever(bookmarksPagerAdapter.mediaAdapter).thenReturn(null)
Assert.assertEquals(fragment.totalMediaCount, 0)
Assert.assertEquals(fragment.getTotalMediaCount(), 0)
}
@Test
@ -244,7 +244,7 @@ class BookmarkListRootFragmentUnitTest {
val listAdapter = mock(ListAdapter::class.java)
whenever(bookmarksPagerAdapter.mediaAdapter).thenReturn(listAdapter)
whenever(listAdapter.count).thenReturn(1)
Assert.assertEquals(fragment.totalMediaCount, 1)
Assert.assertEquals(fragment.getTotalMediaCount(), 1)
}
@Test

2
app/src/test/kotlin/fr/free/nrw/commons/category/CategoryDetailsActivityUnitTests.kt
View file

@ -76,7 +76,7 @@ class CategoryDetailsActivityUnitTests {
@Test
@Throws(Exception::class)
fun testGetTotalMediaCount() {
activity.totalMediaCount
activity.getTotalMediaCount()
}
@Test

2
app/src/test/kotlin/fr/free/nrw/commons/contributions/ContributionsFragmentUnitTests.kt
View file

@ -334,7 +334,7 @@ class ContributionsFragmentUnitTests {
@Throws(Exception::class)
fun testGetTotalMediaCount() {
Shadows.shadowOf(Looper.getMainLooper()).idle()
fragment.totalMediaCount
fragment.getTotalMediaCount()
}
@Test

6
app/src/test/kotlin/fr/free/nrw/commons/explore/ExploreListRootFragmentUnitTest.kt
View file

@ -189,8 +189,8 @@ class ExploreListRootFragmentUnitTest {
@Test
@Throws(Exception::class)
fun testGetTotalMediaCount() {
`when`(listFragment.totalMediaCount).thenReturn(1)
Assert.assertEquals(fragment.totalMediaCount, 1)
`when`(listFragment.getTotalMediaCount()).thenReturn(1)
Assert.assertEquals(fragment.getTotalMediaCount(), 1)
}
@Test
@ -199,7 +199,7 @@ class ExploreListRootFragmentUnitTest {
val field: Field = ExploreListRootFragment::class.java.getDeclaredField("listFragment")
field.isAccessible = true
field.set(fragment, null)
Assert.assertEquals(fragment.totalMediaCount, 0)
Assert.assertEquals(fragment.getTotalMediaCount(), 0)
}
@Test

2
app/src/test/kotlin/fr/free/nrw/commons/explore/depictions/WikidataItemDetailsActivityUnitTests.kt
View file

@ -108,7 +108,7 @@ class WikidataItemDetailsActivityUnitTests {
@Test
@Throws(Exception::class)
fun testGetTotalMediaCount() {
activity.totalMediaCount
activity.getTotalMediaCount()
}
@Test

4
app/src/test/kotlin/fr/free/nrw/commons/explore/search/SearchActivityUnitTests.kt
View file

@ -160,8 +160,8 @@ class SearchActivityUnitTests {
fun testGetTotalMediaCount() {
val num = 1
Whitebox.setInternalState(activity, "searchMediaFragment", searchMediaFragment)
`when`(searchMediaFragment.totalMediaCount).thenReturn(num)
assertEquals(activity.totalMediaCount, num)
`when`(searchMediaFragment.getTotalMediaCount()).thenReturn(num)
assertEquals(activity.getTotalMediaCount(), num)
}
@Test

8
app/src/test/kotlin/fr/free/nrw/commons/media/CustomOkHttpNetworkFetcherUnitTest.kt
View file

@ -32,7 +32,7 @@ import java.util.concurrent.Executor
class CustomOkHttpNetworkFetcherUnitTest {
private lateinit var fetcher: CustomOkHttpNetworkFetcher
private lateinit var okHttpClient: OkHttpClient
private lateinit var state: CustomOkHttpNetworkFetcher.OkHttpNetworkFetchState
private lateinit var state: OkHttpNetworkFetchState
@Mock
private lateinit var callback: NetworkFetcher.Callback
@ -162,7 +162,7 @@ class CustomOkHttpNetworkFetcherUnitTest {
val method: Method =
CustomOkHttpNetworkFetcher::class.java.getDeclaredMethod(
"onFetchResponse",
CustomOkHttpNetworkFetcher.OkHttpNetworkFetchState::class.java,
OkHttpNetworkFetchState::class.java,
Call::class.java,
Response::class.java,
NetworkFetcher.Callback::class.java,
@ -196,7 +196,7 @@ class CustomOkHttpNetworkFetcherUnitTest {
val method: Method =
CustomOkHttpNetworkFetcher::class.java.getDeclaredMethod(
"onFetchResponse",
CustomOkHttpNetworkFetcher.OkHttpNetworkFetchState::class.java,
OkHttpNetworkFetchState::class.java,
Call::class.java,
Response::class.java,
NetworkFetcher.Callback::class.java,
@ -230,7 +230,7 @@ class CustomOkHttpNetworkFetcherUnitTest {
val method: Method =
CustomOkHttpNetworkFetcher::class.java.getDeclaredMethod(
"onFetchResponse",
CustomOkHttpNetworkFetcher.OkHttpNetworkFetchState::class.java,
OkHttpNetworkFetchState::class.java,
Call::class.java,
Response::class.java,
NetworkFetcher.Callback::class.java,

2
app/src/test/kotlin/fr/free/nrw/commons/media/MediaDetailFragmentUnitTests.kt
View file

@ -132,7 +132,7 @@ class MediaDetailFragmentUnitTests {
private lateinit var button: Button
@Mock
private lateinit var detailProvider: MediaDetailPagerFragment.MediaDetailProvider
private lateinit var detailProvider: MediaDetailProvider
@Mock
private lateinit var applicationKvStore: JsonKvStore