From 8f75ed2801d7b652cb588dd81d8dbb621eaa2643 Mon Sep 17 00:00:00 2001 From: YuviPanda Date: Tue, 19 Feb 2013 12:56:47 +0530 Subject: [PATCH] Fix bug in releasing service connection --- commons/src/main/java/org/wikimedia/commons/ShareActivity.java | 2 +- .../wikimedia/commons/contributions/ContributionsActivity.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/commons/src/main/java/org/wikimedia/commons/ShareActivity.java b/commons/src/main/java/org/wikimedia/commons/ShareActivity.java index da90cf8a0..ee471c545 100644 --- a/commons/src/main/java/org/wikimedia/commons/ShareActivity.java +++ b/commons/src/main/java/org/wikimedia/commons/ShareActivity.java @@ -190,8 +190,8 @@ public class ShareActivity extends AuthenticatedActivity { @Override protected void onDestroy() { - unbindService(uploadServiceConnection); super.onDestroy(); + unbindService(uploadServiceConnection); } @Override diff --git a/commons/src/main/java/org/wikimedia/commons/contributions/ContributionsActivity.java b/commons/src/main/java/org/wikimedia/commons/contributions/ContributionsActivity.java index 2d02dc131..34e17962f 100644 --- a/commons/src/main/java/org/wikimedia/commons/contributions/ContributionsActivity.java +++ b/commons/src/main/java/org/wikimedia/commons/contributions/ContributionsActivity.java @@ -134,8 +134,8 @@ public class ContributionsActivity extends AuthenticatedActivity implements Load @Override protected void onDestroy() { - unbindService(uploadServiceConnection); super.onDestroy(); + unbindService(uploadServiceConnection); } private GridView contributionsList;