mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 12:53:55 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fixing Codacy issues

Browse source
This commit is contained in:
pszklarska 2017-09-05 18:27:16 +02:00
parent c9ed77f696
commit 8edd90ef50
2 changed files with 13 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
app/src/main/java/fr/free/nrw/commons/category/CategorizationFragment.java
View file

@ -227,7 +227,8 @@ public class CategorizationFragment extends Fragment {
private Comparator<CategoryItem> sortBySimilarity(final String filter) { private Comparator<CategoryItem> sortBySimilarity(final String filter) {
Comparator<String> stringSimilarityComparator = StringSortingUtils.sortBySimilarity(filter); Comparator<String> stringSimilarityComparator = StringSortingUtils.sortBySimilarity(filter);
return (firstItem, secondItem) -> stringSimilarityComparator.compare(firstItem.getName(), secondItem.getName()); return (firstItem, secondItem) -> stringSimilarityComparator
.compare(firstItem.getName(), secondItem.getName());
} }
private List<String> getStringList(List<CategoryItem> input) { private List<String> getStringList(List<CategoryItem> input) {

13
app/src/main/java/fr/free/nrw/commons/utils/StringSortingUtils.java
View file

@ -9,10 +9,19 @@ public class StringSortingUtils {
//no-op //no-op
} }
/**
* Returns Comparator for sorting strings by its similarity with Levenshtein
* algorithm. By using this Comparator we get results from the highest to
* the lowest match.
*
* @param filter pattern to compare similarity
* @return Comparator with string similarity
*/
public static Comparator<String> sortBySimilarity(final String filter) { public static Comparator<String> sortBySimilarity(final String filter) {
return (firstItem, secondItem) -> { return (firstItem, secondItem) -> {
double firstItemSimilarity = StringSortingUtils.calculateSimilarity(firstItem, filter); double firstItemSimilarity = calculateSimilarity(firstItem, filter);
double secondItemSimilarity = StringSortingUtils.calculateSimilarity(secondItem, filter); double secondItemSimilarity = calculateSimilarity(secondItem, filter);
return (int) Math.signum(secondItemSimilarity - firstItemSimilarity); return (int) Math.signum(secondItemSimilarity - firstItemSimilarity);
}; };
} }